From patchwork Wed Nov 25 12:25:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 41190 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29891385DC2E; Wed, 25 Nov 2020 12:25:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29891385DC2E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606307155; bh=TQpujm2e39SwgFHzN/RRl/iJrMva7xZciP+zzC0d9QA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=ve2dGd4m5g+u03r6VzPEItX0DcQcG9vysbR/J6aRz8SED+Kpfd9vq+cip0H88EEuE mIUJORV+zjquZz72qHjDQbIACbYWa6giFcbAylOYVMb0XZ2dDhN8AaomufIxXLdHA0 UVSCikVhfaam2iHaPGpFhasbp0GFnAfWr1jQfsIg= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A88DB385DC2E for ; Wed, 25 Nov 2020 12:25:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A88DB385DC2E Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-rN_Urj8oNaOdEiRtc7mkyg-1; Wed, 25 Nov 2020 07:25:50 -0500 X-MC-Unique: rN_Urj8oNaOdEiRtc7mkyg-1 Received: by mail-wr1-f69.google.com with SMTP id b5so724799wrp.3 for ; Wed, 25 Nov 2020 04:25:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=TQpujm2e39SwgFHzN/RRl/iJrMva7xZciP+zzC0d9QA=; b=Fnq3VumyMGxXzsbZqh9XKyxJCQkdyhTvj4xpBdS9rQGdX84cwy97oMj0Zs51r1Mc2J 6fm5NH7TEh/8TBqhjTJai4E0vjjWroD2XmnedgsKyyHEvPNv0WNA8PB3UsYXgVEBruO+ CWNSp1Sx22SuH4j3BTjCsrhpzgpM5NJEDsxaJ5bEE3vDeCxyDEiI0zOPLTiKkuUrQJwd edFe8GRaa+phCHofXLpUS17WCnZdpXEnR/im7Uhm5YfF924oER228bJ4bW+ez+MZaT+c SDo4r/pmQjL7RdWSIHhyxunEnyz8IvsYSAIE5+agtJN0coRvRauiO2FSqSlNGHjhaUF4 6GLg== X-Gm-Message-State: AOAM532mukGPDWy1/9y/LTfcmcM/m51S8SGUNEWczGItKRib0bIA5f7C yD8A300LgNYLCrltMdY8WsWUFDKEDxuqcijUcxZ/Nk32l+0selJ4jIbfBWKJf5MMNxtSZ/0kBiP pbijPIiwOd65W6MMTe/ougax2QDuSxGHRXHQtPf8Z9XKgTcMT5ab8l+LVcrSUs0mKsf2G X-Received: by 2002:a5d:4bc7:: with SMTP id l7mr4027646wrt.105.1606307148794; Wed, 25 Nov 2020 04:25:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbTi3fwz6GAQKeFXaFVwTqzZg+bhNRAItmzg/9tLnvFHz8n21KvD03/AG45hyKQ7+qd+IIxg== X-Received: by 2002:a5d:4bc7:: with SMTP id l7mr4027618wrt.105.1606307148476; Wed, 25 Nov 2020 04:25:48 -0800 (PST) Received: from localhost ([2a01:e0a:1a0:d060:5246:5dff:feab:d19c]) by smtp.gmail.com with ESMTPSA id d8sm4698905wrp.44.2020.11.25.04.25.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 04:25:47 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id E5823581C96; Wed, 25 Nov 2020 13:25:46 +0100 (CET) To: libabigail@sourceware.org Subject: [PATCH] tests/data/test-fedabipkgdiff: Update reference output Organization: Red Hat / France X-Operating-System: Fedora 34 X-URL: http://www.redhat.com Date: Wed, 25 Nov 2020 13:25:46 +0100 Message-ID: <874kld8vxx.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Hello, Instances of self_compare_task don't wrongly shadow task comparison arguments anymore. Instead, they properly use the task comparison arguments of the parent class compare_task. This is thanks to this commit: 18b0693c (PR26785) abipkgdiff: minor cleanups So in the sorting function elf_size_is_greater, we now always have proper elf binaries size. It follows that the sorting can now yield a consistent result, always. It thus appears that the reference output recorded for the "self-comparison" test of runtestfedabipkgdiffpy3.sh was wrong. This patch updates it. * tests/data/test-fedabipkgdiff/test7-self-compare-from-fc23-dbus-glib-report-0.txt: Adjust. Signed-off-by: Dodji Seketeli --- .../test7-self-compare-from-fc23-dbus-glib-report-0.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/data/test-fedabipkgdiff/test7-self-compare-from-fc23-dbus-glib-report-0.txt b/tests/data/test-fedabipkgdiff/test7-self-compare-from-fc23-dbus-glib-report-0.txt index e037e7eb..5c5b95d3 100644 --- a/tests/data/test-fedabipkgdiff/test7-self-compare-from-fc23-dbus-glib-report-0.txt +++ b/tests/data/test-fedabipkgdiff/test7-self-compare-from-fc23-dbus-glib-report-0.txt @@ -1,7 +1,7 @@ Comparing the ABI of binaries between dbus-glib-0.106-1.fc23.i686.rpm and dbus-glib-0.106-1.fc23.i686.rpm: -==== SELF CHECK SUCCEEDED for 'dbus-binding-tool' ==== ==== SELF CHECK SUCCEEDED for 'libdbus-glib-1.so.2.3.3' ==== +==== SELF CHECK SUCCEEDED for 'dbus-binding-tool' ==== Comparing the ABI of binaries between dbus-glib-devel-0.106-1.fc23.i686.rpm and dbus-glib-devel-0.106-1.fc23.i686.rpm: @@ -9,8 +9,8 @@ Comparing the ABI of binaries between dbus-glib-devel-0.106-1.fc23.i686.rpm and Comparing the ABI of binaries between dbus-glib-0.106-1.fc23.x86_64.rpm and dbus-glib-0.106-1.fc23.x86_64.rpm: -==== SELF CHECK SUCCEEDED for 'dbus-binding-tool' ==== ==== SELF CHECK SUCCEEDED for 'libdbus-glib-1.so.2.3.3' ==== +==== SELF CHECK SUCCEEDED for 'dbus-binding-tool' ==== Comparing the ABI of binaries between dbus-glib-devel-0.106-1.fc23.x86_64.rpm and dbus-glib-devel-0.106-1.fc23.x86_64.rpm: