diff mbox series

[5/6] abidw: make --abidiff report any change against own ABIXML

Message ID 87v9dq683y.fsf@redhat.com
State New
Headers show
Series Fix subtle ABI artifact representation issues | expand

Commit Message

Dodji Seketeli Nov. 27, 2020, 5:08 p.m. UTC
Hello,

Sometimes, "abidw --abidiff <binary>" would pass while
"abidw <binary> > abi; abidiff <binary> abi" would fail.

This is because "abidw --abidiff" emits an error only when the
comparison between the binary and its ABIXML representation yields and
incompatible change.

Now that many subtle causes of spurious ABI change report emitted when
comparing a binary against its own ABIXML have been fixed, this patch
makes it so that *any* change would make abidw --abidiff to emit an
error.

	* tools/abidw.cc (load_corpus_and_write_abixml): Emit an error
	when comparing the binary to its ABIXML representation yields any
	change.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>

Applied to master.

---
 tools/abidw.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tools/abidw.cc b/tools/abidw.cc
index 756a29ec..6e37132c 100644
--- a/tools/abidw.cc
+++ b/tools/abidw.cc
@@ -593,7 +593,7 @@  load_corpus_and_write_abixml(char* argv[],
 	    emit_prefix(argv[0], cerr)
 	      << "computed diff in: " << t << "\n";
 
-	  bool has_error = diff->has_incompatible_changes();
+	  bool has_error = diff->has_changes();
 	  if (has_error)
 	    {
 	      t.start();