From patchwork Fri Nov 27 17:08:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 41222 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6F1F3851C07; Fri, 27 Nov 2020 17:08:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6F1F3851C07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606496936; bh=+XGIh4yXgOs/5t+A5nFox4expiermFaCKQxL3JwLWbU=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=psZ1qg5ol75ewoSqqEpAkNpDdzXI9LxAkXjAqIcPa8tNHPtHqJxTEgRKloZOAt7XB F9BkGcx2l2eqcWtRJ5zHsSkJXFCda0Qx00szIA4lQLmT6uwmj7R9Y1nGuzlebTq3xc rm9RRVUy/mb1yk4CJqeO0iQDw7uXNJ7eb8yCn7bs= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 00C5A3858026 for ; Fri, 27 Nov 2020 17:08:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 00C5A3858026 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-Gf7vs-oNOAakf7UeYilo_A-1; Fri, 27 Nov 2020 12:08:46 -0500 X-MC-Unique: Gf7vs-oNOAakf7UeYilo_A-1 Received: by mail-wr1-f72.google.com with SMTP id p16so3728259wrx.4 for ; Fri, 27 Nov 2020 09:08:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+XGIh4yXgOs/5t+A5nFox4expiermFaCKQxL3JwLWbU=; b=OF7ewlXDnt5w5Yscx0VRkvJNU169IbZbjXQLxniRDvknymll34y3v5XCwy1K32zX36 5+u5kSG+1iD09WLgmjQ64cutg6+c7UUXzu6yaMQzAToeoAjyIkqhewH92Gu1viOg78JX 0AnME/8QP0keNAErKMR4TMy8mF3mt7sxMAa4whslj4Bu0qm/ZfoiGnm8xujP//MzXW9v M/BPoW01H/GwXprr10+6qCcEJJ23u/sF4Ud0achIuCJ1IDe6y9a+ZuDkAUVVMk5ear2p kffeZS/WjOMN6HU4lC1N+JkqhNA44qHAg3oF39i7kXlOHfl+nS3IMtCXhGcx89ZU7frz IEeQ== X-Gm-Message-State: AOAM533eESdX5pLVfCdyY549LMEL+hCwgBp/el/Vc3r7y2V7Aa/eX/VQ 1iYJn5XAiLRTAm6C3G6+I8p3Mxv/kFYe/Hoh4CJftYFydaEH8rkwXpWU3molRBbsCpqYf7kKWC8 L4wiJR6PW40KBmecHdPEs X-Received: by 2002:a1c:9e41:: with SMTP id h62mr503729wme.51.1606496925417; Fri, 27 Nov 2020 09:08:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHswev1GpekxRbzH1/X6z5c6xR567RBqNxT6n1ml6uw29KQ+IZpeS19XUfWxRgPHcq7bU2AA== X-Received: by 2002:a1c:9e41:: with SMTP id h62mr503712wme.51.1606496925163; Fri, 27 Nov 2020 09:08:45 -0800 (PST) Received: from localhost (91-166-131-65.subs.proxad.net. [91.166.131.65]) by smtp.gmail.com with ESMTPSA id a15sm14201099wmj.2.2020.11.27.09.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 09:08:44 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 929DC5802B4; Fri, 27 Nov 2020 18:08:43 +0100 (CET) To: Dodji Seketeli Subject: [PATCH 6/6] abipkgdiff: make --self-check to fail on any change against own ABIXML Organization: Red Hat / France References: <87h7pa7n8c.fsf@redhat.com> X-Operating-System: Fedora 34 X-URL: http://www.redhat.com Date: Fri, 27 Nov 2020 18:08:43 +0100 In-Reply-To: <87h7pa7n8c.fsf@redhat.com> (Dodji Seketeli's message of "Fri, 27 Nov 2020 17:56:03 +0100") Message-ID: <87r1oe682s.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Cc: libabigail@sourceware.org Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Hello, Now that several subtle causes of spurious ABI change report when comparing a binary against its own ABIXML have been addressed, this patch makes 'abipkgdiff --self-check' to fail on any ABI change reported. That is, harmless changes are not ignored anymore. * tools/abipkgdiff.cc (compare_to_self): Report *any* ABI change. Not just the "net" changes. Signed-off-by: Dodji Seketeli Applied to master. --- tools/abipkgdiff.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc index 2968338a..709b687a 100644 --- a/tools/abipkgdiff.cc +++ b/tools/abipkgdiff.cc @@ -1649,7 +1649,7 @@ compare_to_self(const elf_file& elf, << "... Comparing the ABIs: DONE\n"; abidiff_status s = abigail::tools_utils::ABIDIFF_OK; - if (diff->has_net_changes()) + if (diff->has_changes()) s |= abigail::tools_utils::ABIDIFF_ABI_CHANGE; if (diff->has_incompatible_changes()) s |= abigail::tools_utils::ABIDIFF_ABI_INCOMPATIBLE_CHANGE;