From patchwork Fri Nov 27 16:39:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 41214 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3366A3858026; Fri, 27 Nov 2020 16:39:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3366A3858026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606495166; bh=26Fir1m1VieoeggoqZZgSjbguUUMTofEhnJ0Rt6oZqw=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=qOSThKXsFhQ4DdfAkvrsd+8lT9TBisyrJCR7qsVuAE17wq/VycsmEIQX8qNfjT/+A 1VGlvxmiKJoU9KGIZRr3Rqij46l8p1CLT1a0WqYJfa7MNW0l9I65ChiB4pd5CBV50H 5HZZk+hsPLipXQhkbPt4YbbjEzAW5Kjlu93e5Yzg= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id A15AC3973056 for ; Fri, 27 Nov 2020 16:39:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A15AC3973056 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-sQtNRP1-MOWX3aB-XnWQYA-1; Fri, 27 Nov 2020 11:39:21 -0500 X-MC-Unique: sQtNRP1-MOWX3aB-XnWQYA-1 Received: by mail-wm1-f72.google.com with SMTP id k128so3395517wme.7 for ; Fri, 27 Nov 2020 08:39:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=26Fir1m1VieoeggoqZZgSjbguUUMTofEhnJ0Rt6oZqw=; b=f5laBoXDZZ/DROq/BRGTHhbPsfWznUy03tRsqTexft1H6Ig+Smj1rLy7Dz9UxPRoIW i/i/PJqmifFZxcRSiJA5TTAF/x8j0let68AeQebQLTGRnMlRVR0tB4GV2SUchRyoQjh0 jHN88BCmwHYRDpHIDNkQ8vCZKb8M+WMtpyVMFzcgua9m4kNThJ6/jqB6OfjOTtTUeNSw TPlMkrkkwD1/gN56pBic+xt4yuvlV/zr5OEiH4s66X5bUQtYXFBHvwrtULkloyYwP06I ney774UGT3XaoKFVw4phjAtU8SmXBKX0WWRxs/M9ivC2m0sC2HFsy5+VQHFy7SDZpTX/ pkLQ== X-Gm-Message-State: AOAM533zzXl5RkEW3Jr4WEBWPKLkh0GqbfhcEK361Xw+UzPvn+FhO/Ds ei9RPLEBehpZKAMyC5fGcUAu0DH3oZwhnJyO3pRHyk95SYDRE+eynXnlOR8H59QKLzsSLLZ0yNI jGnuzYp+opJoaC5Fe5K8h X-Received: by 2002:adf:ec0d:: with SMTP id x13mr4957365wrn.207.1606495159092; Fri, 27 Nov 2020 08:39:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBhcthpWC5CBlahyyMxzZjKW2FN5xdXQflOvkijRjot10ucBA4qJvv4aHvqWDDQ3rP9T3H8w== X-Received: by 2002:adf:ec0d:: with SMTP id x13mr4957344wrn.207.1606495158847; Fri, 27 Nov 2020 08:39:18 -0800 (PST) Received: from localhost ([2a01:e0a:1a0:d060:5246:5dff:feab:d19c]) by smtp.gmail.com with ESMTPSA id d3sm15489451wre.91.2020.11.27.08.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 08:39:17 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 75F895802B4; Fri, 27 Nov 2020 17:39:16 +0100 (CET) To: libabigail@sourceware.org Subject: [PATCH 1/2] reader: Read array subrange length into an uint64_t Organization: Red Hat / France References: <87wny67of6.fsf@redhat.com> X-Operating-System: Fedora 34 X-URL: http://www.redhat.com Date: Fri, 27 Nov 2020 17:39:16 +0100 In-Reply-To: <87wny67of6.fsf@redhat.com> (Dodji Seketeli's message of "Fri, 27 Nov 2020 17:30:21 +0100") Message-ID: <87pn3y7o0b.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Hello, We read subrange length like an integer of type 'int" today. We should read it as an uint64_t. Fixed thus. * src/abg-reader.cc (build_subrange_type): Change the type of length to uint64_t and read it using strtoull. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-reader.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/abg-reader.cc b/src/abg-reader.cc index 174bb3cd..ef9b44e5 100644 --- a/src/abg-reader.cc +++ b/src/abg-reader.cc @@ -3841,7 +3841,7 @@ build_subrange_type(read_context& ctxt, if (xml_char_sptr s = XML_NODE_GET_ATTRIBUTE(node, "name")) name = CHAR_STR(s); - size_t length = 0; + uint64_t length = 0; string length_str; bool is_infinite = false; if (xml_char_sptr s = XML_NODE_GET_ATTRIBUTE(node, "length")) @@ -3849,7 +3849,7 @@ build_subrange_type(read_context& ctxt, if (string(CHAR_STR(s)) == "infinite") is_infinite = true; else - length = atoi(CHAR_STR(s)); + length = strtoull(CHAR_STR(s), NULL, 0); } string underlying_type_id;