From patchwork Thu Apr 18 16:15:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 88670 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F043638708B0 for ; Thu, 18 Apr 2024 16:15:28 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 208C93858C78 for ; Thu, 18 Apr 2024 16:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 208C93858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 208C93858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713456924; cv=none; b=fRuTH5Es2CQ87OR6YdMbLxvggjnn//zCpOXzjkxwSNeRw5nKTKqjrjCtThRg0LpXpxek6TLwAPS5NQYyWaDcfatx+WT+bNyVLfcPI5B1VJHZtIw92ZVB4Rk/vRd4E6hQOYvYQqgtwBKUIR+PJaW2gT4cpNkqburWHn6Eb/RMaHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713456924; c=relaxed/simple; bh=Y39Gz2m/M7IrK28jySm87tbpBflyo+W2u1slCHF5GTw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ErqZxG+PQhl9uQ5fCyxoM8rKNrbHnZFWGyFSIsoxvZyEP+2vgY41b7ohTFJjOMCOckkbottueq4c60hrK9j9h/pAYZI1s29sLO9rmnSgCn/H1v6Wg/0bO8GeQ8dTwE/UMYodCT30hGK4Eb1ZTQbTTw79ku7M0Llzt37tHJKZFGQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713456919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=1Bdj7NaAZGX01yjaqKRhSnpmgT7GWKwTN/QqcJROoOc=; b=TdX+JuJcexPkAPOfns1kt2SlHy0wcaZLwxhDaxsFIk2faS6Nh6Iv/CU/gWcnD9kgsfelvW FH1MeqEDlRa4VWI7lNnjeA6+VRJUG4x1CTsDx1sKt+75QVhToiYbzS0UyMM226OlUDAk6b JipQpqiXdxy7a+uwgoW3zxk0QeEf6C4= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-N0IMogQnMAKbWCOg5CVL2A-1; Thu, 18 Apr 2024 12:15:12 -0400 X-MC-Unique: N0IMogQnMAKbWCOg5CVL2A-1 Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-6ebc3864709so1453498a34.1 for ; Thu, 18 Apr 2024 09:15:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713456912; x=1714061712; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Bdj7NaAZGX01yjaqKRhSnpmgT7GWKwTN/QqcJROoOc=; b=Ds7g08iE6+iU3qUB0aC/S2/roE8VqcVY9mQ0HBP1pblAaKoptReEPouWFIeSXzJb+2 LJomKtQkGRRnD3JwOTDEXLcF7LfpzSK/K4nfoTBxLV35GsZ/oY3Ioq+LqKWcsRv6cVlC nr3tdIWYpK5CnRPZs/9iqiF7lF4ntTzfecl1VwP5zzG8I2QztUbAJaC8EG3rMcHar3CP mUL99rSAdTkJMaP2emETUf0HLmhke/uEU8C7z2j78FPcyPpmI4ccxPruPtuy3sKXqBW4 BvMbjkRpzBfrWAJll+dU857ecnXvj8vbwK4rKbMfXslGdYlaBNaQtGq0sf3PhypiydDO cbjw== X-Gm-Message-State: AOJu0YygUnjSZYxa2xM0PIXDTSS0s4tqGXvvaFzWIxfdU3H03+r65uYG DrHle4IIlAJ9/zenhVsS+W5R1rQ81qo6SBIoyvmgh8dmUfTFzs7QDk1pKuWzCif0ZmPb94K7c58 2BewLwJB8fMbyMYJWyISd932Hg5UOoI9jr9OaLOzlXjyaXS2IfhRrg2Qv7J9uasRS7UHsmTlS/N eg2qmPw1RFMa3IYc3GCK/2mc0gpExemgYlGHefzA== X-Received: by 2002:a9d:62c4:0:b0:6eb:8889:b9d with SMTP id z4-20020a9d62c4000000b006eb88890b9dmr3637890otk.17.1713456911962; Thu, 18 Apr 2024 09:15:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHn334DlsgiaxU1NHFGf93z6xR+aDqnABBOcwwX/dQU5gIZPWPSTv0+A2OZ5Q6W58AC/zgjXg== X-Received: by 2002:a9d:62c4:0:b0:6eb:8889:b9d with SMTP id z4-20020a9d62c4000000b006eb88890b9dmr3637864otk.17.1713456911564; Thu, 18 Apr 2024 09:15:11 -0700 (PDT) Received: from localhost (88-120-130-27.subs.proxad.net. [88.120.130.27]) by smtp.gmail.com with ESMTPSA id r6-20020a05620a298600b0078d43da0be3sm759666qkp.5.2024.04.18.09.15.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 09:15:11 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 6924E5077C43; Thu, 18 Apr 2024 18:15:09 +0200 (CEST) From: Dodji Seketeli To: libabigail@sourceware.org Subject: [PATCH, applied] configure: Add option to disable abidb Organization: Red Hat / France X-Operating-System: AlmaLinux 9.3 X-URL: http://www.redhat.com Date: Thu, 18 Apr 2024 18:15:09 +0200 Message-ID: <87h6fyir5e.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Hello, While looking at packaging libabigail for EPEL8, it turned out abidb requires python 3.9 for the type hints on function definitions. Yet, EPEL8 has an older python. This patch adds a --disable-abidb option to configure to handle EPEL8. * configure.ac: Add a --disable-abidb option to configure to disable the abidb tool and related tests. Signed-off-by: Dodji Seketeli Applied to the master branch. --- configure.ac | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4b115e65..d329490c 100644 --- a/configure.ac +++ b/configure.ac @@ -182,6 +182,12 @@ AC_ARG_ENABLE([fedabipkgdiff], ENABLE_FEDABIPKGDIFF=$enableval, ENABLE_FEDABIPKGDIFF=auto) +AC_ARG_ENABLE(abidb, + AS_HELP_STRING([--enable-abidb=yes|no|auto], + [enable the support of the abidb tool (default is auto)]), + ENABLE_ABIDB=$enableval, + ENABLE_ABIDB=auto) + AC_ARG_ENABLE([python3], AS_HELP_STRING([--enable-python3=yes|no|auto], [enable running abigail tools with python3 (default is auto)]), @@ -817,8 +823,7 @@ except koji.ConfigurationError: fi dnl abidb checks -ENABLE_ABIDB=no -if test x$PYTHON3_INTERPRETER != xno; then +if test x$PYTHON3_INTERPRETER != xno -a x$ENABLE_ABIDB != xno; then AX_CHECK_PYTHON_MODULES([git libarchive], [$PYTHON], [FOUND_ALL_PYTHON_MODULES=yes], @@ -830,6 +835,8 @@ if test x$PYTHON3_INTERPRETER != xno; then else ENABLE_ABIDB=yes fi +else + AC_MSG_NOTICE([disabling abidb]) fi AM_CONDITIONAL(ENABLE_ABIDB, test x$ENABLE_ABIDB = xyes)