diff mbox series

abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value

Message ID 20210208173146.391981-1-gprocida@google.com
State New
Headers show
Series abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value | expand

Commit Message

Giuliano Procida Feb. 8, 2021, 5:31 p.m. UTC
A recent commit to add DW_FORM_line_strp support had a small typo in
an assertion. This commit corrects that.

	* src/abg-dwarf-reader.cc
	(compare_dies_string_attribute_value): Typo fix.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-dwarf-reader.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dodji Seketeli Feb. 9, 2021, 2:39 p.m. UTC | #1
Giuliano Procida <gprocida@google.com> a écrit:

> A recent commit to add DW_FORM_line_strp support had a small typo in
> an assertion. This commit corrects that.
>
> 	* src/abg-dwarf-reader.cc
> 	(compare_dies_string_attribute_value): Typo fix.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
> ---
>  src/abg-dwarf-reader.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
> index 810da2f2..9004ff13 100644
> --- a/src/abg-dwarf-reader.cc
> +++ b/src/abg-dwarf-reader.cc
> @@ -9446,7 +9446,7 @@ compare_dies_string_attribute_value(const Dwarf_Die *l, const Dwarf_Die *r,
>  	     || r_attr.form == DW_FORM_string
>  	     || r_attr.form == DW_FORM_GNU_strp_alt
>  	     || form_is_DW_FORM_strx(r_attr.form)
> -	     || form_is_DW_FORM_line_strp(l_attr.form));
> +	     || form_is_DW_FORM_line_strp(r_attr.form));
>  
>    if ((l_attr.form == DW_FORM_strp
>         && r_attr.form == DW_FORM_strp)

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index 810da2f2..9004ff13 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -9446,7 +9446,7 @@  compare_dies_string_attribute_value(const Dwarf_Die *l, const Dwarf_Die *r,
 	     || r_attr.form == DW_FORM_string
 	     || r_attr.form == DW_FORM_GNU_strp_alt
 	     || form_is_DW_FORM_strx(r_attr.form)
-	     || form_is_DW_FORM_line_strp(l_attr.form));
+	     || form_is_DW_FORM_line_strp(r_attr.form));
 
   if ((l_attr.form == DW_FORM_strp
        && r_attr.form == DW_FORM_strp)