From patchwork Wed Jan 27 12:58:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Matthias_M=C3=A4nnich?= X-Patchwork-Id: 41838 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D17963971C3C; Wed, 27 Jan 2021 12:59:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D17963971C3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611752358; bh=IEj+VDlJ6TcTEtpciyhJQZfM3Vt/s/2x1yOHuFtKw/o=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=tkbjx7a53FD4HiAzCTGR+Dn5UFAjK8ARP4piqIWeCJ/8M7B+ZDEVn54FRlNFGGzRe Blf8pmIBr4OR/Pfl3ZOqYCmRIXu6rCJOyoJw056yswJ9Kw/URrAEUp8NLegP6ZJU1S hDXRbkrQ5c9+6p5qSImeqTIvYAtIp8MEAHQwNj3M= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by sourceware.org (Postfix) with ESMTPS id 8CEB43971C3C for ; Wed, 27 Jan 2021 12:59:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8CEB43971C3C Received: by mail-qt1-x849.google.com with SMTP id f5so1011413qtf.15 for ; Wed, 27 Jan 2021 04:59:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=IEj+VDlJ6TcTEtpciyhJQZfM3Vt/s/2x1yOHuFtKw/o=; b=GG1D3YPiWBKU6W3nfJvXU4meiGcli11ogPL4QnAkYj2DPxag6TO7R58UgsiPnMCi78 vu8/8sk6qBq0JPlq5GTc6iFHtBPCLEGH2k5h3Ug+HomOj4pWwuaZNRPNLcYED1OQh3Y1 9E9+Fc8IYetn668akVlbof/UP7Ky9RP9awMvDbr2me3Dd1Ve+Z/tiVNjkxt9iDwjKlAV QQQw4JU0q/tSL4nJGMM3ahf6QLGozEYXSGZtkt5MxY05AdGJA9G/u9Og9qQMBzkH0pF2 gjX2B/0ltWqJLKAz5CGbCN/6z36M3ya/dIdZcNPxCzIMRXOALYwbptCmhOEws9ESS3rk +NnQ== X-Gm-Message-State: AOAM532iGa7G+LZyeJW7FifT5dEEEjYUM72TDHnJ/SfJhySpTk0iQoBy tRxOwlPXbFdTzTPi3fsNt7xeUFJUadGS/H3urXTCxzYAOw8Xu5UPT8kdXWb1+o3t6pV3vhnUr+X TMWGnK6OAz+G4eAAwyteT7IHUZzB9lhsI8bMI5KTGCGL9y0m1VjX6Hid/h9JN/6XwSba4U48= X-Google-Smtp-Source: ABdhPJy5MmP8lUHwTxg4xTULSfjKSurWpBxw0vlGdsg8g1I+KmQ0GunaBGEdPaQreFtn3ESo7fCSOLEyn01Qzg== X-Received: from lux.lon.corp.google.com ([2a00:79e0:d:210:7220:84ff:fe09:a3aa]) (user=maennich job=sendgmr) by 2002:a0c:c30e:: with SMTP id f14mr10184150qvi.48.1611752355002; Wed, 27 Jan 2021 04:59:15 -0800 (PST) Date: Wed, 27 Jan 2021 12:58:37 +0000 In-Reply-To: <20210127125853.886677-1-maennich@google.com> Message-Id: <20210127125853.886677-5-maennich@google.com> Mime-Version: 1.0 References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> X-Mailer: git-send-email 2.30.0.280.ga3ce27912f-goog Subject: [PATCH 04/20] dwarf-reader split: create abg-symtab-reader.{h, cc} and test case To: libabigail@sourceware.org X-Spam-Status: No, score=-22.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Matthias Maennich via Libabigail From: =?utf-8?q?Matthias_M=C3=A4nnich?= Reply-To: Matthias Maennich Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" abg-symtab-reader.{h,cc} shall contain the refactored symtab reader. Create the stub files, an empty unit test and hook everything up in the make system. * src/abg-symtab-reader.h: New header file. * src/abg-symtab-reader.cc: New source file. * src/Makefile.am: Add new source files. * tests/Makefile.am: Add new test case runtestsymtabreader. * tests/test-symtab-reader.cc: New test source file. Reviewed-by: Giuliano Procida Signed-off-by: Matthias Maennich --- src/Makefile.am | 2 ++ src/abg-symtab-reader.cc | 21 +++++++++++++++++++++ src/abg-symtab-reader.h | 24 ++++++++++++++++++++++++ tests/Makefile.am | 4 ++++ tests/test-symtab-reader.cc | 15 +++++++++++++++ 5 files changed, 66 insertions(+) create mode 100644 src/abg-symtab-reader.cc create mode 100644 src/abg-symtab-reader.h create mode 100644 tests/test-symtab-reader.cc diff --git a/src/Makefile.am b/src/Makefile.am index 26fc4d1566ca..86877635be03 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -38,6 +38,8 @@ abg-tools-utils.cc \ abg-elf-helpers.h \ abg-elf-helpers.cc \ abg-regex.cc \ +abg-symtab-reader.h \ +abg-symtab-reader.cc \ $(VIZ_SOURCES) libabigail_la_LIBADD = $(DEPS_LIBS) diff --git a/src/abg-symtab-reader.cc b/src/abg-symtab-reader.cc new file mode 100644 index 000000000000..a6c8ca0ef548 --- /dev/null +++ b/src/abg-symtab-reader.cc @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// -*- Mode: C++ -*- +// +// Copyright (C) 2020 Google, Inc. +// +// Author: Matthias Maennich + +/// @file +/// +/// This contains the definition of the symtab reader + +#include "abg-symtab-reader.h" + +namespace abigail +{ + +namespace symtab_reader +{ + +} // end namespace symtab_reader +} // end namespace abigail diff --git a/src/abg-symtab-reader.h b/src/abg-symtab-reader.h new file mode 100644 index 000000000000..a929166b83ef --- /dev/null +++ b/src/abg-symtab-reader.h @@ -0,0 +1,24 @@ +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// -*- Mode: C++ -*- +// +// Copyright (C) 2020 Google, Inc. +// +// Author: Matthias Maennich + +/// @file +/// +/// This contains the declarations for the symtab reader. + +#ifndef __ABG_SYMTAB_READER_H__ +#define __ABG_SYMTAB_READER_H__ + +namespace abigail +{ + +namespace symtab_reader +{ + +} // end namespace symtab_reader +} // end namespace abigail + +#endif // __ABG_SYMTAB_READER_H__ diff --git a/tests/Makefile.am b/tests/Makefile.am index 655facb19ec1..533cc23680ce 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -46,6 +46,7 @@ runtestkmiwhitelist \ runtestlookupsyms \ runtestreadwrite \ runtestsymtab \ +runtestsymtabreader \ runtesttoolsutils \ runtestsvg \ $(FEDABIPKGDIFF_TEST) \ @@ -156,6 +157,9 @@ runtestcxxcompat_LDADD = libcatch.la $(top_builddir)/src/libabigail.la runtestsymtab_SOURCES = test-symtab.cc runtestsymtab_LDADD = libtestutils.la libcatch.la $(top_builddir)/src/libabigail.la +runtestsymtabreader_SOURCES = test-symtab-reader.cc +runtestsymtabreader_LDADD = libcatch.la $(top_builddir)/src/libabigail.la + runtestsvg_SOURCES=test-svg.cc runtestsvg_LDADD=$(top_builddir)/src/libabigail.la diff --git a/tests/test-symtab-reader.cc b/tests/test-symtab-reader.cc new file mode 100644 index 000000000000..1bd37572f4d7 --- /dev/null +++ b/tests/test-symtab-reader.cc @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// -*- Mode: C++ -*- +// +// Copyright (C) 2020 Google, Inc. +// +// Author: Matthias Maennich + +/// @file +/// +/// This program tests libabigail's symtab reader. + +#include "lib/catch.hpp" + +#include "abg-symtab-reader.h" +