From patchwork Fri Jun 19 21:42:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Matthias_M=C3=A4nnich?= X-Patchwork-Id: 39699 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 619DB3898535; Fri, 19 Jun 2020 21:43:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 619DB3898535 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1592603006; bh=BT0nIJi6pLi3zCx7vY5LVJFNxHcF2zWQ8zfP3KEG/nM=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=wer3NxKQY/iF2NQKJm+c/Qb7ypBNIW1tpoVqZ1kPbLl05WPiHxtGkkaRj2nDV1qFf WnaQwUEk4derg8eXetTxW/KYZvEcVNMNMMzSMNDoC7y78iDoDgn+kkCYGaOs9wY/m5 LMzahzqhb7djnyPI7VaXhOpmw+2nGvURvyf1LcEI= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by sourceware.org (Postfix) with ESMTPS id 6062F3938C29 for ; Fri, 19 Jun 2020 21:43:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6062F3938C29 Received: by mail-qt1-x849.google.com with SMTP id y7so8185085qti.8 for ; Fri, 19 Jun 2020 14:43:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=BT0nIJi6pLi3zCx7vY5LVJFNxHcF2zWQ8zfP3KEG/nM=; b=cU0daDgHPigDSLbIZrt6qVjZYIJvPPLtxhfeoDTjRlt7T0MY75C4tn33Mhu6J+R/AE GBrKASdLjmYBgZbM5JOXhWWUsiN4MtXAtAkz/A2UJUtr7ln3p30g+Se/kcfX/OoqaWrn CbNZXxQjuaZIelEDmjl13icLXRfKux/PWekUSFtjAfQdlIcegscGdqI2YU5GfW99j5PO mxiF1Hb+uzJcSN3WIXDCKMwWog6f1qzL47NJ+AjY8PbW9vwjtCkBMoNETYkFzqQjI3IB 1NOgbWfD1wOWkmFcrzWbJ1flua4p5K1svk4LBsXn89yMB30lPSNgwQvT15mIhA1v4/ym +DMQ== X-Gm-Message-State: AOAM530fFxXEqII6Fbl8Ww9Ieo3K6hET4nLGZrDQJwjG/F58HQbDZZqe mxUCbxzitF8WcTuPmzyBXxqBRePzB3+ABS6Mjxg2i9UNXMcE9rRjN5qIrl4VWP8PatUc7AdZgPU u9qeAGPn2wTf6Bm9ovnjcHu7icYipiZv4wOAk5+Zh5ly1R48ey8zntQp9HuM0mz5AQ5L/QHc= X-Google-Smtp-Source: ABdhPJwxOy345swJ++A/bbSEVemru6rrnCuQqKpO7vuy8clX+Z8jN8cOQxTKS+cN+yNIwDnhnZU1iFojEkexfw== X-Received: by 2002:a05:6214:108d:: with SMTP id o13mr10596014qvr.58.1592603002890; Fri, 19 Jun 2020 14:43:22 -0700 (PDT) Date: Fri, 19 Jun 2020 23:42:54 +0200 In-Reply-To: <20200619214305.562-1-maennich@google.com> Message-Id: <20200619214305.562-6-maennich@google.com> Mime-Version: 1.0 References: <20200619214305.562-1-maennich@google.com> X-Mailer: git-send-email 2.27.0.111.gc72c7da667-goog Subject: [PATCH v1 05/16] dwarf-reader split: create abg-symtab-reader.{h, cc} and test case To: libabigail@sourceware.org X-Spam-Status: No, score=-22.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Matthias Maennich via Libabigail From: =?utf-8?q?Matthias_M=C3=A4nnich?= Reply-To: Matthias Maennich Cc: maennich@google.com, gprocida@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" abg-symtab-reader.{h,cc} shall contain the refactored symtab reader. Create the stub files, an empty unit test and hook everything up in the make system. * include/abg-symtab-reader.h: New header file. * include/Makefile.am: Add new header file abg-symtab-reader.h. * src/Makefile.am: Add new source file abg-symtab-reader.cc. * src/abg-symtab-reader.cc: New source file. * tests/Makefile.am: Add new test case runtestsymtabreader. * tests/test-symtab-reader.cc: New test source file. Reviewed-by: Giuliano Procida Signed-off-by: Matthias Maennich --- include/Makefile.am | 3 ++- include/abg-symtab-reader.h | 39 +++++++++++++++++++++++++++++++++++++ src/Makefile.am | 1 + src/abg-symtab-reader.cc | 36 ++++++++++++++++++++++++++++++++++ tests/Makefile.am | 4 ++++ tests/test-symtab-reader.cc | 30 ++++++++++++++++++++++++++++ 6 files changed, 112 insertions(+), 1 deletion(-) create mode 100644 include/abg-symtab-reader.h create mode 100644 src/abg-symtab-reader.cc create mode 100644 tests/test-symtab-reader.cc diff --git a/include/Makefile.am b/include/Makefile.am index b547525238ec..639906aafe5b 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -25,6 +25,7 @@ abg-version.h \ abg-viz-common.h \ abg-viz-dot.h \ abg-viz-svg.h \ -abg-regex.h +abg-regex.h \ +abg-symtab-reader.h EXTRA_DIST = abg-version.h.in diff --git a/include/abg-symtab-reader.h b/include/abg-symtab-reader.h new file mode 100644 index 000000000000..b61e6399fe93 --- /dev/null +++ b/include/abg-symtab-reader.h @@ -0,0 +1,39 @@ +// -*- Mode: C++ -*- +// +// Copyright (C) 2020 Google, Inc. +// +// This file is part of the GNU Application Binary Interface Generic +// Analysis and Instrumentation Library (libabigail). This library is +// free software; you can redistribute it and/or modify it under the +// terms of the GNU Lesser General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) any +// later version. + +// This library is distributed in the hope that it will be useful, but +// WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Lesser Public License for more details. + +// You should have received a copy of the GNU Lesser General Public +// License along with this program; see the file COPYING-LGPLV3. If +// not, see . +// +// Author: Matthias Maennich + +/// @file +/// +/// This contains the declarations for the symtab reader. + +#ifndef __ABG_SYMTAB_READER_H__ +#define __ABG_SYMTAB_READER_H__ + +namespace abigail +{ + +namespace symtab_reader +{ + +} // end namespace symtab_reader +} // end namespace abigail + +#endif // __ABG_SYMTAB_READER_H__ diff --git a/src/Makefile.am b/src/Makefile.am index 1153a5f8b158..dff17d9c02c1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -41,6 +41,7 @@ abg-tools-utils.cc \ abg-elf-helpers.h \ abg-elf-helpers.cc \ abg-regex.cc \ +abg-symtab-reader.cc \ $(CXX11_SOURCES) libabigail_la_LIBADD = $(DEPS_LIBS) diff --git a/src/abg-symtab-reader.cc b/src/abg-symtab-reader.cc new file mode 100644 index 000000000000..1f934d3a7609 --- /dev/null +++ b/src/abg-symtab-reader.cc @@ -0,0 +1,36 @@ +// -*- Mode: C++ -*- +// +// Copyright (C) 2020 Google, Inc. +// +// This file is part of the GNU Application Binary Interface Generic +// Analysis and Instrumentation Library (libabigail). This library is +// free software; you can redistribute it and/or modify it under the +// terms of the GNU Lesser General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) any +// later version. + +// This library is distributed in the hope that it will be useful, but +// WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Lesser Public License for more details. + +// You should have received a copy of the GNU Lesser General Public +// License along with this program; see the file COPYING-LGPLV3. If +// not, see . +// +// Author: Matthias Maennich + +/// @file +/// +/// This contains the definition of the symtab reader + +#include "abg-symtab-reader.h" + +namespace abigail +{ + +namespace symtab_reader +{ + +} // end namespace symtab_reader +} // end namespace abigail diff --git a/tests/Makefile.am b/tests/Makefile.am index c2d4d1dc5d35..068725326b75 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -50,6 +50,7 @@ runtestkmiwhitelist \ runtestlookupsyms \ runtestreadwrite \ runtestsymtab \ +runtestsymtabreader \ runtesttoolsutils \ $(FEDABIPKGDIFF_TEST) \ $(ZIP_ARCHIVE_TESTS) \ @@ -158,6 +159,9 @@ runtestcxxcompat_LDADD = libcatch.la $(top_builddir)/src/libabigail.la runtestsymtab_SOURCES = test-symtab.cc runtestsymtab_LDADD = libtestutils.la libcatch.la $(top_builddir)/src/libabigail.la +runtestsymtabreader_SOURCES = test-symtab-reader.cc +runtestsymtabreader_LDADD = libcatch.la $(top_builddir)/src/libabigail.la + runtestsvg_SOURCES=test-svg.cc runtestsvg_LDADD=$(top_builddir)/src/libabigail.la diff --git a/tests/test-symtab-reader.cc b/tests/test-symtab-reader.cc new file mode 100644 index 000000000000..c2e30d661017 --- /dev/null +++ b/tests/test-symtab-reader.cc @@ -0,0 +1,30 @@ +// -*- Mode: C++ -*- +// +// Copyright (C) 2020 Google, Inc. +// +// This file is part of the GNU Application Binary Interface Generic +// Analysis and Instrumentation Library (libabigail). This library is +// free software; you can redistribute it and/or modify it under the +// terms of the GNU Lesser General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) any +// later version. + +// This library is distributed in the hope that it will be useful, but +// WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +// General Lesser Public License for more details. + +// You should have received a copy of the GNU Lesser General Public +// License along with this program; see the file COPYING-LGPLV3. If +// not, see . +// +// Author: Matthias Maennich + +/// @file +/// +/// This program tests libabigail's symtab reader. + +#include "lib/catch.hpp" + +#include "abg-symtab-reader.h" +