From patchwork Mon Jun 15 21:07:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 39635 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DCE53893651; Mon, 15 Jun 2020 21:07:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DCE53893651 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1592255272; bh=1MQ0ZiS1kdU2/J2flo0h9yn8nnwE7EsKWa99DbZ+Wv4=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=TAGnKtDbiz4PSh9h6g75qsZGwVuTLzNmJkwhds5PILDaxDbBgJghgkfNgV6e2G1Mr slTmKOfc1zIK4wj4rWuH9/Bw5Ywb/lPJ2KFfRYftSnrZ37pYpJ6E+vzP2jTJCTnnsg 7hHah28QhPRR2sXXfBbioEU/SeY8V02LHnmfdCyk= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id 5C4D53893646 for ; Mon, 15 Jun 2020 21:07:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C4D53893646 Received: by mail-yb1-xb4a.google.com with SMTP id j3so3142038yba.14 for ; Mon, 15 Jun 2020 14:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=1MQ0ZiS1kdU2/J2flo0h9yn8nnwE7EsKWa99DbZ+Wv4=; b=b1ocZPQNRhrgl20wkxd0/XSgAVTSnjY2yuQRfKHLf045Q+wK++CJMd+Perse1wBCkG 7qbHXuRLw50lIyUfJM0ks+UybV/4gHt4/2aXGw0FIad1WkGn5tTYDAl1Wp68UNOr0sE/ iWul1mbMQZJ38mrMgb01CF+z0dHn8l+Tcj4jO+Xcm2x9h5jgB5ZJIorxdzGUpFP/2FBQ P2rOIYaBc3fpj38uHpEmbSIGmxfSbzaAKvXgPnzpga9m562NjtjYqvuCnbih8qqx4nNF ke6wgG2DzHh4OunN9tsCHDFEfo0+qMBzPi9rOFslsCYV/s/ZzRo6YRDbnFcNQhEL3olL yp2A== X-Gm-Message-State: AOAM532taNqC1sVQmsxHJO4Edqxj+9etDxPmHc95J3YASIKchr0E7yAQ pYjC+gILQXPCI1RAyOUv2yL+WjPoEt9el/wqilRtnWRSJP5yS5hLCLkqO5xnwA5MpwtINV6Z30h 6O/ejGcgy5DMC/T05i4faZjEzTQa458h4rJEMIDnus8sMINPprRsUdiiA6b/qGkjDLJN+TIw= X-Google-Smtp-Source: ABdhPJy9Fo2dr90o+k3eoPWmj6JjLrOtakobuFtk0gMNDPJLAxAO81rbKP/TrHRiP2jImcp3llJVDM9eIS42iw== X-Received: by 2002:a25:848f:: with SMTP id v15mr49502325ybk.473.1592255268812; Mon, 15 Jun 2020 14:07:48 -0700 (PDT) Date: Mon, 15 Jun 2020 22:07:40 +0100 In-Reply-To: <20200612095917.2146-2-gprocida@google.com> Message-Id: <20200615210741.92897-1-gprocida@google.com> Mime-Version: 1.0 References: <20200612095917.2146-2-gprocida@google.com> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog Subject: [PATCH v2 0/1] Stable type ids To: libabigail@sourceware.org X-Spam-Status: No, score=-18.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com, mark@klomp.org, gprocida@google.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" This is a follow-up addressing review comments. * enum type_id_style_kind now has a doc comment. * COUNTER is now SEQUENCE (and counter is now sequence). * The enumerators are now suffixed with _TYPE_ID_STYLE. * stable_hash is now fnv_hash and lives in abg-hash.{h,cc}. (though it has a very different purpose from the other things there) * std::unordered_set is now unordered_set. * The two patches are now folded into a single patch. Regards, Giuliano. Giuliano Procida (1): abg-writer: Add support for stable hash type ids. doc/manuals/abidw.rst | 15 +- include/abg-hash.h | 5 + include/abg-writer.h | 11 ++ src/abg-hash.cc | 30 ++++ src/abg-writer.cc | 63 ++++++++- tests/data/Makefile.am | 9 ++ tests/data/test-read-dwarf/test0.hash.abi | 70 ++++++++++ tests/data/test-read-dwarf/test1.hash.abi | 129 ++++++++++++++++++ tests/data/test-read-dwarf/test2.so.hash.abi | 79 +++++++++++ tests/data/test-read-dwarf/test3.so.hash.abi | 19 +++ tests/data/test-read-dwarf/test4.so.hash.abi | 23 ++++ tests/data/test-read-dwarf/test5.o.hash.abi | 13 ++ tests/data/test-read-dwarf/test6.so.hash.abi | 42 ++++++ tests/data/test-read-dwarf/test7.so.hash.abi | 77 +++++++++++ .../test8-qualified-this-pointer.so.hash.abi | 37 +++++ tests/test-read-dwarf.cc | 107 ++++++++++++++- tools/abidw.cc | 20 ++- 17 files changed, 732 insertions(+), 17 deletions(-) create mode 100644 tests/data/test-read-dwarf/test0.hash.abi create mode 100644 tests/data/test-read-dwarf/test1.hash.abi create mode 100644 tests/data/test-read-dwarf/test2.so.hash.abi create mode 100644 tests/data/test-read-dwarf/test3.so.hash.abi create mode 100644 tests/data/test-read-dwarf/test4.so.hash.abi create mode 100644 tests/data/test-read-dwarf/test5.o.hash.abi create mode 100644 tests/data/test-read-dwarf/test6.so.hash.abi create mode 100644 tests/data/test-read-dwarf/test7.so.hash.abi create mode 100644 tests/data/test-read-dwarf/test8-qualified-this-pointer.so.hash.abi