diff mbox

[1/1] gnu: twolame: Fix test failure with Perl 5.24.

Message ID e1fb064d16a3f1faf972327998b3b7fbde10a58b.1477288413.git.leo@famulari.name
State New
Headers show

Commit Message

Leo Famulari Oct. 24, 2016, 5:53 a.m. UTC
* gnu/packages/audio.scm (twolame)[source]: Add snippet to fix test.
---
 gnu/packages/audio.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Hartmut Goebel Oct. 24, 2016, 7:46 a.m. UTC | #1
Am 24.10.2016 um 07:53 schrieb Leo Famulari:
> +       ;; The tests break with Perl 5.24:
> +       ;; https://github.com/njh/twolame/issues/21
> +       (snippet
> +        '(begin
> +           (substitute* "tests/test.pl" (("\\(@_\\)") "($_[0])"))
> +           #t))))

I'm curious: Are we really removing the tests from the sources "just"
because they are failing?
Leo Famulari Oct. 24, 2016, 8:21 p.m. UTC | #2
On Mon, Oct 24, 2016 at 01:53:36AM -0400, Leo Famulari wrote:
> * gnu/packages/audio.scm (twolame)[source]: Add snippet to fix test.

The fix was merged upstream...

https://github.com/njh/twolame/commit/eba1e286f10e5ce15a08bd9fd556779ce9cce98b

... so I pushed this patch to core-updates.
diff mbox

Patch

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index db32b6f..5a2cf09 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2134,7 +2134,14 @@  conversion.  It may be used, for example, to resample PCM-encoded audio.")
        (uri (string-append "mirror://sourceforge/twolame/twolame/" version
                            "/twolame-" version ".tar.gz"))
        (sha256
-        (base32 "0ahiqqng5pidwhj1wzph4vxxgxxgcfa3gl0gywipzx2ii7s35wwq"))))
+        (base32 "0ahiqqng5pidwhj1wzph4vxxgxxgcfa3gl0gywipzx2ii7s35wwq"))
+       (modules '((guix build utils)))
+       ;; The tests break with Perl 5.24:
+       ;; https://github.com/njh/twolame/issues/21
+       (snippet
+        '(begin
+           (substitute* "tests/test.pl" (("\\(@_\\)") "($_[0])"))
+           #t))))
     (build-system gnu-build-system)
     (inputs
      `(("libsndfile" ,libsndfile)))