diff mbox

Add bwm-ng.

Message ID cuba8g2t1ef.fsf@systemreboot.net
State New
Headers show

Commit Message

Arun Aug. 24, 2016, 7:25 p.m. UTC
Please find attached patch to add new package 'bwm-ng' to (gnu packages
admin).

Regards,
Arun Isaac

Comments

non such Aug. 27, 2016, 12:06 p.m. UTC | #1
Hi Arun,

thanks for your contribution.

Arun <arunisaac@systemreboot.net> writes:

> [ Unknown signature status ]
>
> Please find attached patch to add new package 'bwm-ng' to (gnu packages
> admin).
>
> Regards,
> Arun Isaac
>
> From 2a88508183f9b8005c2a0694992f1b3ae4208049 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Wed, 24 Aug 2016 23:49:46 +0530
> Subject: [PATCH] gnu: Add bwm-ng.
> To: guix-devel@gnu.org
>
> * gnu/packages/admin.scm (bwm-ng): New variable.
> ---
>  gnu/packages/admin.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 3ba5947..d3da2d8 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1767,3 +1767,21 @@ the status of your battery in the system tray.")
>  shortcut syntax and completion options.")
>        (home-page "https://github.com/TrilbyWhite/interrobang")
>        (license license:gpl3+))))
> +
> +(define-public bwm-ng
> +  (package
> +    (name "bwm-ng")
> +    (version "0.6.1")
> +    (source
> +     (origin
> +       (method url-fetch)

The package is good and well written. Whoever commits it, can make the
stylistic adjustments. I can not commit, but I can tell you that your
package builds here and that the section below will be corrected to

> +       (uri (string-append "https://www.gropp.org/bwm-ng/bwm-ng-" version ".tar.gz"))
> +       (sha256 (base32 "1w0dwpjjm9pqi613i8glxrgca3rdyqyp3xydzagzr5ndc34z6z02"))))

(uri
  (string-append "https://www.gropp.org/bwm-ng/"
                 name "-" version ".tar.gz"))
(sha256
  (base32
    "1w0dwpjjm9pqi613i8glxrgca3rdyqyp3xydzagzr5ndc34z6z02"))))

Or something similar to this. These are just minor details, so don't
worry about them now, same goes for:

> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses" ,ncurses)))

(inputs
  `(("ncurses" ,ncurses)))

which would be my choice, but a simple one line works too.

> +    (synopsis "Console based live network and disk I/O bandwidth monitor")
> +    (description "Bandwidth Monitor NG is a small and simple
> +console based live network and disk I/O bandwidth monitor for Linux,
> +BSD, Solaris, Mac OS X and others.")
> +    (home-page "https://www.gropp.org/?id=projects&sub=bwm-ng")
> +    (license license:gpl2)))
> -- 
> 2.9.3
>

For a first(?) package this is very good.
Other than these changes, which the person commiting your patch can
apply on your behalf, it looks good to me!
Arun Aug. 27, 2016, 5:16 p.m. UTC | #2
> For a first(?) package this is very good.
> Other than these changes, which the person commiting your patch can
> apply on your behalf, it looks good to me!

Yes, this is my first package. Thank you! :-)
Ricardo Wurmus Aug. 27, 2016, 7:42 p.m. UTC | #3
Hi Arun,

> Please find attached patch to add new package 'bwm-ng' to (gnu packages
> admin).

thanks for the patch.  I’ve made a couple of cosmetic changes and
removed the list of supported operating systems from the description.  I
also moved it from admin.scm to networking.scm where we already have a
couple of network monitoring packages.

I’d like to add a copyright line to the header, like this:

    ;;; Coypright © 2016 Arun Isaac <arunisaac@systemreboot.net>

Is this okay or would you like some other email address to be listed
there?  Once I get your okay I’ll push the commit to master.

Thanks again!

~~ Ricardo
Arun Aug. 28, 2016, 12:19 a.m. UTC | #4
> thanks for the patch.  I’ve made a couple of cosmetic changes and
> removed the list of supported operating systems from the description.  I
> also moved it from admin.scm to networking.scm where we already have a
> couple of network monitoring packages.

Sure.

> I’d like to add a copyright line to the header, like this:
>
>     ;;; Coypright © 2016 Arun Isaac <arunisaac@systemreboot.net>
>
> Is this okay or would you like some other email address to be listed
> there?  Once I get your okay I’ll push the commit to master.

Yeah, this is fine. Thank you!
Ricardo Wurmus Aug. 28, 2016, 7:50 a.m. UTC | #5
Arun Isaac <arunisaac@systemreboot.net> writes:

>> thanks for the patch.  I’ve made a couple of cosmetic changes and
>> removed the list of supported operating systems from the description.  I
>> also moved it from admin.scm to networking.scm where we already have a
>> couple of network monitoring packages.
>
> Sure.
>
>> I’d like to add a copyright line to the header, like this:
>>
>>     ;;; Coypright © 2016 Arun Isaac <arunisaac@systemreboot.net>
>>
>> Is this okay or would you like some other email address to be listed
>> there?  Once I get your okay I’ll push the commit to master.
>
> Yeah, this is fine. Thank you!

Okay.  I’ve pushed this to master as
be9f3a83319ac8936654aa44d4fa55a5336fb62e.

Thanks again and welcome :)

~~ Ricardo
diff mbox

Patch

From 2a88508183f9b8005c2a0694992f1b3ae4208049 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Wed, 24 Aug 2016 23:49:46 +0530
Subject: [PATCH] gnu: Add bwm-ng.
To: guix-devel@gnu.org

* gnu/packages/admin.scm (bwm-ng): New variable.
---
 gnu/packages/admin.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 3ba5947..d3da2d8 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1767,3 +1767,21 @@  the status of your battery in the system tray.")
 shortcut syntax and completion options.")
       (home-page "https://github.com/TrilbyWhite/interrobang")
       (license license:gpl3+))))
+
+(define-public bwm-ng
+  (package
+    (name "bwm-ng")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://www.gropp.org/bwm-ng/bwm-ng-" version ".tar.gz"))
+       (sha256 (base32 "1w0dwpjjm9pqi613i8glxrgca3rdyqyp3xydzagzr5ndc34z6z02"))))
+    (build-system gnu-build-system)
+    (inputs `(("ncurses" ,ncurses)))
+    (synopsis "Console based live network and disk I/O bandwidth monitor")
+    (description "Bandwidth Monitor NG is a small and simple
+console based live network and disk I/O bandwidth monitor for Linux,
+BSD, Solaris, Mac OS X and others.")
+    (home-page "https://www.gropp.org/?id=projects&sub=bwm-ng")
+    (license license:gpl2)))
-- 
2.9.3