diff mbox

gnu: gzochi: Update to 0.10.

Message ID CANdC_RCySiJqvvNcNKufpMU2xeMQHtKCh1XTLKJGWqukWNFBrA@mail.gmail.com
State New
Headers show

Commit Message

Julian Graham Aug. 21, 2016, 3:20 p.m. UTC
Linted, built, inspected by hand. Let me know if I've missed anything.

Comments

Andreas Enge Aug. 21, 2016, 4:21 p.m. UTC | #1
Hello,

thanks for your contribution!

On Sun, Aug 21, 2016 at 11:20:54AM -0400, Julian Graham wrote:
> -              ("gmp" ,gmp)

Could you comment on this? Is it not needed any more? Or does dropping it
removes an optional feature?

Andreas
David Craven Aug. 21, 2016, 5 p.m. UTC | #2
Isn't gmp already an implicit input of the gnu-build-system? It still
ends up in the runpath, it's just not required to be an input.
Julian Graham Aug. 21, 2016, 9:06 p.m. UTC | #3
Hi Andreas,

On Sun, Aug 21, 2016 at 12:21 PM, Andreas Enge <andreas@enge.fr> wrote:
> Could you comment on this? Is it not needed any more? Or does dropping it
> removes an optional feature?

It's not needed as a first-order dependency any more - although as
David Craven notes in a separate email, it's a dependency of several
other core parts of Guix (such as Guile).


Regards,
Julian
David Craven Aug. 21, 2016, 9:20 p.m. UTC | #4
Hi Julian,

I hadn't realized that you are the author of gzochi.

What I meant was that gmp end up being referenced by gzochi even dough
it's not explicitly in the inputs field. Are you saying that this
shouldn't be the case then?

guix gc --references $(guix build gzochi)
/gnu/store/00qwdmjrzflh0q4g9n18wcx8nvhhxcj1-bdb-6.2.23
/gnu/store/1c7rrngfbrfspfvwj7vvasvmc1cjqjlh-libltdl-2.4.6
/gnu/store/1qv5i6rfxjc4d0rg7z6r9dapmf85kzmy-gnutls-3.5.2
/gnu/store/2z0lv1px7izrmzxsqi3555yavqa56mkq-libidn-1.32
/gnu/store/3fhnmvbdxlsh64pr3zg4y74x3hlx33qw-libtasn1-4.8
/gnu/store/5992iq1v7arqa14ym3di58n4la0893nv-zlib-1.2.8
/gnu/store/5n16jhjpw494jrq87va51wqsmgaqm0yb-sdl-1.2.15
/gnu/store/7zhj5adf7kq7pr6j46wj1gjdc8vi0mwk-nettle-3.2
/gnu/store/95x5fxvcggyaa8ymjjgv5q0dnzkrign9-guile-2.0.11
/gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib
/gnu/store/b8i9qnxwd4lsxk0g09xnkgshfn4arpmz-libmicrohttpd-0.9.50
>> /gnu/store/cdkrfbl10kbyyjjw3yfk9hckfw8n1b7g-gmp-6.1.0
/gnu/store/i9yr2vg3ksp7iyvvinwv9js82rgv4l04-libunistring-0.9.6
/gnu/store/l1s4cw9g58hmcpd2qgbckfl228143qzx-glib-2.48.0
/gnu/store/lv1jqm6cd9l265jwnihd48a5n7qxzg4d-libgcrypt-1.7.0
/gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23
/gnu/store/sncfamh3fjrrdgd950d79g6yml2s6a07-libffi-3.2.1
/gnu/store/wdsqcvk2wrr83w4lyr4acpgscn07w6hy-libgpg-error-1.22
/gnu/store/x09wbcsh8wjc5y9yhc9mwf2a9gjnc0hv-libgc-7.4.2
/gnu/store/xl19qrfzga52vrvp4ncccwjlnrjqwj95-ncurses-6.0
/gnu/store/z4d6bwpzr05ga4mih3nza8k3jal37b5a-gzochi-0.10
/gnu/store/zwc6ck9j0wv80kz5snw5acwb39ws88m1-pcre-8.38
Julian Graham Aug. 21, 2016, 9:28 p.m. UTC | #5
Hi David,

On Sun, Aug 21, 2016 at 5:20 PM, David Craven <david@craven.ch> wrote:
> I hadn't realized that you are the author of gzochi.

Yep!


> What I meant was that gmp end up being referenced by gzochi even dough
> it's not explicitly in the inputs field. Are you saying that this
> shouldn't be the case then?

No, I think that's fine. I'm not an expert with Guix, but I assume the
inclusion of GMP happens transitively - gzochi depends on Guile, Guile
depends on GMP.
David Craven Aug. 21, 2016, 11:52 p.m. UTC | #6
Pushed as c8edd7e65fec92f3656cfdc4332a76a5b78e46af
Mark H Weaver Aug. 22, 2016, 4:24 a.m. UTC | #7
Hi Julian,

Julian Graham <joolean@gmail.com> writes:
> Linted, built, inspected by hand. Let me know if I've missed anything.
>
> From 584a3d62fe7105b90df433e460d0b6232716b1fc Mon Sep 17 00:00:00 2001
> From: Julian Graham <joolean@gmail.com>
> Date: Sun, 21 Aug 2016 11:10:41 -0400
> Subject: [PATCH] gnu: gzochi: Update to 0.10.
>
> * gnu/packages/game-development.scm (gzochi): Update to 0.10.

This update seems to have broken gzochi on i686 and armhf.  Segfaults
and aborts occur during the test suite.

  https://hydra.gnu.org/eval/109095?filter=gzochi

  https://hydra.gnu.org/build/1444785  (i686)
  https://hydra.gnu.org/build/1444781  (armhf)

Build logs are available from those pages.  As I write this, our
continuous integration system has not yet attempted the build on
mips64el, but when it does the results will be available here:

  https://hydra.gnu.org/build/1444727  (mips64el)

Any idea what's going wrong here?

     Thanks,
       Mark
Julian Graham Aug. 22, 2016, 12:59 p.m. UTC | #8
Hi Mark,

On Mon, Aug 22, 2016 at 12:24 AM, Mark H Weaver <mhw@netris.org> wrote:
> This update seems to have broken gzochi on i686 and armhf.  Segfaults
> and aborts occur during the test suite.

Oh dear, that's embarrassing.


>   https://hydra.gnu.org/build/1444785  (i686)
>   https://hydra.gnu.org/build/1444781  (armhf)
>
> Build logs are available from those pages.  As I write this, our
> continuous integration system has not yet attempted the build on
> mips64el, but when it does the results will be available here:
>
>   https://hydra.gnu.org/build/1444727  (mips64el)
>
> Any idea what's going wrong here?

It's almost certainly some sloppy handling of 64-bit types on 32-bit
platforms. (The mips64el build succeeded.)

Sorry for the inconvenience! What are my options for addressing this?
It may take me a few days to get this patched.
Mark H Weaver Aug. 23, 2016, 5:20 a.m. UTC | #9
Julian Graham <joolean@gmail.com> writes:

> Hi Mark,
>
> On Mon, Aug 22, 2016 at 12:24 AM, Mark H Weaver <mhw@netris.org> wrote:
>> This update seems to have broken gzochi on i686 and armhf.  Segfaults
>> and aborts occur during the test suite.
>
> Oh dear, that's embarrassing.
>
>
>>   https://hydra.gnu.org/build/1444785  (i686)
>>   https://hydra.gnu.org/build/1444781  (armhf)
>>
>> Build logs are available from those pages.  As I write this, our
>> continuous integration system has not yet attempted the build on
>> mips64el, but when it does the results will be available here:
>>
>>   https://hydra.gnu.org/build/1444727  (mips64el)
>>
>> Any idea what's going wrong here?
>
> It's almost certainly some sloppy handling of 64-bit types on 32-bit
> platforms. (The mips64el build succeeded.)
>
> Sorry for the inconvenience!

No worries, bugs happen.

> What are my options for addressing this?
> It may take me a few days to get this patched.

If you have 'guix' installed, you can run:

  guix build --system=i686-linux --keep-failed gzochi

to reproduce the same build on your machine, and to leave the failed
build directory in /tmp/guix-build-* for further investigation.

Another approach is to run:

  guix environment --pure --system=i686-linux gzochi

to spawn a subshell with environment variables set to mostly reproduce
the build environment used in the "guix build" command above, but
outside of the isolated build container.  If you can reproduce the
problem this way, it should be far more convenient for debugging and for
development of a fix.

If you can fix the problem on i686, please let me know and I'd be glad
to test the same fix on armhf.

What do you think?

      Mark
Julian Graham Aug. 23, 2016, 3:11 p.m. UTC | #10
On Tue, Aug 23, 2016 at 1:20 AM, Mark H Weaver <mhw@netris.org> wrote:
> If you have 'guix' installed, you can run:
>
>   guix build --system=i686-linux --keep-failed gzochi
>
> to reproduce the same build on your machine, and to leave the failed
> build directory in /tmp/guix-build-* for further investigation.

Neat! I'll give that a shot.


> If you can fix the problem on i686, please let me know and I'd be glad
> to test the same fix on armhf.
>
> What do you think?

Will do. From a Guix perspective, what's better: A new gzochi release
or a patch for Guix to apply against the 0.10 release?
Mark H Weaver Aug. 23, 2016, 5:44 p.m. UTC | #11
Julian Graham <joolean@gmail.com> writes:

> On Tue, Aug 23, 2016 at 1:20 AM, Mark H Weaver <mhw@netris.org> wrote:
>> If you have 'guix' installed, you can run:
>>
>>   guix build --system=i686-linux --keep-failed gzochi
>>
>> to reproduce the same build on your machine, and to leave the failed
>> build directory in /tmp/guix-build-* for further investigation.
>
> Neat! I'll give that a shot.
>
>
>> If you can fix the problem on i686, please let me know and I'd be glad
>> to test the same fix on armhf.
>>
>> What do you think?
>
> Will do. From a Guix perspective, what's better: A new gzochi release
> or a patch for Guix to apply against the 0.10 release?

Either one would be fine for Guix users.  However, for the sake of
non-Guix users and other distros, I would suggest making a new release.
I think it's important that upstream software releases should be
reasonably portable whenever feasible, especially to important
architectures like i686 and armhf.  What do you think?

      Mark
diff mbox

Patch

From 584a3d62fe7105b90df433e460d0b6232716b1fc Mon Sep 17 00:00:00 2001
From: Julian Graham <joolean@gmail.com>
Date: Sun, 21 Aug 2016 11:10:41 -0400
Subject: [PATCH] gnu: gzochi: Update to 0.10.

* gnu/packages/game-development.scm (gzochi): Update to 0.10.
---
 gnu/packages/game-development.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 0bfd0c5..ba97a64 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1,13 +1,13 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014 Tomáš Čech <sleep_walker@suse.cz>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
-;;; Copyright © 2015 Julian Graham <joolean@gmail.com>
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2015, 2016 David Thompson <davet@gnu.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Julian Graham <joolean@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -93,14 +93,14 @@  is used in some video games and movies.")
 (define-public gzochi
   (package
     (name "gzochi")
-    (version "0.9")
+    (version "0.10")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://savannah/gzochi/gzochi-"
                                   version ".tar.gz"))
               (sha256
                (base32
-                "1nf8naqbc4hmhy99b8n70yswg9j71nh5mfpwwh6d8pdw5mp9b46a"))))
+                "055m7ywgl48ljwxf0kjhl76ldck890y5afdwjhk5s3p65xyaxh0k"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases (modify-phases %standard-phases
@@ -116,7 +116,6 @@  is used in some video games and movies.")
     (native-inputs `(("pkgconfig" ,pkg-config)))
     (inputs `(("bdb" ,bdb)
               ("glib" ,glib)
-              ("gmp" ,gmp)
               ("guile" ,guile-2.0)
               ("libmicrohttpd" ,libmicrohttpd)
               ("ncurses" ,ncurses)
-- 
2.5.0