Add libiax

Hi Guix,

Attached is a patch for LibIAX, a library that is used by the Ring
(formerly SFLphone).

Upstream seems to use no version numbers.  I used the git commit ID that
is also refered to in the version that is bundeled with Ring.  This is
also the latest commit to libiax.

Thank you!

On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote:
> 
> Hi Guix,
> 
> Attached is a patch for LibIAX, a library that is used by the Ring
> (formerly SFLphone).

Cool!

> Upstream seems to use no version numbers.  I used the git commit ID that
> is also refered to in the version that is bundeled with Ring.  This is
> also the latest commit to libiax.

Since there are no upstream versions, I think the version string should
use 0.0.0 to refer to the upstream version, then the Guix package
revision number, and then the 7 characters of the commit.

So, it would end up like this: 0.0.0-1.cabba9e

See here:
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers

> +    (package
> +      (name "libiax")
> +      (version (string-append "2-" (string-take commit 7)))

By the way, what does the "2-" refer to?

On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote:
> +  #:use-module (gnu packages autotools)  
                                           ^
Also, there is some extra whitespace at the end of the line above.

> +         (uri
> +          (string-append
> +           "https://gitlab.savoirfairelinux.com/sflphone/libiax2/"
> +           "repository/archive.tar.gz?ref="
> +           commit))

Can you use (file-name ...) to make the file-name like
libiax-version.tar.gz?

Thank you for your review!

Leo Famulari <leo@famulari.name> writes:

> On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote:
>> 
>> Hi Guix,
>> 
>> Attached is a patch for LibIAX, a library that is used by the Ring
>> (formerly SFLphone).
>
> Cool!
>
>> Upstream seems to use no version numbers.  I used the git commit ID that
>> is also refered to in the version that is bundeled with Ring.  This is
>> also the latest commit to libiax.
>
> Since there are no upstream versions, I think the version string should
> use 0.0.0 to refer to the upstream version, then the Guix package
> revision number, and then the 7 characters of the commit.
>
> So, it would end up like this: 0.0.0-1.cabba9e
>
> See here:
> https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers

OK, Thank you for pointing this out!  I missed that in the manual.
I updated the patch accordingly and will send it soon.

>
>> +    (package
>> +      (name "libiax")
>> +      (version (string-append "2-" (string-take commit 7)))
>
> By the way, what does the "2-" refer to?

Upstream seems to refer to the software as "iax" "libiax" and "libiax2"
interchangeably.  The "2" was the closest thing I could find to a version
number.

Thank you!

Hello,

just a quick comment on the name:

On Mon, May 30, 2016 at 02:47:55PM -0500, Lukas Gradl wrote:
> Upstream seems to refer to the software as "iax" "libiax" and "libiax2"
> interchangeably.  The "2" was the closest thing I could find to a version
> number.

notice that the tarball name is always "correct" as the package name, unless
upstream consistently uses a different name. In this case:

+           "https://gitlab.savoirfairelinux.com/sflphone/libiax2/"
+           "repository/archive.tar.gz?ref="

I would suggest to use "libiax2" as the package name (variable name and
package NAME field), and the version number as proposed by Leo.

Andreas

On Tue, May 31, 2016 at 09:02:21PM +0200, Andreas Enge wrote:
> Hello,
> 
> just a quick comment on the name:
> 
> On Mon, May 30, 2016 at 02:47:55PM -0500, Lukas Gradl wrote:
> > Upstream seems to refer to the software as "iax" "libiax" and "libiax2"
> > interchangeably.  The "2" was the closest thing I could find to a version
> > number.
> 
> notice that the tarball name is always "correct" as the package name, unless
> upstream consistently uses a different name. In this case:
> 
> +           "https://gitlab.savoirfairelinux.com/sflphone/libiax2/"
> +           "repository/archive.tar.gz?ref="
> 
> I would suggest to use "libiax2" as the package name (variable name and
> package NAME field), and the version number as proposed by Leo.

Okay, so let's change the naming to libiax2, and give some more detail
about the licensing, as shown in my patch from earlier today. Then we
should be ready to merge :)