diff mbox

gnu: jq: Fix CVE-2015-8863.

Message ID 87shubtk6x.fsf@gmail.com
State New
Headers show

Commit Message

Jelle Licht Aug. 11, 2016, 3:11 p.m. UTC
Hello,

Attached patch backports the commit[0] for jq that fixed the vulnerability
referred to as CVE-2015-8863[1]. Some feedback would be welcome.

- Jelle
[0]: https://github.com/stedolan/jq/commit/8eb1367ca44e772963e704a700ef72ae2e12babd
[1]: https://access.redhat.com/security/cve/CVE-2015-8863

Comments

Leo Famulari Aug. 11, 2016, 7:44 p.m. UTC | #1
On Thu, Aug 11, 2016 at 05:11:02PM +0200, Jelle Licht wrote:
> Hello,
> 
> Attached patch backports the commit[0] for jq that fixed the vulnerability
> referred to as CVE-2015-8863[1]. Some feedback would be welcome.
> 
> - Jelle
> 
> * gnu/packages/patches/jq-CVE-2015-8863.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/web.scm (jq): Add it.

Thank you for paying attention to this! I added a comment to the patch
file with links to the MITRE page and to the source of the patch. I
think this having this information about the patch is helpful.

Pushed as f2b4c18cd96a69e375d7d9b5ad1c09f8fc065571.
diff mbox

Patch

From cbd181ae84003bf3cf4a2d15f44b5242dcc97860 Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Thu, 11 Aug 2016 17:02:41 +0200
Subject: [PATCH] gnu: jq: Fix CVE-2015-8863.
To: guix-devel@gnu.org

* gnu/packages/patches/jq-CVE-2015-8863.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/web.scm (jq): Add it.
---
 gnu/local.mk                                |  1 +
 gnu/packages/patches/jq-CVE-2015-8863.patch | 34 +++++++++++++++++++++++++++++
 gnu/packages/web.scm                        |  6 ++++-
 3 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/jq-CVE-2015-8863.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index af47311..44ace61 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -595,6 +595,7 @@  dist_patch_DATA =						\
   %D%/packages/patches/jasper-CVE-2016-2089.patch		\
   %D%/packages/patches/jasper-CVE-2016-2116.patch		\
   %D%/packages/patches/jbig2dec-ignore-testtest.patch		\
+  %D%/packages/patches/jq-CVE-2015-8863.patch			\
   %D%/packages/patches/khmer-use-libraries.patch                \
   %D%/packages/patches/kmod-module-directory.patch		\
   %D%/packages/patches/laby-make-install.patch			\
diff --git a/gnu/packages/patches/jq-CVE-2015-8863.patch b/gnu/packages/patches/jq-CVE-2015-8863.patch
new file mode 100644
index 0000000..b182626
--- /dev/null
+++ b/gnu/packages/patches/jq-CVE-2015-8863.patch
@@ -0,0 +1,34 @@ 
+From 8eb1367ca44e772963e704a700ef72ae2e12babd Mon Sep 17 00:00:00 2001
+From: Nicolas Williams <nico@cryptonector.com>
+Date: Sat, 24 Oct 2015 17:24:57 -0500
+Subject: [PATCH] Heap buffer overflow in tokenadd() (fix #105)
+
+This was an off-by one: the NUL terminator byte was not allocated on
+resize.  This was triggered by JSON-encoded numbers longer than 256
+bytes.
+---
+ jv_parse.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/jv_parse.c b/jv_parse.c
+index 3102ed4..84245b8 100644
+--- a/jv_parse.c
++++ b/jv_parse.c
+@@ -383,7 +383,7 @@ static pfunc stream_token(struct jv_parser* p, char ch) {
+ 
+ static void tokenadd(struct jv_parser* p, char c) {
+   assert(p->tokenpos <= p->tokenlen);
+-  if (p->tokenpos == p->tokenlen) {
++  if (p->tokenpos >= (p->tokenlen - 1)) {
+     p->tokenlen = p->tokenlen*2 + 256;
+     p->tokenbuf = jv_mem_realloc(p->tokenbuf, p->tokenlen);
+   }
+@@ -485,7 +485,7 @@ static pfunc check_literal(struct jv_parser* p) {
+     TRY(value(p, v));
+   } else {
+     // FIXME: better parser
+-    p->tokenbuf[p->tokenpos] = 0; // FIXME: invalid
++    p->tokenbuf[p->tokenpos] = 0;
+     char* end = 0;
+     double d = jvp_strtod(&p->dtoa, p->tokenbuf, &end);
+     if (end == 0 || *end != 0)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index fa791ff..9106295 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -3293,7 +3293,11 @@  It uses the uwsgi protocol for all the networking/interprocess communications.")
                                   "/" name "-" version ".tar.gz"))
               (sha256
                (base32
-                "0g29kyz4ykasdcrb0zmbrp2jqs9kv1wz9swx849i2d1ncknbzln4"))))
+                "0g29kyz4ykasdcrb0zmbrp2jqs9kv1wz9swx849i2d1ncknbzln4"))
+              ;; This patch has been pushed and the vulnerability will be
+              ;; fixed in the next release after 1.5.
+              ;; https://github.com/stedolan/jq/issues/995
+              (patches (search-patches "jq-CVE-2015-8863.patch"))))
     (inputs
      `(("oniguruma" ,oniguruma)))
     (native-inputs
-- 
2.9.2