diff mbox

[5/10] opendht: Propagate argon2.

Message ID 87ponrpp3n.fsf@openmailbox.org
State New
Headers show

Commit Message

Lukas Gradl Sept. 25, 2016, 10:54 p.m. UTC
Hello,

I noticed that some linker flags are set incorrectly.  The result was
that the output of
"objdump -p /gnu/store/...-opendht-0.6.1/lib/libopendht.so"
was missing a 'NEEDED' line for 'libargon2.so.0'.
The attached patch fixes that.

Thank you!

Best,
Lukas

Comments

Danny Milosavljevic Sept. 25, 2016, 11:24 p.m. UTC | #1
Hi Lukas,

On Sun, 25 Sep 2016 17:54:36 -0500
Lukas Gradl <lgradl@openmailbox.org> wrote:

> I noticed that some linker flags are set incorrectly.  The result was
> that the output of
> "objdump -p /gnu/store/...-opendht-0.6.1/lib/libopendht.so"
> was missing a 'NEEDED' line for 'libargon2.so.0'.
> The attached patch fixes that.

I'd also add a comment that the purpose of all that is to unbundle argon2 and then re-add the installed argon2 library.

Looks good to me.
diff mbox

Patch

From e7e0b00146f380f96c7ecb8d00ba3d00375d49f9 Mon Sep 17 00:00:00 2001
From: Lukas Gradl <lgradl@openmailbox.org>
Date: Tue, 9 Aug 2016 17:00:52 -0500
Subject: [PATCH 05/10] gnu: opendht: Propagate argon2.

* gnu/packages/crypto.scm (opendht)[source]: Add argon2 to pkg-config file.
[inputs]: Remove argon2.
[propagated-inputs]: Add argon2.
---
 gnu/packages/crypto.scm | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index ff5b0db..0c3e6c1 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -131,11 +131,20 @@  OpenBSD tool of the same name.")
            (delete-file-recursively "src/argon2")
            (substitute* "src/Makefile.am"
              (("./argon2/libargon2.la") "")
-             (("SUBDIRS = argon2") ""))
+             (("SUBDIRS = argon2") "")
+             (("libopendht_la_LDFLAGS = @LDFLAGS@")
+              "libopendht_la_LDFLAGS = @LDFLAGS@ @argon2_LIBS@"))
            (substitute* "src/crypto.cpp"
              (("argon2/argon2.h") "argon2.h"))
            (substitute* "configure.ac"
-             (("src/argon2/Makefile") ""))))
+             (("src/argon2/Makefile") "")
+             (("PKG_CHECK_MODULES..GNUTLS.. .gnutls .. 3.1..")
+              "PKG_CHECK_MODULES([GNUTLS], [gnutls >= 3.1])\n\
+PKG_CHECK_MODULES([argon2], [argon2 >= 1.0])"))
+           (substitute* "opendht.pc.in"
+             (("Libs: -L..libdir. -lopendht")
+              (string-append "Libs: -L${libdir} -lopendht\n"
+                             "Requires: argon2")))))
        (sha256
         (base32
          "09yvkmbqbym3b5md4n96qc1s9sf2n8ji404hagih45rmsj49599x"))))
@@ -144,8 +153,9 @@  OpenBSD tool of the same name.")
      `(("gnutls" ,gnutls)
        ("nettle" ,nettle)
        ("msgpack" ,msgpack)
-       ("readline" ,readline)
-       ("argon2" ,argon2)))
+       ("readline" ,readline)))
+    (propagated-inputs
+     `(("argon2" ,argon2)))
     (native-inputs
      `(("autoconf" ,autoconf)
        ("pkg-config" ,pkg-config)
-- 
2.9.0