diff mbox

Add thinkfan.

Message ID 87mvo2bvoh.fsf@saiph.selenimh
State New
Headers show

Commit Message

Nicolas Goaziou May 6, 2016, 11:42 p.m. UTC
Hello,

Leo Famulari <leo@famulari.name> writes:

> Looks good! But I noticed they *just* released a new version. Can you
> take a look and submit a patch with that version if it works for you?

Here it is.


Regards,

Comments

Leo Famulari May 7, 2016, 2:58 a.m. UTC | #1
On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote:
> Hello,
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > Looks good! But I noticed they *just* released a new version. Can you
> > take a look and submit a patch with that version if it works for you?
> 
> Here it is.

> * gnu/packages/linux.scm (thinkfan): New variable.

Thanks! Applied as d17ae8c0c30.
Nicolas Goaziou May 7, 2016, 9:47 a.m. UTC | #2
Hello,

Leo Famulari <leo@famulari.name> writes:

> On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote:
>> Hello,
>> 
>> Leo Famulari <leo@famulari.name> writes:
>> 
>> > Looks good! But I noticed they *just* released a new version. Can you
>> > take a look and submit a patch with that version if it works for you?
>> 
>> Here it is.
>
>> * gnu/packages/linux.scm (thinkfan): New variable.
>
> Thanks! Applied as d17ae8c0c30.

Thank you.

I realize there are hard-coded paths in init scripts. Would it make
sense to patch them so as to refer to `thinkfan' in store instead of
"/usr/sbin/thinkfan"?

Regards,
Ludovic Courtès May 9, 2016, 8:31 a.m. UTC | #3
Hi!

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote:
>>> Hello,
>>> 
>>> Leo Famulari <leo@famulari.name> writes:
>>> 
>>> > Looks good! But I noticed they *just* released a new version. Can you
>>> > take a look and submit a patch with that version if it works for you?
>>> 
>>> Here it is.
>>
>>> * gnu/packages/linux.scm (thinkfan): New variable.
>>
>> Thanks! Applied as d17ae8c0c30.
>
> Thank you.
>
> I realize there are hard-coded paths in init scripts. Would it make
> sense to patch them so as to refer to `thinkfan' in store instead of
> "/usr/sbin/thinkfan"?

Yes, I think so.

Ludo’.
diff mbox

Patch

From 9c82df26841b281fc9eeb751db76871e31c94339 Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sat, 30 Apr 2016 10:31:13 +0200
Subject: [PATCH] gnu: Add thinkfan.

* gnu/packages/linux.scm (thinkfan): New variable.
---
 gnu/packages/linux.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index e80c900..fcea499 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -11,6 +11,7 @@ 
 ;;; Copyright © 2016 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2016 Raymond Nicholson <rain1@openmailbox.org>
 ;;; Copyright © 2016 Mathieu Lirzin <mthl@gnu.org>
+;;; Copyright © 2016 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -63,6 +64,7 @@ 
   #:use-module (gnu packages readline)
   #:use-module (gnu packages calendar)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages freedesktop)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix utils)
@@ -2591,3 +2593,53 @@  where they are less likely to cause damage to the spinning disc.  Requires a
 drive that supports the ATA/ATAPI-7 IDLE IMMEDIATE command with unload
 feature, and a laptop with an accelerometer.  It has no effect on SSDs.")
     (license license:gpl2)))
+
+(define-public thinkfan
+  (package
+    (name "thinkfan")
+    (version "0.9.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/thinkfan/"
+                                  version "/thinkfan-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0nz4c48f0i0dljpk5y33c188dnnwg8gz82s4grfl8l64jr4n675n"))
+              (modules '((guix build utils)))
+              ;; Fix erroneous man page location in Makefile leading to
+              ;; a compilation failure.
+              (snippet
+               '(substitute* "CMakeLists.txt"
+                  (("thinkfan\\.1") "src/thinkfan.1")))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:modules ((guix build cmake-build-system)
+                  (guix build utils)
+                  (srfi srfi-26))
+       #:tests? #f                      ;no test target
+       #:configure-flags
+       ;; Enable reading temperatures from hard disks via S.M.A.R.T.
+       `("-DUSE_ATASMART:BOOL=ON")
+       #:phases
+       (modify-phases %standard-phases
+         ;; Install scripts for various foreign init systems.
+         (add-after 'install 'install-rc-scripts
+           (lambda* (#:key outputs #:allow-other-keys)
+             (for-each (cute install-file <>
+                             (string-append (assoc-ref outputs "out")
+                                            "/share/thinkfan"))
+                       (find-files (string-append "../thinkfan-" ,version
+                                                  "/rcscripts")
+                                   ".*"))
+             #t)))))
+    (inputs
+     `(("libatasmart" ,libatasmart)))
+    (home-page "http://thinkfan.sourceforge.net/")
+    (synopsis "Simple fan control program")
+    (description
+     "Thinkfan is a simple fan control program.  It reads temperatures,
+checks them against configured limits and switches to appropriate (also
+pre-configured) fan level.  It requires a working @code{thinkpad_acpi} or any
+other @code{hwmon} driver that enables temperature reading and fan control
+from userspace.")
+    (license license:gpl3+)))
-- 
2.7.4