diff mbox

gnu: femtolisp: Remove support for mips and armhf.

Message ID 87mvj0z4bu.fsf@we.make.ritual.n0.is
State New
Headers show

Commit Message

ng0 Sept. 22, 2016, 9:11 a.m. UTC 
Ludovic Courtès <ludo@gnu.org> writes:

> Andreas Enge <andreas@enge.fr> skribis:
>
>> femtolisp fails on mips and arm:
>>    http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
>> with the message
>> In file included from llt/llt.h:6:0,
>>                  from string.c:16:
>> llt/utils.h:27:4: error: #error "unknown architecture"
>>  #  error "unknown architecture"
>>
>> Should it be disabled there?
>
> Definitely.  It would be worth checking in that file the set of
> supported architectures, and putting them in ‘supported-platforms’.

I'm not exactly sure what's supported, I found win32, osx, freebsd,
openbsd, and that's it.

> Ludo’.
>

Comments

Ludovic Courtès Sept. 26, 2016, 10:38 a.m. UTC | #1 
ng0 <ngillmann@runbox.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Andreas Enge <andreas@enge.fr> skribis:
>>
>>> femtolisp fails on mips and arm:
>>>    http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
>>> with the message
>>> In file included from llt/llt.h:6:0,
>>>                  from string.c:16:
>>> llt/utils.h:27:4: error: #error "unknown architecture"
>>>  #  error "unknown architecture"
>>>
>>> Should it be disabled there?
>>
>> Definitely.  It would be worth checking in that file the set of
>> supported architectures, and putting them in ‘supported-platforms’.
>
> I'm not exactly sure what's supported, I found win32, osx, freebsd,
> openbsd, and that's it.

Sorry, I really meant supported architectures, which is what utils.h
seems to be about (although I don’t have the source here to check).
Could you check the #ifdefs in there?

> +      ;; armhf and mips64el fail to build, it has been reported upstream:
> +      ;; https://github.com/JeffBezanson/femtolisp/issues/25
> +      (supported-systems
> +       (and
> +        (delete "armhf-linux" %supported-systems)
> +        (delete "mips64el-linux" %supported-systems)
> +        #t))

‘supported-systems’ must be a list of strings, so:

  (fold delete %supported-systems
        '("armhf-linux" "mips64el-linux"))

Thanks,
Ludo’.
diff mbox

Patch

From 6761e9ae928b590ea18f525cf941e06094fc12d1 Mon Sep 17 00:00:00 2001
From: ng0 <ngillmann@runbox.com>
Date: Thu, 22 Sep 2016 09:08:03 +0000
Subject: [PATCH] gnu: femtolisp: Remove support for mips and armhf.

* gnu/packages/lisp.scm (femtolisp)[supported-systems]: New field,
remove support for mips64el and armhf.
---
 gnu/packages/lisp.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index d1180a7..1b72fe2 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -3,7 +3,7 @@ 
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Federico Beffa <beffa@fbengineering.ch>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 ng0 <ngillmann@runbox.com>
 ;;; Copyright © 2016 Andy Patterson <ajpatter@uwaterloo.ca>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -501,6 +501,13 @@  the InterLisp Standard.")
                 (sha256
                  (base32
                   "04rnwllxnl86zw8c6pwxznn49bvkvh0f1lfliy085vjzvlq3rgja"))))
+      ;; armhf and mips64el fail to build, it has been reported upstream:
+      ;; https://github.com/JeffBezanson/femtolisp/issues/25
+      (supported-systems
+       (and
+        (delete "armhf-linux" %supported-systems)
+        (delete "mips64el-linux" %supported-systems)
+        #t))
       (build-system gnu-build-system)
       (arguments
        `(#:make-flags '("CC=gcc" "release")
-- 
2.10.0