gnu: Add sicp.

Ludovic Courtès writes:

Hi Ludovic

> What about putting it in (gnu packages scheme) instead?  Sounds like a
> natural home.

Sure.

>> +    (version "2016-02-20")

> Could you change the ‘version’ field according to the conventions
> described at (info "(guix) Version Numbers")?  Since there’s no release
> number, it’s OK to use “20160220” (no hyphens) before the rest of the
> version field.

OK.

>> +    (arguments
>> +     `(#:modules ((guix build utils)
>> +                  (srfi srfi-1)
>> +                  (srfi srfi-26))
>> +                 #:builder
>
> #:builder should be aligned with #:modules.

Sure, missed this.  Edited by hand for now.
  
I've been fighting with this (i.e.: manually changing Emacs'
indentation, something that feels just so wrong), and wondering
about it.  Isn't .dir-locals.el supposed to handle this
automagically...what am I missing?

I'm used to run indent-region on the whole file, but that often changes
things in most files I ran it in.

Also, for Guix I had to remove delete-trailing-whitespace from my
before-save-variables, otherwise my patches try to delete lots of
whitespace...

>> +                 (let ((gzip (assoc-ref %build-inputs "gzip"))
>> +                       (source (assoc-ref %build-inputs "source"))
>> +                       (texinfo (assoc-ref %build-inputs "texinfo"))
>> +                       (info-dir (string-append %output "/share/info")))
>> +                   (use-modules (guix build utils)
>> +                                (srfi srfi-1)
>> +                                (srfi srfi-26))
>
> Please move ‘use-modules’ to the top:
>
>   (begin
>     (use-modules (srfi …) …)
>
>     (let (…) …))

OK.

>> +                   (and
>> +                    (system* "makeinfo"
>> +                             "--output" (string-append info-dir "/sicp.info")
>> +                             (string-append source "/sicp-pocket.texi"))
>
> (zero? (system* …))

Yes, better.

>> +It was first published in 1985 by MIT Press and written by Massachusetts
>> +Institute of Technology (MIT) professors Harold Abelson and Gerald Jay
>> +Sussman, with Julie Sussman.")
>
> I would remove the last paragraph.

Done.

> Thanks for filling this gap!  :-)

:-)

Greetings,
Jan

Jan Nieuwenhuizen <janneke@gnu.org> writes:

>>> +    (arguments
>>> +     `(#:modules ((guix build utils)
>>> +                  (srfi srfi-1)
>>> +                  (srfi srfi-26))
>>> +                 #:builder
>>
>> #:builder should be aligned with #:modules.
>
> Sure, missed this.  Edited by hand for now.
>   
> I've been fighting with this (i.e.: manually changing Emacs'
> indentation, something that feels just so wrong), and wondering
> about it.  Isn't .dir-locals.el supposed to handle this
> automagically...what am I missing?
>
> I'm used to run indent-region on the whole file, but that often changes
> things in most files I ran it in.

This modified `scheme-indent-function' by Mark Weaver fixes that:
Taylan

Taylan Ulrich "Bayırlı/Kammer" writes:

> This modified `scheme-indent-function' by Mark Weaver fixes that:

Wow, that helps :-) Thank you!

I can't seem to find it in Guix git; should I look better or should we
link to it somehow?

Jan

Jan Nieuwenhuizen (2016-05-20 14:26 +0300) wrote:

> Taylan Ulrich "Bayırlı/Kammer" writes:
>
>> This modified `scheme-indent-function' by Mark Weaver fixes that:
>
> Wow, that helps :-) Thank you!
>
> I can't seem to find it in Guix git; should I look better or should we
> link to it somehow?

The source is here:
<http://www.netris.org/~mhw/scheme-indent-function.el>.

This is a usual problem (I would say an Emacs bug) that people face
with, and those who know about it, use the mentioned modified version
'scheme-indent-function'.

So what about patching our emacs package to fix scheme-indent-function?
I can make a patch if it's reasonable.

Alex Kost <alezost@gmail.com> skribis:

> Jan Nieuwenhuizen (2016-05-20 14:26 +0300) wrote:
>
>> Taylan Ulrich "Bayırlı/Kammer" writes:
>>
>>> This modified `scheme-indent-function' by Mark Weaver fixes that:
>>
>> Wow, that helps :-) Thank you!
>>
>> I can't seem to find it in Guix git; should I look better or should we
>> link to it somehow?
>
> The source is here:
> <http://www.netris.org/~mhw/scheme-indent-function.el>.
>
> This is a usual problem (I would say an Emacs bug) that people face
> with, and those who know about it, use the mentioned modified version
> 'scheme-indent-function'.
>
> So what about patching our emacs package to fix scheme-indent-function?
> I can make a patch if it's reasonable.

I think we should submit it to bug-emacs@gnu.org first.  Thoughts?

Ludo’.

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> From 44bcbdb30f6789d4bc460aa84dca27321c074cba Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Thu, 19 May 2016 23:50:09 +0200
> Subject: [PATCH] gnu: Add sicp.
>
> * gnu/packages/scheme.scm (sicp): New variable.

Applied with minor changes:

> +    (version "20160220-1.5b52db56")

Avoided the duplicated commit ID here following the manual (info "(guix)
Version Numbers").

> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/sarabander/sicp")
> +             (commit "5b52db566968d28a89fbbaf338d207f01cc81cac")))
> +       (sha256
> +        (base32
> +         "10h6h7szwlfbshwh18bnl2hvyddj5i7106l79s145l0sjjv15cxb"))))

Added a ‘file-name’ field, as noted by ‘guix lint’.

> +           (every zero? (map
> +                         (cut system* "gzip" <>)

Pass ‘-9n’, where ‘-n’ allows the thing to be bit-reproducible (see
--rounds=2).

Thanks!

Ludo’.

Ludovic Courtès (2016-05-22 00:03 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Jan Nieuwenhuizen (2016-05-20 14:26 +0300) wrote:
>>
>>> Taylan Ulrich "Bayırlı/Kammer" writes:
>>>
>>>> This modified `scheme-indent-function' by Mark Weaver fixes that:
>>>
>>> Wow, that helps :-) Thank you!
>>>
>>> I can't seem to find it in Guix git; should I look better or should we
>>> link to it somehow?
>>
>> The source is here:
>> <http://www.netris.org/~mhw/scheme-indent-function.el>.
>>
>> This is a usual problem (I would say an Emacs bug) that people face
>> with, and those who know about it, use the mentioned modified version
>> 'scheme-indent-function'.
>>
>> So what about patching our emacs package to fix scheme-indent-function?
>> I can make a patch if it's reasonable.
>
> I think we should submit it to bug-emacs@gnu.org first.  Thoughts?

I also think so.  IIUC it's Mark and you who found this bug and came up
with this fix, so I hope one of you will submit it :-)

But as it may take a long time until this fix will go to emacs, I think
it would be good to patch our emacs package now.

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Courtès (2016-05-22 00:03 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:

[...]

>>> The source is here:
>>> <http://www.netris.org/~mhw/scheme-indent-function.el>.
>>>
>>> This is a usual problem (I would say an Emacs bug) that people face
>>> with, and those who know about it, use the mentioned modified version
>>> 'scheme-indent-function'.
>>>
>>> So what about patching our emacs package to fix scheme-indent-function?
>>> I can make a patch if it's reasonable.
>>
>> I think we should submit it to bug-emacs@gnu.org first.  Thoughts?
>
> I also think so.  IIUC it's Mark and you who found this bug and came up
> with this fix, so I hope one of you will submit it :-)

Aha, well done!  Mark?  :-)

> But as it may take a long time until this fix will go to emacs, I think
> it would be good to patch our emacs package now.

Okay, let’s make an exception for this one.  Would you like to take care
of it?

Thanks,
Ludo’.