diff mbox

ruby-debug-inspector

Message ID 87k2iax8hj.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me
State New
Headers show

Commit Message

Matthew Jordan May 31, 2016, 8:44 p.m. UTC
Updated patch with the suggested changes.

Comments

Efraim Flashner June 1, 2016, 7:02 a.m. UTC | #1
On Tue, May 31, 2016 at 04:44:56PM -0400, Matthew Jordan wrote:
> 
> Updated patch with the suggested changes.
> 

> From 20f94a54c63023c3bf3d8d556385f520aaf09a3f Mon Sep 17 00:00:00 2001
> From: Matthew Jordan <matthewjordandevops@yandex.com>
> Date: Tue, 31 May 2016 07:26:24 -0400
> Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.
> 
> * gnu/local.mk: Modfied file.
this one -^ should be:
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/rails.scm: New file.
> ---
>  gnu/local.mk           |  1 +
>  gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
>  create mode 100644 gnu/packages/rails.scm
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 86b56d4..4c21827 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/qemu.scm				\
>    %D%/packages/qt.scm				\
>    %D%/packages/ragel.scm			\
> +  %D%/packages/rails.scm			\
>    %D%/packages/ratpoison.scm			\
>    %D%/packages/rc.scm				\
>    %D%/packages/rdesktop.scm			\
> diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
> new file mode 100644
> index 0000000..4612bb1
> --- /dev/null
> +++ b/gnu/packages/rails.scm
> @@ -0,0 +1,53 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +

it turns out you have a couple of extra modules here:

> +(define-module (gnu packages rails)
> +  #:use-module (guix licenses)
> +  #:use-module (gnu packages)
this one isn't needed -^
> +  #:use-module (guix download)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages python)
> +  #:use-module (gnu packages node)
these 3 either -^
> +  #:use-module (gnu packages ruby)
> +  #:use-module (gnu packages gcc)
or this one -^
> +  #:use-module (guix build-system ruby))
> +
> +(define-public ruby-debug-inspector
> +  (package
> +    (name "ruby-debug-inspector")
> +    (version "0.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "debug_inspector" version))
> +       (sha256
> +        (base32
> +         "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
> +    (inputs
> +     `(("ruby-bacon" ,ruby-bacon)))
> +    (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
> +    (description
> +     "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
> +API.")
> +    (home-page
> +     "https://github.com/banister/debug_inspector")
> +    (license expat)))
> -- 
> 2.8.3
> 

> 
> -- 
> Matthew Jordan
> Sent with my mu4e
> 

Here's the error from having the tests enabled:
starting phase `check'
bacon -Itest -rubygems -a -q
Usage: bacon [options] [files | -a] [-- untouched arguments]
rake aborted!
Command failed with status (1): [bacon -Itest -rubygems -a -q...]
/tmp/guix-build-ruby-debug-inspector-0.0.2.drv-0/gem/Rakefile:21:in
`block in <top (required)>'
Tasks: TOP => test
(See full trace by running task with --trace)

I'm not a ruby person so I don't really know what that means.

Other than the last few things it looks good to me. I'll push it with the
few edits later today unless someone with more ruby experience comes and
says I'm missing something :)
Ben Woodcroft June 1, 2016, 7:35 a.m. UTC | #2
Hi Matthew,

Thanks for the patch, all patches toward rails are much appreciated. I 
do have a few comments though.
>> * gnu/packages/rails.scm: New file.
I'm of the opinion that we should keep most ruby packages in 
gnu/packages/ruby.scm because to me "is this ruby package a rails 
package?" is not one with a straightforward answer. We already have 
activesupport in ruby.scm for instance, and that is more of a rails 
package than this I would argue.
>> +  #:use-module (guix build-system ruby))
>> +
>> +(define-public ruby-debug-inspector
>> +  (package
>> +    (name "ruby-debug-inspector")
>> +    (version "0.0.2")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (rubygems-uri "debug_inspector" version))
>> +       (sha256
>> +        (base32
>> +         "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
>> +    (build-system ruby-build-system)
>> +    (arguments
>> +     `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
Looking a bit closer at this it appears the test directory is missing 
from the gem but even the repository too. Maybe instead we add a cheap 
and cheerful test like this:

     (arguments
      `(#:phases
        (modify-phases %standard-phases
          (replace 'check
            (lambda _
              (zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))

WDYT?
>> +    (inputs
>> +     `(("ruby-bacon" ,ruby-bacon)))
bacon is not a dependency other than for testing, is that right? If so I 
don't think it is necessary.
>> +    (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
>> +    (description
>> +     "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
>> +API.")
>> +    (home-page
>> +     "https://github.com/banister/debug_inspector")
>> +    (license expat)))
Can you send an updated patch please? I'll look at your other patches 
soon too.

Thanks,
ben
diff mbox

Patch

From 20f94a54c63023c3bf3d8d556385f520aaf09a3f Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:26:24 -0400
Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.

* gnu/local.mk: Modfied file.
* gnu/packages/rails.scm: New file.
---
 gnu/local.mk           |  1 +
 gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 gnu/packages/rails.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 86b56d4..4c21827 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -285,6 +285,7 @@  GNU_SYSTEM_MODULES =				\
   %D%/packages/qemu.scm				\
   %D%/packages/qt.scm				\
   %D%/packages/ragel.scm			\
+  %D%/packages/rails.scm			\
   %D%/packages/ratpoison.scm			\
   %D%/packages/rc.scm				\
   %D%/packages/rdesktop.scm			\
diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
new file mode 100644
index 0000000..4612bb1
--- /dev/null
+++ b/gnu/packages/rails.scm
@@ -0,0 +1,53 @@ 
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rails)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages python)
+  #:use-module (gnu packages node)
+  #:use-module (gnu packages ruby)
+  #:use-module (gnu packages gcc)
+  #:use-module (guix build-system ruby))
+
+(define-public ruby-debug-inspector
+  (package
+    (name "ruby-debug-inspector")
+    (version "0.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "debug_inspector" version))
+       (sha256
+        (base32
+         "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
+    (inputs
+     `(("ruby-bacon" ,ruby-bacon)))
+    (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
+    (description
+     "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
+API.")
+    (home-page
+     "https://github.com/banister/debug_inspector")
+    (license expat)))
-- 
2.8.3