diff mbox

mailmanclient

Message ID 87intgaren.fsf@we.make.ritual.n0.is
State New
Headers show

Commit Message

ng0 Sept. 28, 2016, 5:02 p.m. UTC
A start for someone who wants to work on packaging mailman3, you need
this and afterwards django-mailman3, then comes hyperkitty, and
afterwards mailman3 itself I think.
Added python2 variant because mailman3 has some mixture in the
dependency chain going on.

Comments

ng0 Sept. 28, 2016, 5:11 p.m. UTC | #1
ng0 <ngillmann@runbox.com> writes:

> [ Unknown signature status ]
> A start for someone who wants to work on packaging mailman3, you need
> this and afterwards django-mailman3, then comes hyperkitty, and
> afterwards mailman3 itself I think.
> Added python2 variant because mailman3 has some mixture in the
> dependency chain going on.
>
> From bdcb5e7e77bd3e215016b3d9fde5094d618e64b9 Mon Sep 17 00:00:00 2001
> From: ng0 <ngillmann@runbox.com>
> Date: Wed, 28 Sep 2016 16:58:29 +0000
> Subject: [PATCH] gnu: Add python-mailmanclient.
>
> * gnu/packages/mail.scm (python-mailmanclient): New variable.
> ---
>  gnu/packages/mail.scm | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 09c15e2..41e564a 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -15,7 +15,7 @@
>  ;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
>  ;;; Copyright © 2016 Alex Kost <alezost@gmail.com>
>  ;;; Copyright © 2016 Troy Sankey <sankeytms@gmail.com>
> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016 ng0 <ngillmann@runbox.com>
>  ;;; Copyright © 2016 Clément Lassieur <clement@lassieur.org>
>  ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
>  ;;; Copyright © 2016 John Darrington <jmd@gnu.org>
> @@ -1493,3 +1493,33 @@ transfer protocols.")
>      (license (non-copyleft "file://LICENSE"
>                             "See LICENSE in the distribution."))))
>  
> +(define-public python-mailmanclient
> +  (package
> +    (name "python-mailmanclient")
> +    (version "1.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "mailmanclient" version))
> +       (sha256
> +        (base32
> +         "1cfjh45fgbsax5hjj2inq9nk33dhdvh63xhysc8dhnqidgqgm8c5"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; Requires mailman running
> +    (inputs
> +     `(("python-six" ,python-six)
> +       ("python-httplib2" ,python-httplib2)))
> +    (home-page "http://launchpad.net/mailman.client")
> +    (synopsis "Python bindings for the Mailman 3 REST API")
> +    (description
> +     "The mailmanclient library provides official Python bindings for
         ^___ Could the commiter remove this? Thanks.
> +the GNU Mailman 3 REST API.")
> +    (license lgpl3+)))
> +
> +(define-public python2-mailmanclient
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-mailmanclient))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools))))))
> -- 
> 2.10.0
>
> -- 
>               ng0
Leo Famulari Sept. 28, 2016, 5:14 p.m. UTC | #2
On Wed, Sep 28, 2016 at 05:02:56PM +0000, ng0 wrote:
> Subject: [PATCH] gnu: Add python-mailmanclient.
> 
> * gnu/packages/mail.scm (python-mailmanclient): New variable.

> +(define-public python2-mailmanclient
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-mailmanclient))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools))))))

This variant will not be used unless there is a python2-variant
properties field in python-mailman, like this:

(properties `((python2-variant . ,(delay python2-mailmanclient))))

You can see the recent commit "gnu: Add python-q. (e8c9b01090)" for an
example in context.
ng0 Sept. 28, 2016, 5:25 p.m. UTC | #3
Leo Famulari <leo@famulari.name> writes:

> [ Unknown signature status ]
> On Wed, Sep 28, 2016 at 05:02:56PM +0000, ng0 wrote:
>> Subject: [PATCH] gnu: Add python-mailmanclient.
>> 
>> * gnu/packages/mail.scm (python-mailmanclient): New variable.
>
>> +(define-public python2-mailmanclient
>> +  (let ((base (package-with-python2
>> +               (strip-python2-variant python-mailmanclient))))
>> +    (package (inherit base)
>> +      (native-inputs
>> +       `(("python2-setuptools" ,python2-setuptools))))))
>
> This variant will not be used unless there is a python2-variant
> properties field in python-mailman, like this:
>
> (properties `((python2-variant . ,(delay python2-mailmanclient))))
>
> You can see the recent commit "gnu: Add python-q. (e8c9b01090)" for an
> example in context.

Is this necessary for all python2 package variants? I rarely see this.
Hartmut Goebel Sept. 28, 2016, 5:37 p.m. UTC | #4
Am 28.09.2016 um 19:14 schrieb Leo Famulari:
> > +       `(("python2-setuptools" ,python2-setuptools))))))
This will no longer be needed if my latest changes to the
python-build-systm will be accepted.
Leo Famulari Sept. 28, 2016, 5:48 p.m. UTC | #5
On Wed, Sep 28, 2016 at 05:25:52PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > [ Unknown signature status ]
> > On Wed, Sep 28, 2016 at 05:02:56PM +0000, ng0 wrote:
> >> Subject: [PATCH] gnu: Add python-mailmanclient.
> >> 
> >> * gnu/packages/mail.scm (python-mailmanclient): New variable.
> >
> >> +(define-public python2-mailmanclient
> >> +  (let ((base (package-with-python2
> >> +               (strip-python2-variant python-mailmanclient))))
> >> +    (package (inherit base)
> >> +      (native-inputs
> >> +       `(("python2-setuptools" ,python2-setuptools))))))
> >
> > This variant will not be used unless there is a python2-variant
> > properties field in python-mailman, like this:
> >
> > (properties `((python2-variant . ,(delay python2-mailmanclient))))
> >
> > You can see the recent commit "gnu: Add python-q. (e8c9b01090)" for an
> > example in context.
> 
> Is this necessary for all python2 package variants? I rarely see this.

For any use of the python2-variant system, yes. I replied to a lot of
your submitted packages a couple days ago to point out that they needed
this change.

If you are just doing a plain package-with-python2 transformation, then
it's not required. Python2-variant is used when package-with-python2 is
not enough, because there are extra inputs, arguments, etc.
Hartmut Goebel Sept. 28, 2016, 6:24 p.m. UTC | #6
Am 28.09.2016 um 19:48 schrieb Leo Famulari:
>> > Is this necessary for all python2 package variants? I rarely see this.
> For any use of the python2-variant system, yes. I replied to a lot of
> your submitted packages a couple days ago to point out that they needed
> this change.

I want to emphasis again me recent change to the python-build-system,
which makes setuptools available for Python 2, too, and will thus
unburden from the need of both setting python2-variant and manually
inheriting a package to add python2-setuptools. So for most cases a
plain package-with-python2 transformation would be enough.

Maybe you want to review that patch-series soon :-)
diff mbox

Patch

From bdcb5e7e77bd3e215016b3d9fde5094d618e64b9 Mon Sep 17 00:00:00 2001
From: ng0 <ngillmann@runbox.com>
Date: Wed, 28 Sep 2016 16:58:29 +0000
Subject: [PATCH] gnu: Add python-mailmanclient.

* gnu/packages/mail.scm (python-mailmanclient): New variable.
---
 gnu/packages/mail.scm | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 09c15e2..41e564a 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -15,7 +15,7 @@ 
 ;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
 ;;; Copyright © 2016 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2016 Troy Sankey <sankeytms@gmail.com>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 ng0 <ngillmann@runbox.com>
 ;;; Copyright © 2016 Clément Lassieur <clement@lassieur.org>
 ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016 John Darrington <jmd@gnu.org>
@@ -1493,3 +1493,33 @@  transfer protocols.")
     (license (non-copyleft "file://LICENSE"
                            "See LICENSE in the distribution."))))
 
+(define-public python-mailmanclient
+  (package
+    (name "python-mailmanclient")
+    (version "1.0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mailmanclient" version))
+       (sha256
+        (base32
+         "1cfjh45fgbsax5hjj2inq9nk33dhdvh63xhysc8dhnqidgqgm8c5"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ; Requires mailman running
+    (inputs
+     `(("python-six" ,python-six)
+       ("python-httplib2" ,python-httplib2)))
+    (home-page "http://launchpad.net/mailman.client")
+    (synopsis "Python bindings for the Mailman 3 REST API")
+    (description
+     "The mailmanclient library provides official Python bindings for
+the GNU Mailman 3 REST API.")
+    (license lgpl3+)))
+
+(define-public python2-mailmanclient
+  (let ((base (package-with-python2
+               (strip-python2-variant python-mailmanclient))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools))))))
-- 
2.10.0