diff mbox

gnu: Add rottlog.

Message ID 87h9crabtk.fsf@gnu.org
State New
Headers show

Commit Message

Jan Nieuwenhuizen June 17, 2016, 6:51 p.m. UTC
Leo Famulari writes:

> Ludovic sent a WIP mcron service to guix-devel recently; you might take
> a look at that. Alternatively, I run mcron for my user only and it works
> as expected.

Thanks!

>> +              (patches (search-patches "rottlog.patch"))))
>
> That patch is missing from this patch ;)

Oops, again...

>> +    (arguments
>> +     '(#:configure-flags
>> +       (list (string-append "ROTT_ETCDIR=" %output "/etc/rottlog"))))
>> +    (build-system gnu-build-system)
>
> Nit-picky, but I think the order should be: source, build-system,
> arguments, inputs. At least, source should be first.

Ok.

>> +    (description
>> +     "GNU Rot[t]log is designed to simplify administration of systems that
>
> I think the description should contain the string "Rottlog" or
> "rottlog", to make searching easier.

Copied that [t] thing from the home page; changed to Rottlog.

Thanks!

Greetings,
Jan

Comments

Leo Famulari June 18, 2016, 1:50 a.m. UTC | #1
On Fri, Jun 17, 2016 at 08:51:19PM +0200, Jan Nieuwenhuizen wrote:
> Subject: [PATCH] gnu: Add rottlog.

Silly me! I just noticed that we already have this packaged in (gnu
packages admin). Can you take a look and see if it meets your needs, or
if it needs some changes?
Jan Nieuwenhuizen June 18, 2016, 10:05 a.m. UTC | #2
Leo Famulari writes:

> On Fri, Jun 17, 2016 at 08:51:19PM +0200, Jan Nieuwenhuizen wrote:
>> Subject: [PATCH] gnu: Add rottlog.
>
> Silly me! I just noticed that we already have this packaged in (gnu
> packages admin). Can you take a look and see if it meets your needs, or
> if it needs some changes?

Silly you?  Silly me!  Sorry, I must have misunderstood civodul,
it already looks better, now to see how to hook it up.

Greetings,
Jan
Ludovic Courtès June 19, 2016, 1:51 p.m. UTC | #3
Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> Leo Famulari writes:
>
>> On Fri, Jun 17, 2016 at 08:51:19PM +0200, Jan Nieuwenhuizen wrote:
>>> Subject: [PATCH] gnu: Add rottlog.
>>
>> Silly me! I just noticed that we already have this packaged in (gnu
>> packages admin). Can you take a look and see if it meets your needs, or
>> if it needs some changes?
>
> Silly you?  Silly me!  Sorry, I must have misunderstood civodul,
> it already looks better, now to see how to hook it up.

Apologies if I spread confusion!

Basically Rottlog is already packaged but when I tried running it, it
would fail in obscure ways (I never really investigated, though).

As for mcron, I have plans to push a reworked versioned of the patch I
posted earlier Real Soon Now.

Thanks,
Ludo’.
Jan Nieuwenhuizen June 19, 2016, 2:04 p.m. UTC | #4
Ludovic Courtès writes:

> Apologies if I spread confusion!

:-)  I remember you said something like "We have Rottlog" where I
filled-in we=GNU instead of we=Guix.  So many me's :-)

> Basically Rottlog is already packaged but when I tried running it, it
> would fail in obscure ways (I never really investigated, though).

That's what I found.  It needs a packdir or archivedir and keeps a
 /.lastweek timestam.  I tried to hook up your mcron service with a
 daily rottlog but it seems that I need to reboot instead of only
 reconfigure.

> As for mcron, I have plans to push a reworked versioned of the patch I
> posted earlier Real Soon Now.

:-)  I'll let you know what I find.

Greetings,
Jan
diff mbox

Patch

From f234c4be61c697f55ab66b15863d623b6458733e Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen <janneke@gnu.org>
Date: Fri, 17 Jun 2016 16:33:16 +0200
Subject: [PATCH] gnu: Add rottlog.

* gnu/packages/logging.scm (rottlog): New variable.
---
 gnu/packages/logging.scm           | 33 ++++++++++++++++++++++++++++++++-
 gnu/packages/patches/rottlog.patch | 12 ++++++++++++
 2 files changed, 44 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/rottlog.patch

diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index 68af09e..01279b1 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -1,5 +1,6 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -22,7 +23,9 @@ 
   #:use-module (guix utils)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
-  #:use-module (gnu packages))
+  #:use-module (gnu packages)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages texinfo))
 
 (define-public log4cpp
   (package
@@ -45,3 +48,31 @@  IDSA and other destinations.  It is modeled after the Log4j Java library,
 staying as close to their API as is reasonable.")
     (home-page "http://log4cpp.sourceforge.net/")
     (license license:lgpl2.1+)))
+
+(define-public rottlog
+  (package
+    (name "rottlog")
+    (version "0.72.2")
+    (inputs `(("util-linux" ,util-linux) ; cal
+              ("texinfo" ,texinfo)))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnu/rottlog/rottlog-" version
+                                  ".tar.gz"))
+              (sha256
+               (base32
+                "0751mb9l2f0jrk3vj6q8ilanifd121dliwk0c34g8k0dlzsv3kd7"))
+              (patches (search-patches "rottlog.patch"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags
+       (list (string-append "ROTT_ETCDIR=" %output "/etc/rottlog"))))
+    (synopsis "The GNU log management facility")
+    (description
+     "GNU Rottlog is designed to simplify administration of systems that
+generate large numbers of log files.  It allows automatic rotation,
+compression, and archiving of logs.  It also mails reports to the system
+administrator.  Each log file may be handled daily, weekly, monthly, in
+user-defined days, or when it becomes too large.")
+    (home-page "https://www.gnu.org/software/rottlog/")
+    (license license:gpl3+)))
diff --git a/gnu/packages/patches/rottlog.patch b/gnu/packages/patches/rottlog.patch
new file mode 100644
index 0000000..ed3eea4
--- /dev/null
+++ b/gnu/packages/patches/rottlog.patch
@@ -0,0 +1,12 @@ 
+diff -purN rottlog-0.72.2.orig/Makefile.in rottlog-0.72.2/Makefile.in
+--- rottlog-0.72.2.orig/Makefile.in	2010-03-30 07:06:27.000000000 +0200
++++ rottlog-0.72.2/Makefile.in	2016-06-17 16:02:14.008167895 +0200
+@@ -182,7 +182,7 @@ GZIP = @GZIP@
+ INSTALL = @INSTALL@
+ INSTALL_DATA = @INSTALL_DATA@
+ INSTALL_PROGRAM = @INSTALL_PROGRAM@
+-INSTALL_SCRIPT = ${INSTALL} -o ${LOG_OWN} -g ${LOG_GROUP} -m ${LOG_MODE}
++INSTALL_SCRIPT = ${INSTALL} -m ${LOG_MODE}
+ INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
+ LIBOBJS = @LIBOBJS@
+ LIBS = @LIBS@
-- 
2.8.4