diff mbox

ruby-spring

Message ID 87d1o0ybjj.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me
State New
Headers show

Commit Message

Matthew Jordan June 1, 2016, 7:05 p.m. UTC
Good Day,

I have updated the synopsis and the description.  Please see the
following comment also;

> +    (arguments
> +     `(#:test-target "test:unit"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'remove-bump
> +           (lambda _
> +             (substitute* "spring.gemspec"
> +               (("gem.add_development_dependency 'bump'") ""))
> +             (substitute* "Rakefile"
> +               (("require \\\"bump/tasks\\\"") ""))
> +             #t)))))

The files spring.gemspec and Rakefile do not exist.
Respectuflly,

Comments

Ben Woodcroft June 1, 2016, 11:03 p.m. UTC | #1
On 02/06/16 05:05, Matthew Jordan wrote:
> Good Day,

It is cloudy and cold outside here and the air conditioning is being its 
usual overzealous self. But at least we won the football. I hope it is a 
good day for you too.

> I have updated the synopsis and the description.  Please see the
> following comment also;
>
>> +    (arguments
>> +     `(#:test-target "test:unit"
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'check 'remove-bump
>> +           (lambda _
>> +             (substitute* "spring.gemspec"
>> +               (("gem.add_development_dependency 'bump'") ""))
>> +             (substitute* "Rakefile"
>> +               (("require \\\"bump/tasks\\\"") ""))
>> +             #t)))))
> The files spring.gemspec and Rakefile do not exist.

Not in the gem they don't, but I changed the source field to download 
the release from GitHub. Unfortunately not including test files in the 
gem is not uncommon for Ruby libraries (especially rails ones), but we 
should endeavour to include them where possible.

> +(define-public ruby-spring
> +  (package
> +    (name "ruby-spring")
> +    (version "1.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "spring" version))
> +       (sha256
> +        (base32
> +         "165f6n6am36md1lzaivcg9bx09f7iph4vab0f8av2rlza4yi791p"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;; no Rakefile found

We should add tests as I suggested in the last email, so this doesn't 
matter now, but for future reference comments at the end of lines like 
this by convention are only prefixed by a single ';' not ';;' as you 
have done here.

> +    (synopsis
> +     "Spring is a Rails application preloader")

I think it looks better if the synopsis is kept on one line, if possible.

> +    (description
> +     "Spring is a Rails application preloader.  It speeds up development by
> +keeping your application running in the background so you don't need to boot
> +it every time you run a test, rake task or migration.")

s/your/the rails/, otherwise looks good.

> +    (home-page"https://github.com/rails/spring")
> +    (license expat)))
Shall we keep the same license: prefix in rails.scm as ruby.scm? Then 
here it would be "license:expat" with appropriate changes to the top of 
the file.

Thanks,
ben
diff mbox

Patch

From 3a9d916463e7d10c275b65b5712ccd288fffdc07 Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:29:24 -0400
Subject: [PATCH] gnu: Add ruby-spring.

* gnu/packages/rails.scm: Modified file.
---
 gnu/packages/rails.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
index 77ab354..1b1de06 100644
--- a/gnu/packages/rails.scm
+++ b/gnu/packages/rails.scm
@@ -23,6 +23,29 @@ 
   #:use-module (gnu packages ruby)
   #:use-module (guix build-system ruby))
 
+(define-public ruby-spring
+  (package
+    (name "ruby-spring")
+    (version "1.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "spring" version))
+       (sha256
+        (base32
+         "165f6n6am36md1lzaivcg9bx09f7iph4vab0f8av2rlza4yi791p"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f)) ;; no Rakefile found
+    (synopsis
+     "Spring is a Rails application preloader")
+    (description
+     "Spring is a Rails application preloader.  It speeds up development by
+keeping your application running in the background so you don't need to boot
+it every time you run a test, rake task or migration.")
+    (home-page "https://github.com/rails/spring")
+    (license expat)))
+
 (define-public ruby-debug-inspector
   (package
     (name "ruby-debug-inspector")
-- 
2.8.3