diff mbox

[core-updates] gnu: gnupg, libgpg-error updates rebased

Message ID 877fbbg7cp.fsf@we.make.ritual.n0.is
State New
Headers show

Commit Message

non such Aug. 20, 2016, 8:41 a.m. UTC
ng0 <ng0@we.make.ritual.n0.is> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Thu, Aug 18, 2016 at 07:27:14PM +0000, ng0 wrote:
>>> Leo Famulari <leo@famulari.name> writes:
>>> 
>>> > On Thu, Aug 18, 2016 at 06:34:24PM +0000, ng0 wrote:
>>> >> GnuPG 2.1.15 has just been released, but please apply this patch, I'll
>>> >> have 2.1.15 ready later and send a separate patch of it based on this one.
>>> >
>>> > I applied your update patch for libgpg-error, but I rewrote the gnupg
>>> > update patch from scratch.
>>> >
>>> > So, no need for a "gnupg: Update to 2.1.15" patch. It's already done.
>>> 
>>> I'm not so sure. My build of it failed when the tests happened, which is
>>> why my patch included a fix for that:
>>> https://lists.gnu.org/archive/html/guix-devel/2016-08/msg01276.html
>>
>> Ah, you're right. Can you send a patch for core-updates?
>
> http://lists.gnu.org/archive/html/guix-devel/2016-08/msg01276.html
> includes this already.

Disregard the previous message, this one applies on top of your changes
on core-updates. It has not been run, I'm starting the build now, but it
is the same as the original gnupg update I had.

Comments

non such Aug. 20, 2016, 9:27 a.m. UTC | #1
ng0 <ng0@we.make.ritual.n0.is> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Thu, Aug 18, 2016 at 07:27:14PM +0000, ng0 wrote:
>>>> Leo Famulari <leo@famulari.name> writes:
>>>> 
>>>> > On Thu, Aug 18, 2016 at 06:34:24PM +0000, ng0 wrote:
>>>> >> GnuPG 2.1.15 has just been released, but please apply this patch, I'll
>>>> >> have 2.1.15 ready later and send a separate patch of it based on this one.
>>>> >
>>>> > I applied your update patch for libgpg-error, but I rewrote the gnupg
>>>> > update patch from scratch.
>>>> >
>>>> > So, no need for a "gnupg: Update to 2.1.15" patch. It's already done.
>>>> 
>>>> I'm not so sure. My build of it failed when the tests happened, which is
>>>> why my patch included a fix for that:
>>>> https://lists.gnu.org/archive/html/guix-devel/2016-08/msg01276.html
>>>
>>> Ah, you're right. Can you send a patch for core-updates?
>>
>> http://lists.gnu.org/archive/html/guix-devel/2016-08/msg01276.html
>> includes this already.
>
> Disregard the previous message, this one applies on top of your changes
> on core-updates. It has not been run, I'm starting the build now, but it
> is the same as the original gnupg update I had.

It has been run, build succeeds.


> From 3aec89f0444bd1e75f8dfa945e586a79790d254d Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Sat, 20 Aug 2016 08:37:22 +0000
> Subject: [PATCH] gnu: gnupg: Fix test failures.
>
> * gnu/packages/gnupg.scm (gnupg)[arguments]: Set $HOME before 'check.
> ---
>  gnu/packages/gnupg.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
> index 27db5c3..52a9fc5 100644
> --- a/gnu/packages/gnupg.scm
> +++ b/gnu/packages/gnupg.scm
> @@ -247,7 +247,13 @@ compatible to GNU Pth.")
>            (lambda _
>              (substitute* (find-files "tests" ".\\.scm$")
>                (("/usr/bin/env gpgscm")
> -               (string-append (getcwd) "/tests/gpgscm/gpgscm"))))))))
> +               (string-append (getcwd) "/tests/gpgscm/gpgscm")))))
> +        (add-before 'check 'set-home
> +          ;; Some tests require write access to $HOME, otherwise leading to
> +          ;; 'failed to create directory /homeless-shelter/.asy' error.
> +          (lambda _
> +            (setenv "HOME" "/tmp")
> +            #t)))))
>      (home-page "https://gnupg.org/")
>      (synopsis "GNU Privacy Guard")
>      (description
> -- 
> 2.9.3
>
>
Leo Famulari Aug. 21, 2016, 10:09 p.m. UTC | #2
On Sat, Aug 20, 2016 at 09:27:25AM +0000, ng0 wrote:
> > From 3aec89f0444bd1e75f8dfa945e586a79790d254d Mon Sep 17 00:00:00 2001
> > From: ng0 <ng0@we.make.ritual.n0.is>
> > Date: Sat, 20 Aug 2016 08:37:22 +0000
> > Subject: [PATCH] gnu: gnupg: Fix test failures.
> >
> > * gnu/packages/gnupg.scm (gnupg)[arguments]: Set $HOME before 'check.

Thank you for catching this! Pushed as dd582f4ae5.
diff mbox

Patch

From 3aec89f0444bd1e75f8dfa945e586a79790d254d Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Sat, 20 Aug 2016 08:37:22 +0000
Subject: [PATCH] gnu: gnupg: Fix test failures.

* gnu/packages/gnupg.scm (gnupg)[arguments]: Set $HOME before 'check.
---
 gnu/packages/gnupg.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index 27db5c3..52a9fc5 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -247,7 +247,13 @@  compatible to GNU Pth.")
           (lambda _
             (substitute* (find-files "tests" ".\\.scm$")
               (("/usr/bin/env gpgscm")
-               (string-append (getcwd) "/tests/gpgscm/gpgscm"))))))))
+               (string-append (getcwd) "/tests/gpgscm/gpgscm")))))
+        (add-before 'check 'set-home
+          ;; Some tests require write access to $HOME, otherwise leading to
+          ;; 'failed to create directory /homeless-shelter/.asy' error.
+          (lambda _
+            (setenv "HOME" "/tmp")
+            #t)))))
     (home-page "https://gnupg.org/")
     (synopsis "GNU Privacy Guard")
     (description
-- 
2.9.3