diff mbox

import: utils: Remove dependency on (json) module.

Message ID 8760otwo39.fsf@gmail.com
State New
Headers show

Commit Message

Alex Kost Oct. 15, 2016, 4:53 p.m. UTC
Commit fbe9c1012820 introduced unneeded dependency on (json) module,
i.e. 'guile-json' is a hard dependency of Guix now.

Was it an accident, or do I miss anything?

Comments

Ricardo Wurmus Oct. 16, 2016, 10:29 a.m. UTC | #1
Alex Kost <alezost@gmail.com> writes:

> Commit fbe9c1012820 introduced unneeded dependency on (json) module,
> i.e. 'guile-json' is a hard dependency of Guix now.
>
> Was it an accident, or do I miss anything?

I think this was an accident.  We always tried to keep guile-json as a
soft dependency in the past and I don’t recall any decision about making
it a hard dependency.
Alex Kost Oct. 16, 2016, 4:23 p.m. UTC | #2
Ricardo Wurmus (2016-10-16 12:29 +0200) wrote:

> Alex Kost <alezost@gmail.com> writes:
>
>> Commit fbe9c1012820 introduced unneeded dependency on (json) module,
>> i.e. 'guile-json' is a hard dependency of Guix now.
>>
>> Was it an accident, or do I miss anything?
>
> I think this was an accident.  We always tried to keep guile-json as a
> soft dependency in the past and I don’t recall any decision about making
> it a hard dependency.

Right, that's what I thought, David also confirmed it (he probably
forgot to CC guix-devel), so I've committed this patch, thanks.
diff mbox

Patch

From cb529053b90cd4067fb6cb9a256b1ce3bd2a24f7 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Sat, 15 Oct 2016 19:41:35 +0300
Subject: [PATCH] import: utils: Remove dependency on (json) module.

This fixes a regression introduced by commit
fbe9c1012820ab72f022a6ec958c35b431ae7a74.

* guix/import/utils.scm: Remove unused (json) module.
---
 guix/import/utils.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/guix/import/utils.scm b/guix/import/utils.scm
index e4059ca..057c2d9 100644
--- a/guix/import/utils.scm
+++ b/guix/import/utils.scm
@@ -26,7 +26,6 @@ 
   #:use-module (guix utils)
   #:use-module (ice-9 match)
   #:use-module (ice-9 regex)
-  #:use-module (json)
   #:use-module (srfi srfi-1)
   #:export (factorize-uri
 
-- 
2.9.2