| Message ID | 874m82crpp.fsf@openmailbox.org |
|---|---|
| State | New |
| Headers | show |
Kei Kebreau <kei@openmailbox.org> writes: > Hello all, > > I've completed a patch for GNU Denemo, though it has one minor issue. At > the end of the build it complains about a musical flat symbol in one of the > filenames. The other files like it use a "b" in place of the flat > symbol. Should I patch it just for Guix, or go upstream with my concerns > for consistency? What exactly complains about the character? I think Guix should be able to handle this just fine. Renaming the file because of what looks like a bug in Guix is not the right approach here. (Incidentally, I have a similar problem with “find-files”, which complains about files with non-ASCII characters in their name.) ~~ Ricardo
Ricardo Wurmus <rekado@elephly.net> writes: > Kei Kebreau <kei@openmailbox.org> writes: > >> Hello all, >> >> I've completed a patch for GNU Denemo, though it has one minor issue. At >> the end of the build it complains about a musical flat symbol in one of the >> filenames. The other files like it use a "b" in place of the flat >> symbol. Should I patch it just for Guix, or go upstream with my concerns >> for consistency? > > What exactly complains about the character? I think Guix should be able > to handle this just fine. Renaming the file because of what looks like > a bug in Guix is not the right approach here. > > (Incidentally, I have a similar problem with “find-files”, which > complains about files with non-ASCII characters in their name.) > > ~~ Ricardo > I just checked. The issue is "find-files." Have you come up with a solution to the issue, or is it just a bug in Guix that needs to be fixed?
Kei Kebreau <kei@openmailbox.org> writes: > Ricardo Wurmus <rekado@elephly.net> writes: > >> Kei Kebreau <kei@openmailbox.org> writes: >> >>> Hello all, >>> >>> I've completed a patch for GNU Denemo, though it has one minor issue. At >>> the end of the build it complains about a musical flat symbol in one of the >>> filenames. The other files like it use a "b" in place of the flat >>> symbol. Should I patch it just for Guix, or go upstream with my concerns >>> for consistency? >> >> What exactly complains about the character? I think Guix should be able >> to handle this just fine. Renaming the file because of what looks like >> a bug in Guix is not the right approach here. >> >> (Incidentally, I have a similar problem with “find-files”, which >> complains about files with non-ASCII characters in their name.) >> >> ~~ Ricardo >> > > I just checked. The issue is "find-files." Have you come up with a > solution to the issue, or is it just a bug in Guix that needs to be fixed? In my case it was because I used the “trivial-build-system”. Unlike the “gnu-build-system” it does not have a build phase which installs a UTF-8 locale. The way around it was to reuse the locale setting code in the “install-locale” phase. This probably won’t help you as you are already using the “gnu-build-system” so the build phases should run in a UTF-8 locale. Could it be that the file is not UTF-8 encoded and you really need some other encoding? ~~ Ricardo
Ricardo Wurmus <rekado@elephly.net> writes: > Kei Kebreau <kei@openmailbox.org> writes: > >> Ricardo Wurmus <rekado@elephly.net> writes: >> >>> Kei Kebreau <kei@openmailbox.org> writes: >>> >>>> Hello all, >>>> >>>> I've completed a patch for GNU Denemo, though it has one minor issue. At >>>> the end of the build it complains about a musical flat symbol in one of the >>>> filenames. The other files like it use a "b" in place of the flat >>>> symbol. Should I patch it just for Guix, or go upstream with my concerns >>>> for consistency? >>> >>> What exactly complains about the character? I think Guix should be able >>> to handle this just fine. Renaming the file because of what looks like >>> a bug in Guix is not the right approach here. >>> >>> (Incidentally, I have a similar problem with “find-files”, which >>> complains about files with non-ASCII characters in their name.) >>> >>> ~~ Ricardo >>> >> >> I just checked. The issue is "find-files." Have you come up with a >> solution to the issue, or is it just a bug in Guix that needs to be fixed? > > In my case it was because I used the “trivial-build-system”. Unlike the > “gnu-build-system” it does not have a build phase which installs a UTF-8 > locale. The way around it was to reuse the locale setting code in the > “install-locale” phase. > > This probably won’t help you as you are already using the > “gnu-build-system” so the build phases should run in a UTF-8 locale. > Could it be that the file is not UTF-8 encoded and you really need some > other encoding? > > ~~ Ricardo > The file is UTF-8 encoded (according to the file command), so I don't know why it would show the warning. Guix ultimately doesn't install the file to the store, which is why this is an issue.
Ricardo Wurmus <rekado@elephly.net> writes: > Kei Kebreau <kei@openmailbox.org> writes: > >> Ricardo Wurmus <rekado@elephly.net> writes: >> >>> Kei Kebreau <kei@openmailbox.org> writes: >>> >>>> Hello all, >>>> >>>> I've completed a patch for GNU Denemo, though it has one minor issue. At >>>> the end of the build it complains about a musical flat symbol in one of the >>>> filenames. The other files like it use a "b" in place of the flat >>>> symbol. Should I patch it just for Guix, or go upstream with my concerns >>>> for consistency? >>> >>> What exactly complains about the character? I think Guix should be able >>> to handle this just fine. Renaming the file because of what looks like >>> a bug in Guix is not the right approach here. >>> >>> (Incidentally, I have a similar problem with “find-files”, which >>> complains about files with non-ASCII characters in their name.) >>> >>> ~~ Ricardo >>> >> >> I just checked. The issue is "find-files." Have you come up with a >> solution to the issue, or is it just a bug in Guix that needs to be fixed? > > In my case it was because I used the “trivial-build-system”. Unlike the > “gnu-build-system” it does not have a build phase which installs a UTF-8 > locale. The way around it was to reuse the locale setting code in the > “install-locale” phase. > > This probably won’t help you as you are already using the > “gnu-build-system” so the build phases should run in a UTF-8 locale. > Could it be that the file is not UTF-8 encoded and you really need some > other encoding? > > ~~ Ricardo > If it helps, the issue with find-files only occurs during grafting. Do you suppose this could be a bug in the Guix's grafting code?
Kei Kebreau <kei@openmailbox.org> writes: > Ricardo Wurmus <rekado@elephly.net> writes: > >> Kei Kebreau <kei@openmailbox.org> writes: >> >>> Ricardo Wurmus <rekado@elephly.net> writes: >>> >>>> Kei Kebreau <kei@openmailbox.org> writes: >>>> >>>>> Hello all, >>>>> >>>>> I've completed a patch for GNU Denemo, though it has one minor issue. At >>>>> the end of the build it complains about a musical flat symbol in one of the >>>>> filenames. The other files like it use a "b" in place of the flat >>>>> symbol. Should I patch it just for Guix, or go upstream with my concerns >>>>> for consistency? >>>> >>>> What exactly complains about the character? I think Guix should be able >>>> to handle this just fine. Renaming the file because of what looks like >>>> a bug in Guix is not the right approach here. >>>> >>>> (Incidentally, I have a similar problem with “find-files”, which >>>> complains about files with non-ASCII characters in their name.) >>>> >>>> ~~ Ricardo >>>> >>> >>> I just checked. The issue is "find-files." Have you come up with a >>> solution to the issue, or is it just a bug in Guix that needs to be fixed? >> >> In my case it was because I used the “trivial-build-system”. Unlike the >> “gnu-build-system” it does not have a build phase which installs a UTF-8 >> locale. The way around it was to reuse the locale setting code in the >> “install-locale” phase. >> >> This probably won’t help you as you are already using the >> “gnu-build-system” so the build phases should run in a UTF-8 locale. >> Could it be that the file is not UTF-8 encoded and you really need some >> other encoding? >> >> ~~ Ricardo >> > > If it helps, the issue with find-files only occurs during grafting. Do > you suppose this could be a bug in the Guix's grafting code? I don’t understand what this means. Grafting happens *after* the build and is independent, no? How can this have any effect on the behaviour of “find-files” then? Have you checked that there is no error when grafts are disabled? ~~ Ricardo
Ricardo Wurmus <rekado@elephly.net> writes: > Kei Kebreau <kei@openmailbox.org> writes: > >> Ricardo Wurmus <rekado@elephly.net> writes: >> >>> Kei Kebreau <kei@openmailbox.org> writes: >>> >>>> Ricardo Wurmus <rekado@elephly.net> writes: >>>> >>>>> Kei Kebreau <kei@openmailbox.org> writes: >>>>> >>>>>> Hello all, >>>>>> >>>>>> I've completed a patch for GNU Denemo, though it has one minor issue. At >>>>>> the end of the build it complains about a musical flat symbol in one of the >>>>>> filenames. The other files like it use a "b" in place of the flat >>>>>> symbol. Should I patch it just for Guix, or go upstream with my concerns >>>>>> for consistency? >>>>> >>>>> What exactly complains about the character? I think Guix should be able >>>>> to handle this just fine. Renaming the file because of what looks like >>>>> a bug in Guix is not the right approach here. >>>>> >>>>> (Incidentally, I have a similar problem with “find-files”, which >>>>> complains about files with non-ASCII characters in their name.) >>>>> >>>>> ~~ Ricardo >>>>> >>>> >>>> I just checked. The issue is "find-files." Have you come up with a >>>> solution to the issue, or is it just a bug in Guix that needs to be fixed? >>> >>> In my case it was because I used the “trivial-build-system”. Unlike the >>> “gnu-build-system” it does not have a build phase which installs a UTF-8 >>> locale. The way around it was to reuse the locale setting code in the >>> “install-locale” phase. >>> >>> This probably won’t help you as you are already using the >>> “gnu-build-system” so the build phases should run in a UTF-8 locale. >>> Could it be that the file is not UTF-8 encoded and you really need some >>> other encoding? >>> >>> ~~ Ricardo >>> >> >> If it helps, the issue with find-files only occurs during grafting. Do >> you suppose this could be a bug in the Guix's grafting code? > > I don’t understand what this means. Grafting happens *after* the build > and is independent, no? How can this have any effect on the behaviour > of “find-files” then? > > Have you checked that there is no error when grafts are disabled? > > ~~ Ricardo > There isn't any error when grafts are disabled, and the formerly missing file is present. All I can gather is that when grafting is enabled the build occurs without a hitch, grafting denemo begins, and the following error appears: grafting '/gnu/store/1nb86mqssww679y2sg6iycab5qa76iid-denemo-2.0.8' -> '/gnu/store/jc552i8jh5fpdhsfkxwlhmsx8vh5gw3n-denemo-2.0.8'... find-files: /gnu/store/1nb86mqssww679y2sg6iycab5qa76iid-denemo-2.0.8/share/denemo/templates/ instruments/woodwind/Clarinet in B???.denemo: No such file or directory Where the "???" represents a ♭ symbol.
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 91ba4be..bdf070e 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -224,6 +224,65 @@ score, keyboard, guitar, drum and controller views.") many input formats and provides a customisable Vi-style user interface.") (license license:gpl2+))) +(define-public denemo + (package + (name "denemo") + (version "2.0.8") + (source (origin + (method url-fetch) + (uri (string-append "mirror://gnu/denemo/denemo-" + version ".tar.gz")) + (sha256 + (base32 + "0c12pa9fgal618agsv22hfwx1gd0pybbimn968q7ll7wyr2q9c95")))) + (build-system gnu-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (replace 'check + (lambda _ + (zero? (system* "make" "-C" "tests" "check"))))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("glib:bin", glib "bin") ; for gtester + ("pkg-config" ,pkg-config))) + (inputs + `(("alsa-lib" ,alsa-lib) + ("aubio" ,aubio) + ("evince" ,evince) + ("fftw" ,fftw) + ("fluidsynth" ,fluidsynth) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("gtk-doc" ,gtk-doc) + ("gtksourceview" ,gtksourceview) + ("guile" ,guile-2.0) + ("intltool" ,intltool) + ("librsvg" ,librsvg) + ("libsndfile" ,libsndfile) + ("libtool" ,libtool) + ("libxml2" ,libxml2) + ("lilypond" ,lilypond) + ("portaudio" ,portaudio) + ("portmidi" ,portmidi) + ("rubberband" ,rubberband))) + (synopsis "Graphical music notation, front-end to GNU Lilypond") + (description + "GNU Denemo is a music notation editor that provides a convenient +interface to the powerful music engraving program Lilypond. Music can be +typed in using the computer keyboard, played in using a MIDI keyboard, or +even input via a microphone connected to the sound card. The final product +is publication-quality music notation that is continuously generated in the +background while you work.") + (home-page "http://www.denemo.org") + (license (list license:cc-by-sa3.0 + license:lgpl2.1+ + license:gpl2 + license:gpl2+ + license:gpl3 + license:gpl3+)))) + (define-public hydrogen (package (name "hydrogen")
Hello all, I've completed a patch for GNU Denemo, though it has one minor issue. At the end of the build it complains about a musical flat symbol in one of the filenames. The other files like it use a "b" in place of the flat symbol. Should I patch it just for Guix, or go upstream with my concerns for consistency? From ca3ebf7bebb4a62d1e1426f4bceead2d2edeff68 Mon Sep 17 00:00:00 2001 From: Kei Kebreau <kei@openmailbox.org> Date: Wed, 6 Jul 2016 18:34:03 -0400 Subject: [PATCH] gnu: Add denemo. * gnu/packages/music.scm: New variable. --- gnu/packages/music.scm | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+)