diff mbox

gnu: dmidecode: Update to 3.0. (was: Re: [PATCH] gnu: Add dmidecode.)

Message ID 874m75k265.fsf_-_@openmailbox.org
State New
Headers show

Commit Message

Kei Yamashita July 31, 2016, 8:01 p.m. UTC
ng0 <ng0@we.make.ritual.n0.is> writes:

> Hi,
>
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> A package for those who like to roam around the lower levels of their
>> machines. As soon as this package is verified to build successfully and
>> reproducibly on another user's machine, I can push it to the repos.
>>
>> From 37c3cc1021671d93dca2c34c4d3b392173b84ef1 Mon Sep 17 00:00:00 2001
>> From: Kei Kebreau <kei@openmailbox.org>
>> Date: Sun, 31 Jul 2016 13:59:59 -0400
>> Subject: [PATCH] gnu: Add dmidecode.
>>
>> * gnu/packages/linux.scm (dmidecode): New variable.
>> ---
>
> I don't understand.. is an upgrade not enough?
>
> ng0@shadowwalker ~$ guix package -s dmidecode
> name: dmidecode
> version: 2.12
> outputs: out
> systems: x86_64-linux i686-linux armhf-linux mips64el-linux
> dependencies:
> location: gnu/packages/admin.scm:982:2
> homepage: http://www.nongnu.org/dmidecode/
> license: GPL 2+
> synopsis: Read hardware information from the BIOS
> description: Dmidecode reports information about your system's hardware
> as
> + described in your system BIOS according to the SMBIOS/DMI standard.
> This
> + typically includes system manufacturer, model name, serial number,
> BIOS
> + version, asset tag as well as a lot of other details of varying level
> of
> + interest and reliability depending on the manufacturer.  This will
> often
> + include usage status for the CPU sockets, expansion slots (e.g.  AGP,
> PCI,
> + ISA) and memory module slots, and the list of I/O ports (e.g.  serial,
> + parallel, USB).

Wow! I must have misspelled dmidecode when I searched for it! Silly me. :-P

I've attached a new patch. I don't know whether updating a version
number necessitates a copyright assignment, so I omitted it.
From 0ddaeaeefbcc39143f3538448a37de974e38d0b5 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sun, 31 Jul 2016 15:55:08 -0400
Subject: [PATCH] gnu: dmidecode: Update to 3.0.

* gnu/packages/admin.scm (dmidecode): Update to 3.0.
---
 gnu/packages/admin.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Ludovic Courtès July 31, 2016, 8:12 p.m. UTC | #1
Hi,

Kei Kebreau <kei@openmailbox.org> skribis:

> I've attached a new patch. I don't know whether updating a version
> number necessitates a copyright assignment, so I omitted it.

You mean a copyright line (no copyright assignment here :-)).  I’d argue
it doesn’t require one.

> From 0ddaeaeefbcc39143f3538448a37de974e38d0b5 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 31 Jul 2016 15:55:08 -0400
> Subject: [PATCH] gnu: dmidecode: Update to 3.0.
>
> * gnu/packages/admin.scm (dmidecode): Update to 3.0.

Please add:

  [argument]: Use ’modify-phases’ instead of ‘alist-delete’.

Otherwise LGTM, thank you!

Ludo’.
non such July 31, 2016, 8:13 p.m. UTC | #2
Kei Kebreau <kei@openmailbox.org> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Hi,
>>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> A package for those who like to roam around the lower levels of their
>>> machines. As soon as this package is verified to build successfully and
>>> reproducibly on another user's machine, I can push it to the repos.

snip

> Wow! I must have misspelled dmidecode when I searched for it! Silly me. :-P
>
> I've attached a new patch. I don't know whether updating a version
> number necessitates a copyright assignment, so I omitted it.

Thanks. No problem. I can not review it (or at least not right now), but
version bumps get copyright assignments too.
I think I could review it on tuesday or tomorrow night. Could you send
it as .patch in addition to inlined? I have not figured out how to
extract inlined patches in notmuch yet.

> From 0ddaeaeefbcc39143f3538448a37de974e38d0b5 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 31 Jul 2016 15:55:08 -0400
> Subject: [PATCH] gnu: dmidecode: Update to 3.0.
>
> * gnu/packages/admin.scm (dmidecode): Update to 3.0.
> ---
>  gnu/packages/admin.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 195959e..a80ee9d 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -981,18 +981,18 @@ network, which causes enabled computers to power on.")
>  (define-public dmidecode
>    (package
>      (name "dmidecode")
> -    (version "2.12")
> +    (version "3.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
>                      "mirror://savannah/dmidecode/dmidecode-"
> -                    version ".tar.bz2"))
> +                    version ".tar.xz"))
>                (sha256
>                 (base32
> -                "122hgaw8mpqdfra159lfl6pyk3837giqx6vq42j64fjnbl2z6gwi"))))
> +                "0iby0xfk5x3cdr0x0gxj5888jjyjhafvaq0l79civ73jjfqmphvy"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases (alist-delete 'configure %standard-phases)
> +     '(#:phases (modify-phases %standard-phases (delete 'configure))
>         #:tests? #f                                ; no 'check' target
>         #:make-flags (list (string-append "prefix="
>                                           (assoc-ref %outputs "out")))))
> -- 
> 2.9.2
>
diff mbox

Patch

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 195959e..a80ee9d 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -981,18 +981,18 @@  network, which causes enabled computers to power on.")
 (define-public dmidecode
   (package
     (name "dmidecode")
-    (version "2.12")
+    (version "3.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
                     "mirror://savannah/dmidecode/dmidecode-"
-                    version ".tar.bz2"))
+                    version ".tar.xz"))
               (sha256
                (base32
-                "122hgaw8mpqdfra159lfl6pyk3837giqx6vq42j64fjnbl2z6gwi"))))
+                "0iby0xfk5x3cdr0x0gxj5888jjyjhafvaq0l79civ73jjfqmphvy"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:phases (alist-delete 'configure %standard-phases)
+     '(#:phases (modify-phases %standard-phases (delete 'configure))
        #:tests? #f                                ; no 'check' target
        #:make-flags (list (string-append "prefix="
                                          (assoc-ref %outputs "out")))))