diff mbox

small patchseries to add the irc bot limnoria.

Message ID 871t0hjnw7.fsf@we.make.ritual.n0.is
State New
Headers show

Commit Message

non such Sept. 18, 2016, 2:14 p.m. UTC
This is a small patchseries to add the bot limnoria, based on supybot.

Comments

Alex Vong Sept. 18, 2016, 3:59 p.m. UTC | #1
Hello,

ng0 <ng0@we.make.ritual.n0.is> writes:

[...]
> +    (arguments
> +     `(#:tests? #f))
> +    (home-page "https://github.com/ProgVal/Limnoria")
> +    (synopsis "Modified version of Supybot (an IRC bot and framework)")
> +    (description
> +     "Modified version of Supybot with Python 3 and IRCv3 support,
> +embedded web server, translations (fr, fi, it, hu, de), and many
> +other enhancements and bug fixes.")
> +    (license license:bsd-3)))
> -- 
> 2.10.0

Perhaps the .travis.yml[0] will give clue on how to run the test?
I haven't tested it yet. My machine is still building Cython.

[0]: https://github.com/ProgVal/Limnoria

Cheers,
Alex
non such Sept. 18, 2016, 4:17 p.m. UTC | #2
Alex Vong <alexvong1995@gmail.com> writes:

> [ Unknown signature status ]
> Hello,
>
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
> [...]
>> +    (arguments
>> +     `(#:tests? #f))
>> +    (home-page "https://github.com/ProgVal/Limnoria")
>> +    (synopsis "Modified version of Supybot (an IRC bot and framework)")
>> +    (description
>> +     "Modified version of Supybot with Python 3 and IRCv3 support,
>> +embedded web server, translations (fr, fi, it, hu, de), and many
>> +other enhancements and bug fixes.")
>> +    (license license:bsd-3)))
>> -- 
>> 2.10.0
>
> Perhaps the .travis.yml[0] will give clue on how to run the test?
> I haven't tested it yet. My machine is still building Cython.

YOu are right.
Yes, it needs this: https://github.com/ProgVal/irctest and I won't
package this today. I can add a note to limnoria that this must be
packaged to write our own test phase.

> [0]: https://github.com/ProgVal/Limnoria
>
> Cheers,
> Alex
Leo Famulari Sept. 20, 2016, 9:38 p.m. UTC | #3
On Sun, Sep 18, 2016 at 02:14:32PM +0000, ng0 wrote:
> This is a small patchseries to add the bot limnoria, based on supybot.

Thanks!

> * gnu/packages/python.scm (python-socksipy-branch): New variable.

> +    (home-page "http://code.google.com/p/socksipy-branch/")

Error 404.

> +(define-public python2-socksipy-branch
> +  (package-with-python2
> +   (strip-python2-variant python-socksipy-branch)))

I don't think this needs strip-python2-variant. It should be enough to
use package-with-python2.

> Subject: [PATCH 2/4] license: Add freebsd-doc.
> 
> * guix/licenses.scm (freebsd-doc): New variable.

LGTM

> Subject: [PATCH 3/4] gnu: Add python-feedparser.
> 
> * gnu/packages/python.scm (python-feedparser): New variable.

LGTM

> Subject: [PATCH 4/4] gnu: Add limnoria.
> 
> * gnu/packages/irc.scm (limnoria): New variable.

LGTM. It would be nice to figure out how to run the tests, if they are
meant to be run by distributions.
non such Sept. 21, 2016, 8:33 a.m. UTC | #4
Leo Famulari <leo@famulari.name> writes:

> [ Unknown signature status ]
> On Sun, Sep 18, 2016 at 02:14:32PM +0000, ng0 wrote:
>> This is a small patchseries to add the bot limnoria, based on supybot.
>
> Thanks!
>
>> * gnu/packages/python.scm (python-socksipy-branch): New variable.
>
>> +    (home-page "http://code.google.com/p/socksipy-branch/")

Right, it is now https://code.google.com/archive/p/socksipy-branch/
until Google will finally to decide to shut down yet another product
people relied on.

>
> Error 404.
>
>> +(define-public python2-socksipy-branch
>> +  (package-with-python2
>> +   (strip-python2-variant python-socksipy-branch)))
>
> I don't think this needs strip-python2-variant. It should be enough to
> use package-with-python2.

I found this failed very often for me. I can try it again.

>> Subject: [PATCH 2/4] license: Add freebsd-doc.
>> 
>> * guix/licenses.scm (freebsd-doc): New variable.
>
> LGTM
>
>> Subject: [PATCH 3/4] gnu: Add python-feedparser.
>> 
>> * gnu/packages/python.scm (python-feedparser): New variable.
>
> LGTM
>
>> Subject: [PATCH 4/4] gnu: Add limnoria.
>> 
>> * gnu/packages/irc.scm (limnoria): New variable.
>
> LGTM. It would be nice to figure out how to run the tests, if they are
> meant to be run by distributions..
diff mbox

Patch

From 9e378d8d6878ab65ca6afa196901a9b8b8590ea5 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Sun, 18 Sep 2016 14:11:20 +0000
Subject: [PATCH 4/4] gnu: Add limnoria.

* gnu/packages/irc.scm (limnoria): New variable.
---
 gnu/packages/irc.scm | 38 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm
index 1058bef..de3569e 100644
--- a/gnu/packages/irc.scm
+++ b/gnu/packages/irc.scm
@@ -26,6 +26,7 @@ 
   #:use-module (guix packages)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages aspell)
   #:use-module (gnu packages autogen)
@@ -48,7 +49,8 @@ 
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages tcl)
-  #:use-module (gnu packages tls))
+  #:use-module (gnu packages tls)
+  #:use-module (gnu packages web))
 
 (define-public quassel
   (package
@@ -291,3 +293,37 @@  and extensible with plugins and scripts.")
     (description
      "sic is a simple IRC client, even more minimalistic than ii.")
     (license license:expat)))
+
+(define-public limnoria
+  (package
+    (name "limnoria")
+    (version "2016.08.07")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "limnoria" version))
+       (sha256
+        (base32
+         "0w1d98hfhn4iqrczam7zahhqsvxa79n3xfcrm4jwkg5lba4f9ccm"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-pytz" ,python-pytz)
+       ("python-chardet" ,python-chardet)
+       ("python-dateutil" ,python-dateutil)
+       ("python-gnupg" ,python-gnupg)
+       ("python-feedparser" ,python-feedparser)
+       ("python-sqlalchemy" ,python-sqlalchemy)
+       ("python-socksipy-branch" ,python-socksipy-branch)
+       ("python-ecdsa" ,python-ecdsa)))
+    (native-inputs
+     `(("python-mock" ,python-mock)))
+    ;; Despite the existence of a test folder there is no test phase.
+    (arguments
+     `(#:tests? #f))
+    (home-page "https://github.com/ProgVal/Limnoria")
+    (synopsis "Modified version of Supybot (an IRC bot and framework)")
+    (description
+     "Modified version of Supybot with Python 3 and IRCv3 support,
+embedded web server, translations (fr, fi, it, hu, de), and many
+other enhancements and bug fixes.")
+    (license license:bsd-3)))
-- 
2.10.0