diff mbox

build-system/gnu: Make libraries writable before stripping.

Message ID 20161124162134.11241-1-mbakke@fastmail.com
State New
Headers show

Commit Message

Marius Bakke Nov. 24, 2016, 4:21 p.m. UTC
* guix/build/gnu-build-system.scm (strip)[strip-dir]: Change mode of
files before running strip-command.
---
 guix/build/gnu-build-system.scm | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ludovic Courtès Nov. 25, 2016, 10:59 p.m. UTC | #1
Marius Bakke <mbakke@fastmail.com> skribis:

> * guix/build/gnu-build-system.scm (strip)[strip-dir]: Change mode of
> files before running strip-command.

OK for ‘core-updates’.

Note that a few packages did that by hand.  While you’re at it, you
can adjust them.

Thanks!

Ludo’.
Marius Bakke Nov. 26, 2016, 8:11 a.m. UTC | #2
Ludovic Courtès <ludo@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> * guix/build/gnu-build-system.scm (strip)[strip-dir]: Change mode of
>> files before running strip-command.
>
> OK for ‘core-updates’.

Cool, pushed!

> Note that a few packages did that by hand.  While you’re at it, you
> can adjust them.

That was the motivation. I will submit a patch removing most users
after next master merge.
diff mbox

Patch

diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm
index 1dfd854..59394c2 100644
--- a/guix/build/gnu-build-system.scm
+++ b/guix/build/gnu-build-system.scm
@@ -393,6 +393,8 @@  makefiles."
                      (or (elf-file? file) (ar-file? file))
                      (or (not debug-output)
                          (make-debug-file file))
+                     ;; Ensure libraries are writable.
+                     (chmod file #o755)
                      (zero? (apply system* strip-command
                                    (append strip-flags (list file))))
                      (or (not debug-output)