diff mbox

[1/3] gnu: connman: Use localstatedir outside of store.

Message ID 20161109212245.23531-1-sleep_walker@gnu.org
State New
Headers show

Commit Message

Tomáš Čech Nov. 9, 2016, 9:22 p.m. UTC
* gnu/packages/connman.scm (connman): Use localstatedir outside of store.
---
 gnu/packages/connman.scm | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ludovic Courtès Nov. 9, 2016, 10:25 p.m. UTC | #1
Tomáš Čech <sleep_walker@gnu.org> skribis:

> * gnu/packages/connman.scm (connman): Use localstatedir outside of store.

OK!
Efraim Flashner Nov. 10, 2016, 7:55 a.m. UTC | #2
On Wed, Nov 09, 2016 at 10:22:43PM +0100, Tomáš Čech wrote:
> * gnu/packages/connman.scm (connman): Use localstatedir outside of store.
> ---
>  gnu/packages/connman.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/connman.scm b/gnu/packages/connman.scm
> index cd0f6a9..7af20c9 100644
> --- a/gnu/packages/connman.scm
> +++ b/gnu/packages/connman.scm
> @@ -55,6 +55,9 @@
>               "--enable-vpnc"
>               "--enable-pptp"
>               "--enable-l2tp"
> +             ;; location for daemon state files and internal configuration
> +             ;; needs to be writeable
> +             "--localstatedir=/var"
>               (string-append
>                "--with-dbusconfdir=" (assoc-ref %outputs "out") "/etc")
>               (string-append
> -- 
> 2.10.2
> 
> 

Thanks for working on this! I always had a plan to come back to the
connman service and make sure that it really worked well but I just
hadn't had a chance to.
Hartmut Goebel Nov. 11, 2016, 2:38 p.m. UTC | #3
Am 10.11.2016 um 08:55 schrieb Efraim Flashner:
> > +             ;; location for daemon state files and internal configuration
> > +             ;; needs to be writeable

I wonder if this shouldn't be the default for gnu-build-system?
Ludovic Courtès Nov. 12, 2016, 11:27 a.m. UTC | #4
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 10.11.2016 um 08:55 schrieb Efraim Flashner:
>> > +             ;; location for daemon state files and internal configuration
>> > +             ;; needs to be writeable
>
> I wonder if this shouldn't be the default for gnu-build-system?

It is tempting, yes.

However, I suspect a number of packages would gratuitously fail upon
‘make install’ simply because they’d do “mkdir /var” for no good reason.

Would be worth trying.

Ludo’.
diff mbox

Patch

diff --git a/gnu/packages/connman.scm b/gnu/packages/connman.scm
index cd0f6a9..7af20c9 100644
--- a/gnu/packages/connman.scm
+++ b/gnu/packages/connman.scm
@@ -55,6 +55,9 @@ 
              "--enable-vpnc"
              "--enable-pptp"
              "--enable-l2tp"
+             ;; location for daemon state files and internal configuration
+             ;; needs to be writeable
+             "--localstatedir=/var"
              (string-append
               "--with-dbusconfdir=" (assoc-ref %outputs "out") "/etc")
              (string-append