diff mbox

gnu: Replace python-pep8 by python-pycodestyle.

Message ID 20161107213950.24461-1-dannym@scratchpost.org
State New
Headers show

Commit Message

Danny Milosavljevic Nov. 7, 2016, 9:39 p.m. UTC
* gnu/packages/python.scm (python-pep8, python2-pep8):
  Add replacement.
---
 gnu/packages/python.scm | 1 +
 1 file changed, 1 insertion(+)

Comments

Leo Famulari Nov. 7, 2016, 10:30 p.m. UTC | #1
On Mon, Nov 07, 2016 at 10:39:50PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-pep8, python2-pep8):
>   Add replacement.
> ---
>  gnu/packages/python.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5b5287e..c6ec6d3 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5645,6 +5645,7 @@ applications.")
>  (define-public python-pep8
>    (package
>      (name "python-pep8")
> +    (replacement python-pycodestyle)

The grafted replacement system is for packages that have the same binary
interface, and should be used when we must change a package *now* but it
would otherwise require a huge number of rebuilds. That is, for security
updates to core packages.

There aren't very many packages using python-pep8 and python2-pep8, so
we should just make them all use this new package that supersedes
python-pep8.
Marius Bakke Nov. 7, 2016, 10:40 p.m. UTC | #2
Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-pep8, python2-pep8):
>   Add replacement.
> ---
>  gnu/packages/python.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5b5287e..c6ec6d3 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5645,6 +5645,7 @@ applications.")
>  (define-public python-pep8
>    (package
>      (name "python-pep8")
> +    (replacement python-pycodestyle)

This will graft python-pycodestyle in place of python-pep8. Are they
fully API compatible?

I think grafting is something that should be reserved for critical
problems affecting a large number of packages, e.g. security fixes for
central libraries. Since there are only 10 direct dependents of pep8
according to `guix refresh -l` (21 rebuilds in total), a "megapatch"
replacing all inputs should be okay.

We should probably also add a "superseded" property to the pep8 package
so any downstream users gets the message.
diff mbox

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5b5287e..c6ec6d3 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5645,6 +5645,7 @@  applications.")
 (define-public python-pep8
   (package
     (name "python-pep8")
+    (replacement python-pycodestyle)
     (version "1.7.0")
     (source
       (origin