diff mbox

[2/2] gnu: Add python-axolotl.

Message ID 20161019141849.4450-2-arunisaac@systemreboot.net
State New
Headers show

Commit Message

Arun Oct. 19, 2016, 2:18 p.m. UTC
* gnu/packages/python.scm (python-axolotl, python2-axolotl): New variables.
---
 gnu/packages/python.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

Comments

Hartmut Goebel Oct. 19, 2016, 2:52 p.m. UTC | #1
Am 19.10.2016 um 16:18 schrieb Arun Isaac:
> +    (inputs
> +     `(("python-axolotl-curve25519" ,python-axolotl-curve25519)
> +       ("python-dateutil" ,python-dateutil)
> +       ("python-protobuf" ,python-protobuf)
> +       ("python-pycrypto" ,python-pycrypto)))

These must all be propagated-inputs.

The code includes tests in axolotl/tests/ (and maybe elsewhere. Please
check if these are installed and if so, if they can be safely removed.

> +    (description "This is a python port of libaxolotl-android
> +originally written by Moxie Marlinspike.  This is a ratcheting forward

Isn't this "python implementation of the axolotl protocol"? Oh, I just
checked the code: It's as ugly as Java code is. So "python port of
libaxolotl-android" is correct.

Did this Moxie Marlinspike write the python port or just the
"libaxolotl-android"? In any case, persons should not be  glamorized in
descriptions. We also do not write "PGP originally developed by Phill
Zimmerman". This only leads to personality cult - and esp. this person
is very debatable.
Arun Oct. 20, 2016, 9:33 a.m. UTC | #2
Hartmut Goebel writes:

> These must all be propagated-inputs.

Sure.

> The code includes tests in axolotl/tests/ (and maybe elsewhere. Please
> check if these are installed and if so, if they can be safely removed.

Yes, the tests were installed. I removed them, and as far as I can tell,
it seems to work fine.

> Did this Moxie Marlinspike write the python port or just the
> "libaxolotl-android"? In any case, persons should not be  glamorized in
> descriptions. We also do not write "PGP originally developed by Phill
> Zimmerman". This only leads to personality cult - and esp. this person
> is very debatable.

Sure.

I'll send an updated patch soon.
diff mbox

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 326b2dd..f0df817 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -79,6 +79,7 @@ 
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages statistics)
@@ -11091,3 +11092,39 @@  python-axolotl.")
 
 (define-public python2-axolotl-curve25519
   (package-with-python2 python-axolotl-curve25519))
+
+(define-public python-axolotl
+  (package
+    (name "python-axolotl")
+    (version "0.1.35")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/tgalal/python-axolotl/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "1z8d89p7v40p4bwywjm9h4z28fdvra79ddw06azlkrfjbl7dxmz8"))))
+    (build-system python-build-system)
+    (arguments
+     `(;; Prevent creation of the egg. This works around
+       ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765
+       #:configure-flags '("--root=/")))
+    (inputs
+     `(("python-axolotl-curve25519" ,python-axolotl-curve25519)
+       ("python-dateutil" ,python-dateutil)
+       ("python-protobuf" ,python-protobuf)
+       ("python-pycrypto" ,python-pycrypto)))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page "https://github.com/tgalal/python-axolotl")
+    (synopsis "Python port of libaxolotl-android")
+    (description "This is a python port of libaxolotl-android
+originally written by Moxie Marlinspike.  This is a ratcheting forward
+secrecy protocol that works in synchronous and asynchronous messaging
+environments.")
+    (license license:gpl3)))
+
+(define-public python2-axolotl
+  (package-with-python2 python-axolotl))