diff mbox

gnu: tor: Recommend torsocks.

Message ID 20161018233949.22799-2-ng0@we.make.ritual.n0.is
State New
Headers show

Commit Message

non such Oct. 18, 2016, 11:39 p.m. UTC
* gnu/packages/tor.scm (tor)[description]: Recommend torsocks.
---
 gnu/packages/tor.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

ng0 Dec. 15, 2016, 10:37 a.m. UTC | #1
Hi, I see this received no feedback so far. Can someone review
this? Or is it already on someones list?

Thanks.

ng0 <ng0@we.make.ritual.n0.is> writes:

> * gnu/packages/tor.scm (tor)[description]: Recommend torsocks.
> ---
>  gnu/packages/tor.scm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
> index e6fbf6e..f0970ef 100644
> --- a/gnu/packages/tor.scm
> +++ b/gnu/packages/tor.scm
> @@ -54,9 +54,6 @@
>       `(("zlib" ,zlib)
>         ("openssl" ,openssl)
>         ("libevent" ,libevent)))
> -
> -    ;; TODO: Recommend `torsocks' since `torify' needs it.
> -
>      (home-page "https://www.torproject.org/")
>      (synopsis "Anonymous network router to improve privacy on the Internet")
>      (description
> @@ -66,7 +63,11 @@ somebody watching your Internet connection from learning what sites you
>  visit, and it prevents the sites you visit from learning your physical
>  location.  Tor works with many of your existing applications, including
>  web browsers, instant messaging clients, remote login, and other
> -applications based on the TCP protocol.")
> +applications based on the TCP protocol.
> +To @code{torify} applications (to take measures to ensure that an application,
> +which has not been designed for use with Tor such as ssh, will use only Tor for
> +internet connectivity, and also ensures that there are no leaks from DNS, UDP or
> +the application layer) you need to install @code{torsocks}.")
>      (license bsd-3)))
>  
>  (define-public torsocks
> -- 
> 2.10.1
>
>
Kei Yamashita Dec. 15, 2016, 4:44 p.m. UTC | #2
ng0 <ng0@libertad.pw> writes:

> Hi, I see this received no feedback so far. Can someone review
> this? Or is it already on someones list?
>
> Thanks.
>
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> * gnu/packages/tor.scm (tor)[description]: Recommend torsocks.
>> ---
>>  gnu/packages/tor.scm | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
>> index e6fbf6e..f0970ef 100644
>> --- a/gnu/packages/tor.scm
>> +++ b/gnu/packages/tor.scm
>> @@ -54,9 +54,6 @@
>>       `(("zlib" ,zlib)
>>         ("openssl" ,openssl)
>>         ("libevent" ,libevent)))
>> -
>> -    ;; TODO: Recommend `torsocks' since `torify' needs it.
>> -
>>      (home-page "https://www.torproject.org/")
>>      (synopsis "Anonymous network router to improve privacy on the Internet")
>>      (description
>> @@ -66,7 +63,11 @@ somebody watching your Internet connection from learning what sites you
>>  visit, and it prevents the sites you visit from learning your physical
>>  location.  Tor works with many of your existing applications, including
>>  web browsers, instant messaging clients, remote login, and other
>> -applications based on the TCP protocol.")
>> +applications based on the TCP protocol.
>> +To @code{torify} applications (to take measures to ensure that an application,
>> +which has not been designed for use with Tor such as ssh, will use only Tor for
>> +internet connectivity, and also ensures that there are no leaks from DNS, UDP or
>> +the application layer) you need to install @code{torsocks}.")
>>      (license bsd-3)))
>>  
>>  (define-public torsocks
>> -- 
>> 2.10.1
>>
>>

LGTM. :)
Kei Yamashita Dec. 16, 2016, 3:50 p.m. UTC | #3
Kei Kebreau <kei@openmailbox.org> writes:

> ng0 <ng0@libertad.pw> writes:
>
>> Hi, I see this received no feedback so far. Can someone review
>> this? Or is it already on someones list?
>>
>> Thanks.
>>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> * gnu/packages/tor.scm (tor)[description]: Recommend torsocks.
>>> ---
>>>  gnu/packages/tor.scm | 9 +++++----
>>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
>>> index e6fbf6e..f0970ef 100644
>>> --- a/gnu/packages/tor.scm
>>> +++ b/gnu/packages/tor.scm
>>> @@ -54,9 +54,6 @@
>>>       `(("zlib" ,zlib)
>>>         ("openssl" ,openssl)
>>>         ("libevent" ,libevent)))
>>> -
>>> -    ;; TODO: Recommend `torsocks' since `torify' needs it.
>>> -
>>>      (home-page "https://www.torproject.org/")
>>>      (synopsis "Anonymous network router to improve privacy on the Internet")
>>>      (description
>>> @@ -66,7 +63,11 @@ somebody watching your Internet connection from learning what sites you
>>>  visit, and it prevents the sites you visit from learning your physical
>>>  location.  Tor works with many of your existing applications, including
>>>  web browsers, instant messaging clients, remote login, and other
>>> -applications based on the TCP protocol.")
>>> +applications based on the TCP protocol.
>>> +To @code{torify} applications (to take measures to ensure that an application,
>>> +which has not been designed for use with Tor such as ssh, will use only Tor for
>>> +internet connectivity, and also ensures that there are no leaks from DNS, UDP or
>>> +the application layer) you need to install @code{torsocks}.")
>>>      (license bsd-3)))
>>>  
>>>  (define-public torsocks
>>> -- 
>>> 2.10.1
>>>
>>>
>
> LGTM. :)

Seeing no protest, this was pushed as fc9286d03a79837d70d8f209521d73f6b18d171b.
Hartmut Goebel Dec. 16, 2016, 9:33 p.m. UTC | #4
Am 15.12.2016 um 11:37 schrieb ng0:
> -applications based on the TCP protocol.")
> +applications based on the TCP protocol.
> +To @code{torify} applications (to take measures to ensure that an application,
> +which has not been designed for use with Tor such as ssh, will use only Tor for

Even if his is already pushed: An empty line for making the new text
another paragraph would be fine.
Kei Yamashita Dec. 17, 2016, 5:34 p.m. UTC | #5
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Am 15.12.2016 um 11:37 schrieb ng0:
>> -applications based on the TCP protocol.")
>> +applications based on the TCP protocol.
>> +To @code{torify} applications (to take measures to ensure that an
>> application,
>> +which has not been designed for use with Tor such as ssh, will use
>> only Tor for
>
> Even if his is already pushed: An empty line for making the new text
> another paragraph would be fine.

I agree; that change would make it more readable. I'll commit it at my
soonest oppurtunity provided someone doesn't beat me to it. Thanks, Hartmut.
diff mbox

Patch

diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
index e6fbf6e..f0970ef 100644
--- a/gnu/packages/tor.scm
+++ b/gnu/packages/tor.scm
@@ -54,9 +54,6 @@ 
      `(("zlib" ,zlib)
        ("openssl" ,openssl)
        ("libevent" ,libevent)))
-
-    ;; TODO: Recommend `torsocks' since `torify' needs it.
-
     (home-page "https://www.torproject.org/")
     (synopsis "Anonymous network router to improve privacy on the Internet")
     (description
@@ -66,7 +63,11 @@  somebody watching your Internet connection from learning what sites you
 visit, and it prevents the sites you visit from learning your physical
 location.  Tor works with many of your existing applications, including
 web browsers, instant messaging clients, remote login, and other
-applications based on the TCP protocol.")
+applications based on the TCP protocol.
+To @code{torify} applications (to take measures to ensure that an application,
+which has not been designed for use with Tor such as ssh, will use only Tor for
+internet connectivity, and also ensures that there are no leaks from DNS, UDP or
+the application layer) you need to install @code{torsocks}.")
     (license bsd-3)))
 
 (define-public torsocks