diff mbox

[2/5] gnu: Add python-sphinx-cloud-sptheme.

Message ID 20161007103250.24046-3-dannym@scratchpost.org
State New
Headers show

Commit Message

Danny Milosavljevic Oct. 7, 2016, 10:32 a.m. UTC
* gnu/packages/python.scm (python-sphinx-cloud-sptheme): New variable.
---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Hartmut Goebel Oct. 7, 2016, 10:58 a.m. UTC | #1
Am 07.10.2016 um 12:32 schrieb Danny Milosavljevic:
> +  (inputs
> +    `(("python-sphinx" ,python-sphinx)))

Even if this is listed as requirement, I would not add it here. This is
a theme, say an add-on for sphinx, thus I would sphinx to be installed
anyway. python-sphinx-alabaster-theme is a theme too, but does not
require sphinx (and can not, otherwise it would be circular).)

> +  (native-inputs
> +    `(("python-docutils" ,python-docutils)

Not required by this package, it is already provided by sphinx.

> +      ("python-snowballstemmer" ,python-snowballstemmer)))

I can't find snowballstemmer  in the code.
Danny Milosavljevic Oct. 7, 2016, 1:28 p.m. UTC | #2
Hi,

thanks for the review!

On Fri, 7 Oct 2016 12:58:51 +0200
Hartmut Goebel <h.goebel@goebel-consult.de> wrote:
> I can't find snowballstemmer  in the code.

PATCH 1/5
Hartmut Goebel Oct. 7, 2016, 1:48 p.m. UTC | #3
Am 07.10.2016 um 15:28 schrieb Danny Milosavljevic:
> Hi,
>
> thanks for the review!
>
> On Fri, 7 Oct 2016 12:58:51 +0200
> Hartmut Goebel <h.goebel@goebel-consult.de> wrote:
>> I can't find snowballstemmer  in the code.
> PATCH 1/5
>

Sorry, seams I've been too terse.

snowballstemmer is not listed as an requirement for cloud_sptheme, neither in setup.py, nor elsewhere. I did not even find this anywhere in the source.
Danny Milosavljevic Oct. 7, 2016, 2:58 p.m. UTC | #4
On Fri, 7 Oct 2016 12:58:51 +0200
Hartmut Goebel <h.goebel@goebel-consult.de> wrote:

> Am 07.10.2016 um 12:32 schrieb Danny Milosavljevic:
> > +  (inputs
> > +    `(("python-sphinx" ,python-sphinx)))  
> 
> Even if this is listed as requirement, I would not add it here. 

When I remove it the tests fail.

running test
Searching for sphinx>=1.2
Reading https://pypi.python.org/simple/sphinx/
Download error on https://pypi.python.org/simple/sphinx/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'sphinx' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or download links found for sphinx>=1.2
error: Could not find suitable distribution for Requirement.parse('sphinx>=1.2')
phase `check' failed after 1.1 seconds
builder for `/gnu/store/55ip9808y416r0rjmvqm53paybwfkksp-python-sphix-cloud-sptheme-1.7.1.drv' failed with exit code 1
diff mbox

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d8cb7d1..73f0c05 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -11014,3 +11014,29 @@  focus on building massively scalable web applications.")
       "This package provides 16 stemmer algorithms (15 + Poerter English
 stemmer) generated from Snowball algorithms.")
     (license license:bsd-3)))
+
+(define-public python-sphinx-cloud-sptheme
+  (package
+    (name "python-sphix-cloud-sptheme")
+    (version "1.7.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "cloud_sptheme" version))
+        (sha256
+          (base32
+            "0zm9ap4p5dzln8f1m2immadaxv2xpg8jg4w53y52rhfl7pdb58vy"))))
+  (build-system python-build-system)
+  (inputs
+    `(("python-sphinx" ,python-sphinx)))
+  (native-inputs
+    `(("python-docutils" ,python-docutils)
+      ("python-snowballstemmer" ,python-snowballstemmer)))
+  (home-page
+    "https://bitbucket.org/ecollins/cloud_sptheme")
+  (synopsis
+    "'Cloud' theme for Sphinx documenter")
+  (description
+    "This package contains the 'Cloud' theme for Sphinx and some
+related extensions.")
+  (license license:bsd-3)))