diff mbox

Add gctp

Message ID 20160915.190808.526226800252619989.thomas.danckaert@gmail.com
State New
Headers show

Commit Message

Thomas Danckaert Sept. 15, 2016, 5:08 p.m. UTC
Hi Guix,

I've cleaned up my gctp patch, following your advice:

From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add gctp
Date: Mon, 18 Jul 2016 17:47:23 -0400

> If it's not possible to use the bundled GCTPs then we have to use an
> external library, but I think it should be maintained outside of 
> Guix.
> As you say, it should not be much work to put it on a public Git 
> repo or
> to host a tarball, since the development is basically complete.

I took the contents of the gctpc20.tar.Z archive distributed with 
wgrib2, added an autoconf-based build script, and published the 
repository on Github.  Changes are minor: I had to make some changes 
to the test programs, and fix one input routine (int size mismatch 
when reading an auxiliary binary file).

This version of the patch uses a release tarball published on github. 
 Is there a better place I can host a tarball (if not the repository 
itself?).

best,

Thomas

Comments

Leo Famulari Sept. 24, 2016, 1:08 a.m. UTC | #1
On Thu, Sep 15, 2016 at 07:08:08PM +0200, Thomas Danckaert wrote:
> Hi Guix,
> 
> I've cleaned up my gctp patch, following your advice:
> 
> From: Leo Famulari <leo@famulari.name>
> Subject: Re: [PATCH] Add gctp
> Date: Mon, 18 Jul 2016 17:47:23 -0400
> 
> > If it's not possible to use the bundled GCTPs then we have to use an
> > external library, but I think it should be maintained outside of Guix.
> > As you say, it should not be much work to put it on a public Git repo or
> > to host a tarball, since the development is basically complete.
> 
> I took the contents of the gctpc20.tar.Z archive distributed with wgrib2,
> added an autoconf-based build script, and published the repository on
> Github.  Changes are minor: I had to make some changes to the test programs,
> and fix one input routine (int size mismatch when reading an auxiliary
> binary file).
> 
> This version of the patch uses a release tarball published on github. Is
> there a better place I can host a tarball (if not the repository itself?).

Wow, thank you! A GitHub tarball is fine if it works (and this one
does).

> +    (version "2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")

The only thing I would like to change is this mismatch between the
version and the tarball name. Can we call it version 2.0.0?

Also, we should add a (file-name) field so that the downloaded tarball
has "gctp" in the name.

I can make these changes locally if you think they are okay.
Thomas Danckaert Sept. 24, 2016, 7:49 p.m. UTC | #2
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add gctp
Date: Fri, 23 Sep 2016 21:08:25 -0400

>> +    (version "2.0")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
> 
> The only thing I would like to change is this mismatch between the
> version and the tarball name. Can we call it version 2.0.0?
> 
> Also, we should add a (file-name) field so that the downloaded tarball
> has "gctp" in the name.
> 
> I can make these changes locally if you think they are okay.

Of course, go ahead!

Thanks for reviewing the patch(-es).

Thomas
Leo Famulari Sept. 27, 2016, 5:38 p.m. UTC | #3
On Sat, Sep 24, 2016 at 09:49:56PM +0200, Thomas Danckaert wrote:
> From: Leo Famulari <leo@famulari.name>
> Subject: Re: [PATCH] Add gctp
> Date: Fri, 23 Sep 2016 21:08:25 -0400
> 
> >> +    (version "2.0")
> >> +    (source
> >> +     (origin
> >> +       (method url-fetch)
> >> +       (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
> > 
> > The only thing I would like to change is this mismatch between the
> > version and the tarball name. Can we call it version 2.0.0?
> > 
> > Also, we should add a (file-name) field so that the downloaded tarball
> > has "gctp" in the name.
> > 
> > I can make these changes locally if you think they are okay.
> 
> Of course, go ahead!
> 
> Thanks for reviewing the patch(-es).

Great, pushed as 32f70e1f86141ed30f1026ea0cf8a4bd377004b0 !

> 
> Thomas
diff mbox

Patch

From 442f902377c95d72b59d2311c78df2d403f02ea4 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Fri, 17 Jun 2016 10:41:50 +0200
Subject: [PATCH] gnu: Add gctp.

* gnu/packages/maths.cm (gctp): New variable.
---
 gnu/packages/maths.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 44a24ef..e275436 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -418,6 +418,30 @@  plotting engine by third-party applications like Octave.")
       (license (license:fsf-free
                 "http://gnuplot.cvs.sourceforge.net/gnuplot/gnuplot/Copyright")))))
 
+(define-public gctp
+  (package
+    (name "gctp")
+    (version "2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
+       (sha256
+        (base32
+         "0l9aqnqynh9laicn5dxf3rsb1n14xiks79wbyqccirzmjqd1c1x4"))))
+    (native-inputs
+     `(("fortran" ,gfortran)))
+    (build-system gnu-build-system)
+    (synopsis "General Cartographic Transformation Package (GCTP)")
+    (description
+     "The General Cartographic Transformation Package (GCTP) is a system of
+software routines designed to permit the transformation of coordinate pairs
+from one map projection to another.  The GCTP is the standard computer
+software used by the National Mapping Division for map projection
+computations.")
+    (home-page "https://github.com/OkoSanto/GCTP")
+    (license 'license:public-domain))) ; https://www2.usgs.gov/laws/info_policies.html
+
 (define-public hdf5
   (package
     (name "hdf5")
-- 
2.10.0