gnu: Simplify dtc package definition.

---
 gnu/packages/u-boot.scm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

LGTM. Are these changes part of the debian patchset?

Hi David,

On Wed, 7 Sep 2016 10:15:29 +0200
David Craven <david@craven.ch> wrote:

> LGTM. Are these changes part of the debian patchset?

No, I found out that GNU make allows you to override variables used inside Makefiles from make's command line.

To test:

write a Makefile containing:

#-----
PREFIX = /foo

all:
	echo $(PREFIX)
#-----

Then try

$ make PREFIX=/bar

.

It will override the variable.

Why aren't you using git format-patch? :)

git format-patch -1
git send-email *.patch --to guix-devel@gnu.org

is what I do...

From what I can tell you are doing git diff > file.patch?

Hi David,

On Thu, 8 Sep 2016 17:09:12 +0200
David Craven <david@craven.ch> wrote:

> Why aren't you using git format-patch? :)
> 
> git format-patch -1
> git send-email *.patch --to guix-devel@gnu.org
> 
> is what I do...

That's exactly what I do too - the exact same commands. I don't know what magical options other people use but that's how it always comes out for me. I usually manually copy&paste the subject back down into the body - but this time I forgot. Regardless, that was a bona fide git format-patch AND git send-email E-Mail.

On the other hand, Linux people also told me about my git format-patch settings being "wrong" - and indeed they are different than the ones I use to submit to Guix.

What are the settings you use / we should use?

Mine are:
 
$ git config --global -l |grep ^format
format.subjectprefix=FIXME
format.numbered=auto
format.signoff=false
format.coverletter=auto
format.signature=
format.attach=

And the git-format-patch executable is built from GuixSD svn master hydra from a few days ago...

Hi Danny,

I don't have any special settings configured, just the default.

Your patches are missing a header like this one:

From fc0e6e2ae96b0586035de96c65cfd08186ceb28a Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Wed, 7 Sep 2016 21:02:28 +0300
Subject: [PATCH] gnu: lightweight-desktop.tmpl: Fix typo.

* gnu/system/examples/lightweight-desktop.tmpl: While it is currently
unknown if Bob has a brother, it is sufficiently documented that Alice
is, in fact, Bob's sister.
---
 gnu/system/examples/lightweight-desktop.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does `git format-patch -1 && git checkout HEAD~ && git am *.patch` work for you?

On Thu, Sep 08, 2016 at 08:45:26PM +0200, David Craven wrote:
> Hi Danny,
> 
> I don't have any special settings configured, just the default.
> 
> Your patches are missing a header like this one:
> 
> From fc0e6e2ae96b0586035de96c65cfd08186ceb28a Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Wed, 7 Sep 2016 21:02:28 +0300
> Subject: [PATCH] gnu: lightweight-desktop.tmpl: Fix typo.

Danny's message was not missing the header. You should use `git am` to
apply the email itself.

> Danny's message was not missing the header. You should use `git am` to
> apply the email itself.

@leo
Ah, that explains it. Thanks!

@danny
sorry