diff mbox

[08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

Message ID 20160801181342.16203-9-david@craven.ch
State New
Headers show

Commit Message

David Craven Aug. 1, 2016, 6:13 p.m. UTC
* gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
---
 gnu/packages/kde-frameworks.scm | 2 --
 1 file changed, 2 deletions(-)

Comments

Andreas Enge Aug. 1, 2016, 7:57 p.m. UTC | #1
On Mon, Aug 01, 2016 at 08:13:19PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.

Should we not keep it? From what I understand, all of KDE, or at least
the framework, seems to move in unison. So keeping a unique global variable
would making the update a bit easier.

On the other hand, one would still need to update the hashes by hand. So
maybe having the updater you propose in another patch will actually be
a better solution.

Comments?

I will not have a look at the updater and the linter (which looks like a
good idea), since I have no expertise in this area.

Andreas
Andreas Enge Aug. 1, 2016, 7:58 p.m. UTC | #2
On Mon, Aug 01, 2016 at 08:13:19PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.

PS: If you delete the variable, I would do this first and replace its use
by the current value in the two (?) packages using it so far, and after that
update the packages to their latest versions.
David Craven Aug. 1, 2016, 8 p.m. UTC | #3
I thought it would be easier to update, since we prefer each update to
be a commit. If we change the version for all packages at the same
time we could have breakage until they are all updated. With the
auto-updater this doesn't require any manual labor at all.
Andreas Enge Aug. 1, 2016, 9:17 p.m. UTC | #4
On Mon, Aug 01, 2016 at 10:00:34PM +0200, David Craven wrote:
> I thought it would be easier to update, since we prefer each update to
> be a commit. If we change the version for all packages at the same
> time we could have breakage until they are all updated. With the
> auto-updater this doesn't require any manual labor at all.

Well, I am fine with auto-updating also. I think in this case both are
valid, since one will probably update everything at the same time for KDE.

Andreas
David Craven Aug. 2, 2016, 11:55 a.m. UTC | #5
> PS: If you delete the variable, I would do this first and replace its use
by the current value in the two (?) packages using it so far, and after that
update the packages to their latest versions.

I pushed the first 5 commits until and including this one here.

Ups I just realized I made a mistake on this commit.
Ludovic Courtès Aug. 2, 2016, 12:33 p.m. UTC | #6
David Craven <david@craven.ch> skribis:

> * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.

Commit d26e2b9f306a1170d46f7c860c81840d9d600161 introduced breakage:
‘make’ would fail due to the unbound variable.  I fixed it in
47e2fe3cdf0ecfcfc6dccc048d4b1da94fa5a4a2.

Ludo’.
diff mbox

Patch

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 12d9f16..db20690 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -27,8 +27,6 @@ 
   #:use-module (gnu packages qt)
   #:use-module (gnu packages xorg))
 
-(define kde-frameworks-version "5.21.0")
-
 (define-public extra-cmake-modules
   (package
     (name "extra-cmake-modules")