diff mbox

[v4,15/16] gnu: Add perl-mail-spf.

Message ID 20160728132203.130a99da@scratchpost.org
State New
Headers show

Commit Message

Danny Milosavljevic July 28, 2016, 11:22 a.m. UTC
gnu: Add perl-mail-spf.

* gnu/package/mail.scm (perl-mail-spf): New variable.
---
 gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

Comments

non such July 28, 2016, 7:55 p.m. UTC | #1
This one lacks the bsd-3 in the licenses in the header of mail.scm. I
fixed this locally for now as I'm new to reviewing 16 dependent patches.

I also got this message while running make on the root of guix checkout:
gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'


Unrelated, but coming up in the dependency graph:
We need to update perl-devel-symdump to 2.17.

A general fyi which I will open as a bug later:
output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
differs from previous round
@ build-failed
/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv
- 1 output
‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
differs from previous round
cannot build derivation
`/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv':
1 dependencies couldn't be built
guix build: error: build failed: build of
`/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv'
failed

gnu/packages/mail.scm needs #:use-modules (gnu packages networking)

and then:

gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'

Possibly caused by some other file already loading perl.scm module.

I can not comment on further changes, and I'd rather like to have
someone with more perl knowledge review this.

Danny Milosavljevic <dannym@scratchpost.org> writes:

> gnu: Add perl-mail-spf.
>
> * gnu/package/mail.scm (perl-mail-spf): New variable.
> ---
>  gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index f7a7623..4169464 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -1262,3 +1262,44 @@ synchronizing with a remote address book, @command{vdirsyncer} is recommended.
>  Khard can also be used from within the email client @command{mutt}.")
>      (home-page "https://github.com/scheibler/khard")
>      (license gpl3+)))
> +
> +(define-public perl-mail-spf
> + (package
> +  (name "perl-mail-spf")
> +  (version "v2.9.0")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/J/JM/JMEHNLE/mail-spf/Mail-SPF-"
> +             version
> +             ".tar.gz"))
> +      (sha256
> +        (base32
> +          "0qk1rfgfm5drj4iyniiabrasrpqv570vzhgz66lwgb67y4amkjv1"))))
> +  (build-system perl-build-system)
> +  (native-inputs
> +    `(("perl-module-build" ,perl-module-build)
> +      ("perl-net-dns-resolver-programmable"
> +       ,perl-net-dns-resolver-programmable)))
> +  (arguments
> +   `(#:phases (modify-phases %standard-phases
> +       (add-before 'configure 'modify-Build.PL
> +         (lambda* (#:key outputs #:allow-other-keys)
> +           (substitute* "Build.PL"
> +             (("'/usr/sbin'") (string-append "'"
> +                                             (assoc-ref outputs "out")
> +                                             "/sbin'")))
> +             #t)))))
> +  (inputs
> +    `(("perl-error" ,perl-error)
> +      ("perl-net-dns" ,perl-net-dns)
> +      ("perl-netaddr-ip" ,perl-netaddr-ip)
> +      ("perl-uri" ,perl-uri)))
> +  (home-page
> +    "http://search.cpan.org/dist/Mail-SPF")
> +  (synopsis
> +    "Perl implementation of Sender Policy Framework")
> +  (description "Mail::SPF is the Sender Policy Framework implemented
> +in Perl.")
> +  (license bsd-3)))
>
Danny Milosavljevic July 28, 2016, 8:54 p.m. UTC | #2
On Thu, 28 Jul 2016 19:55:39 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
> 
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'

Yes, I forgot to include this one (sorry). I'm new to huge patch series like this too...

I can add it in v5.

> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
> 
> Possibly caused by some other file already loading perl.scm module.

No, because perl-uri is in web.scm . 
mail.scm should import web.scm . I forgot that as well.

So - to summarize - the header of mail.scm should also:
- add bsd-3 license
- import web.scm
non such July 29, 2016, 11:03 a.m. UTC | #3
ng0 <ng0@we.make.ritual.n0.is> writes:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
>
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'
>
>
> Unrelated, but coming up in the dependency graph:
> We need to update perl-devel-symdump to 2.17.

Done.

> A general fyi which I will open as a bug later:
> output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
> ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
> differs from previous round
> @ build-failed
> /gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv
> - 1 output
> ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
> ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
> differs from previous round
> cannot build derivation
> `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv':
> 1 dependencies couldn't be built
> guix build: error: build failed: build of
> `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv'
> failed

This needs no bugreport if it was perl-devel-symdump. I just ran
`guix build rounds=2 perl-devel-symdump' and it was okay.

> gnu/packages/mail.scm needs #:use-modules (gnu packages networking)
>
> and then:
>
> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
>
> Possibly caused by some other file already loading perl.scm module.
>
> I can not comment on further changes, and I'd rather like to have
> someone with more perl knowledge review this.
>
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> gnu: Add perl-mail-spf.
>>
>> * gnu/package/mail.scm (perl-mail-spf): New variable.
>> ---
diff mbox

Patch

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index f7a7623..4169464 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1262,3 +1262,44 @@  synchronizing with a remote address book, @command{vdirsyncer} is recommended.
 Khard can also be used from within the email client @command{mutt}.")
     (home-page "https://github.com/scheibler/khard")
     (license gpl3+)))
+
+(define-public perl-mail-spf
+ (package
+  (name "perl-mail-spf")
+  (version "v2.9.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/J/JM/JMEHNLE/mail-spf/Mail-SPF-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0qk1rfgfm5drj4iyniiabrasrpqv570vzhgz66lwgb67y4amkjv1"))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)
+      ("perl-net-dns-resolver-programmable"
+       ,perl-net-dns-resolver-programmable)))
+  (arguments
+   `(#:phases (modify-phases %standard-phases
+       (add-before 'configure 'modify-Build.PL
+         (lambda* (#:key outputs #:allow-other-keys)
+           (substitute* "Build.PL"
+             (("'/usr/sbin'") (string-append "'"
+                                             (assoc-ref outputs "out")
+                                             "/sbin'")))
+             #t)))))
+  (inputs
+    `(("perl-error" ,perl-error)
+      ("perl-net-dns" ,perl-net-dns)
+      ("perl-netaddr-ip" ,perl-netaddr-ip)
+      ("perl-uri" ,perl-uri)))
+  (home-page
+    "http://search.cpan.org/dist/Mail-SPF")
+  (synopsis
+    "Perl implementation of Sender Policy Framework")
+  (description "Mail::SPF is the Sender Policy Framework implemented
+in Perl.")
+  (license bsd-3)))