diff mbox

[01/10] system: Do not export GST_PLUGIN_PATH in /etc/profile.

Message ID 20160718165552.1480-1-david@craven.ch
State New
Headers show

Commit Message

David Craven July 18, 2016, 4:55 p.m. UTC
* gnu/system.scm (operating-system-etc-service): Remove "export" for
'GST_PLUGIN_PATH'.
---
 gnu/system.scm | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andy Wingo July 21, 2016, 10:15 a.m. UTC | #1
On Mon 18 Jul 2016 18:55, David Craven <david@craven.ch> writes:

> * gnu/system.scm (operating-system-etc-service): Remove "export" for
> 'GST_PLUGIN_PATH'.
> ---
>  gnu/system.scm | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index 476720b..fe62c3e 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -433,9 +433,6 @@ fi
>  # See <http://bugs.gnu.org/22650>.
>  umask 022
>  
> -# Allow GStreamer-based applications to find plugins.
> -export GST_PLUGIN_PATH=\"$HOME/.guix-profile/lib/gstreamer-1.0\"
> -
>  if [ -n \"$BASH_VERSION\" -a -f /etc/bashrc ]
>  then
>    # Load Bash-specific initialization code.

What is the impact of this change on users?

Will it still be possible to install rhythmbox, then some GStreamer
plugins, and have rhythmbox recognize those plugins?

Andy
David Craven July 21, 2016, 11:17 a.m. UTC | #2
> What is the impact of this change on users?
>
> Will it still be possible to install rhythmbox, then some GStreamer
> plugins, and have rhythmbox recognize those plugins?

I think that to do that you'd create a custom package called my
rythmbox or something, declare rythmbox and the optional plugins as
dependencies and add a startup script that sets the correct
environment variables or something like that.
Vincent Legoll July 21, 2016, 11:41 a.m. UTC | #3
On Thu, Jul 21, 2016 at 1:17 PM, David Craven <david@craven.ch> wrote:
>> What is the impact of this change on users?
>>
>> Will it still be possible to install rhythmbox, then some GStreamer
>> plugins, and have rhythmbox recognize those plugins?
>
> I think that to do that you'd create a custom package called my
> rythmbox or something, declare rythmbox and the optional plugins as
> dependencies and add a startup script that sets the correct
> environment variables or something like that.

Why not simply move that variable declaration to the skeleton shell
init script that is copied into $HOME/.bashrc so that everything still
works properly without having to do anything ?
David Craven July 21, 2016, 11:57 a.m. UTC | #4
There are multiple solutions, I just think that this doesn't belong in
/etc/profile (or $HOME/.bashrc for that matter), since this leads to
an incomplete dependency specification.
diff mbox

Patch

diff --git a/gnu/system.scm b/gnu/system.scm
index 476720b..fe62c3e 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -433,9 +433,6 @@  fi
 # See <http://bugs.gnu.org/22650>.
 umask 022
 
-# Allow GStreamer-based applications to find plugins.
-export GST_PLUGIN_PATH=\"$HOME/.guix-profile/lib/gstreamer-1.0\"
-
 if [ -n \"$BASH_VERSION\" -a -f /etc/bashrc ]
 then
   # Load Bash-specific initialization code.