diff mbox

[3/3] gnu: Add perl-log-any-adapter-log4perl.

Message ID 20160716182009.23643-4-alex@pompo.co
State New
Headers show

Commit Message

Alex Sassmannshausen July 16, 2016, 6:20 p.m. UTC
* gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Ben Woodcroft July 17, 2016, 3:10 a.m. UTC | #1
On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)

This is both an input and a native-input - I imagine the former is best.

> +       ("perl-log-log4perl" ,perl-log-log4perl)))
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
> +    (synopsis "Log::Any adapter for Log::Log4perl")
> +    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
> +using Log::Log4perl for logging.  log4perl must be initialized before calling
> +set.  There are no parameters.")
> +    (license (package-license perl))))
> +
>   (define-public perl-log-log4perl
>     (package
>       (name "perl-log-log4perl")

OK.
Ricardo Wurmus July 17, 2016, 8:44 a.m. UTC | #2
Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:

> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>  mechanism.")
>      (license (package-license perl))))
>  
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)
> +       ("perl-log-log4perl" ,perl-log-log4perl)))

Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have
anything comparable to the RUNPATH feature, so inputs must be
propagated.

Have you tested using this module, e.g. in a container?

~~ Ricardo
diff mbox

Patch

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index fc63df3..1f18214 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@  whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-any-adapter-log4perl
+  (package
+    (name "perl-log-any-adapter-log4perl")
+    (version "0.08")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
+    (build-system perl-build-system)
+    (native-inputs `(("perl-log-any" ,perl-log-any)))
+    (inputs
+     `(("perl-log-any" ,perl-log-any)
+       ("perl-log-log4perl" ,perl-log-log4perl)))
+    (home-page
+     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
+    (synopsis "Log::Any adapter for Log::Log4perl")
+    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
+using Log::Log4perl for logging.  log4perl must be initialized before calling
+set.  There are no parameters.")
+    (license (package-license perl))))
+
 (define-public perl-log-log4perl
   (package
     (name "perl-log-log4perl")