diff mbox

[2/3] gnu: Add perl-log-log4perl.

Message ID 20160716182009.23643-3-alex@pompo.co
State New
Headers show

Commit Message

Alex Sassmannshausen July 16, 2016, 6:20 p.m. UTC
* gnu/packages/perl.scm (perl-log-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Ben Woodcroft July 17, 2016, 3:06 a.m. UTC | #1
On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 486dbc2..fc63df3 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-log4perl
> +  (package
> +    (name "perl-log-log4perl")
> +    (version "1.47")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
> +    (build-system perl-build-system)
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Log4perl")
> +    (synopsis "Log4j implementation for Perl")
> +    (description "Log::Log4perl lets you remote-control and fine-tune the
> +logging behaviour of your system from the outside.  It implements the widely
> +popular (Java-based) Log4j logging package in pure Perl.
> +
> +For a detailed tutorial on Log::Log4perl usage, please read
> +
> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")

Is it appropriate to wrap this URL in some tex? I'm not sure what would 
be appropriate in this case. Otherwise LGTM.

> +    (license (package-license perl))))
> +
>   (define-public perl-log-report-optional
>     (package
>       (name "perl-log-report-optional")
Ludovic Courtès July 17, 2016, 1:27 p.m. UTC | #2
Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 17/07/16 04:20, Alex Sassmannshausen wrote:
>> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
>> ---
>>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
>> index 486dbc2..fc63df3 100644
>> --- a/gnu/packages/perl.scm
>> +++ b/gnu/packages/perl.scm
>> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>>   mechanism.")
>>       (license (package-license perl))))
>>   +(define-public perl-log-log4perl
>> +  (package
>> +    (name "perl-log-log4perl")
>> +    (version "1.47")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
>> +             version
>> +             ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
>> +    (build-system perl-build-system)
>> +    (home-page
>> +     "http://search.cpan.org/dist/Log-Log4perl")
>> +    (synopsis "Log4j implementation for Perl")
>> +    (description "Log::Log4perl lets you remote-control and fine-tune the
>> +logging behaviour of your system from the outside.  It implements the widely
>> +popular (Java-based) Log4j logging package in pure Perl.
>> +
>> +For a detailed tutorial on Log::Log4perl usage, please read
>> +
>> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")
>
> Is it appropriate to wrap this URL in some tex? I'm not sure what
> would be appropriate in this case. Otherwise LGTM.

I think “For a detailed tutorial …” doesn’t belong in the description.
The description should just give an idea of what this is about, IMO.

Alex, could you also wrap module names in @code{}?

Otherwise LGTM, thanks!

Ludo’.
diff mbox

Patch

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 486dbc2..fc63df3 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@  whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-log4perl
+  (package
+    (name "perl-log-log4perl")
+    (version "1.47")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
+    (build-system perl-build-system)
+    (home-page
+     "http://search.cpan.org/dist/Log-Log4perl")
+    (synopsis "Log4j implementation for Perl")
+    (description "Log::Log4perl lets you remote-control and fine-tune the
+logging behaviour of your system from the outside.  It implements the widely
+popular (Java-based) Log4j logging package in pure Perl.
+
+For a detailed tutorial on Log::Log4perl usage, please read
+
+http://www.perl.com/pub/a/2002/09/11/log4perl.html")
+    (license (package-license perl))))
+
 (define-public perl-log-report-optional
   (package
     (name "perl-log-report-optional")