diff mbox

gnu: Remove redundancy where mkdir-p <dir> is followed by install-file <file> <dir>.

Message ID 1a37cdc052637ac3f759b87777d35706@mykolab.ch
State New
Headers show

Commit Message

Petter Nov. 21, 2016, 7:06 p.m. UTC
Hi,

Leo: Aha, yes you are right. I copy+pasted, and didn't realize those 
[source]
bits referred to fields in a recipe... Now I do, thanks! :)

Sure, I bring to you, two patches this time. One for master, and one for
core-updates. Not sure how to name the patch files properly, so I just 
put
branch name at the end.

Ludo: I like nitpicking ;)

I checked the packages with `guix refresh -l`, output below:

No dependents other than itself: eigensoft-6.1.2-1.b14d1e202
No dependents other than itself: snap-aligner-1.0beta.18
No dependents other than itself: pardre-1.1.5
No dependents other than itself: piranha-1.2.1-1.0466d364b
No dependents other than itself: hypre-2.11.0
No dependents other than itself: mpc123-0.2.4
No dependents other than itself: tuxguitar-1.3.2
No dependents other than itself: impressive-0.11.1

$ guix refresh -l bwa@0.7.12
   A single dependent package: bamm-1.7.3

$ guix refresh -l qemu@2.7.0
   Building the following 2 packages would ensure 5 dependent packages 
are
   rebuilt: virt-manager-1.4.0 python-libvirt-2.0.0



Let me know if there are any more issues.


Best,
Petter

On 2016-11-20 18:05, Leo Famulari wrote:
> On Sun, Nov 20, 2016 at 04:28:29PM +0100, Petter wrote:
>> From 595d438789c7c9a293ae7fac500ace7422073624 Mon Sep 17 00:00:00 2001
>> From: Petter <petter@mykolab.ch>
>> Date: Sun, 20 Nov 2016 13:39:13 +0100
>> Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is 
>> followed by
>>  install-file <file> <dir>.
>> 
>> * gnu/packages/bioinformatics.scm (bwa)[source]: Remove redundant 
>> mkdir-p.
>> * gnu/packages/bioinformatics.scm (eigensoft)[source]: Likewise.
>> * gnu/packages/bioinformatics.scm (snap-aligner)[source]: Likewise.
>> * gnu/packages/bioinformatics.scm (pardre)[source]: Likewise.
>> * gnu/packages/bioinformatics.scm (piranha)[source]: Likewise.
>> * gnu/packages/maths.scm (hypre)[source]: Likewise.
>> * gnu/packages/mp3.scm (mpc123)[source]: Likewise.
>> * gnu/packages/music.scm (tuxguitar)[source]: Likewise.
>> * gnu/packages/pdf.scm (impressive)[source]: Likewise.
>> * gnu/packages/qemu.scm (qemu)[source]: Likewise.
>> * gnu/packages/tls.scm (openssl)[source]: Likewise.
> 
> Thanks! A few requests...
> 
> First, I think that most, if not all, of these changes are not in the
> [source] field of the changed package definitions. I bet that they are
> all in the [arguments] field. Can you send a revised patch with an
> updated commit message?
> 
> Second, we can't change the OpenSSL package on the master branch,
> because many things depend on it:
> 
> $ guix refresh -l openssl@1.0.2
> Building the following 1090 packages would ensure 2981 dependent
> packages are rebuilt
> [...]
> 
> We do non-security related changes to that sort of "core" package on 
> the
> core-updates branch, which is merged into master every couple months.
> Otherwise, we'd be rebuilding everything constantly, and users would be
> unhappy.
> 
> So, will you submit a separate patch for the OpenSSL change? Make sure
> it applies cleanly to the core-updates branch. You don't need to try
> building this; it will take forever, as you noticed.

Comments

Leo Famulari Nov. 21, 2016, 7:43 p.m. UTC | #1
On Mon, Nov 21, 2016 at 08:06:21PM +0100, Petter wrote:
> Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by  
>  install-file <file> <dir>.
> 
> * gnu/packages/bioinformatics.scm (bwa)[arguments]: Remove redundant mkdir-p.
> (eigensoft)[arguments]: Likewise.
> (snap-aligner)[arguments]: Likewise.
> (pardre)[arguments]: Likewise.
> (piranha)[arguments]: Likewise.
> * gnu/packages/maths.scm (hypre)[arguments]: Likewise.
> * gnu/packages/mp3.scm (mpc123)[arguments]: Likewise.
> * gnu/packages/music.scm (tuxguitar)[arguments]: Likewise.
> * gnu/packages/pdf.scm (impressive)[arguments]: Likewise.
> * gnu/packages/qemu.scm (qemu)[arguments]: Likewise.

Thanks! Pushed as daf72603ebcd7e78222d16273d4cda4e71a156de

> Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by  
>  install-file <file> <dir>.
> 
> * gnu/packages/tls.scm (openssl)[arguments]: Remove redundant (mkdir-p).

I mentioned the package name in the commit title (this is our normal
practice), shortened the title, and pushed as
6e388b08399b322121d9113ab7367366ad14eba0. Thanks!
diff mbox

Patch

From 0a669c5f0e23cc133971a91926b100cd0c37e949 Mon Sep 17 00:00:00 2001
From: Petter <petter@mykolab.ch>
Date: Mon, 21 Nov 2016 19:30:50 +0100
Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by  
 install-file <file> <dir>.

* gnu/packages/tls.scm (openssl)[arguments]: Remove redundant (mkdir-p).
---
 gnu/packages/tls.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index 74cc25b..bea15fa 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -294,7 +294,6 @@  required structures.")
                    (lib    (string-append out "/lib"))
                    (static (assoc-ref outputs "static"))
                    (slib   (string-append static "/lib")))
-              (mkdir-p slib)
               (for-each (lambda (file)
                           (install-file file slib)
                           (delete-file file))
-- 
2.10.1