diff mbox

[3/5] gnu: python-zope-testing: Strip byte-code and garbage from source.

Message ID 1476105003-29538-4-git-send-email-h.goebel@crazy-compilers.com
State New
Headers show

Commit Message

Hartmut Goebel Oct. 10, 2016, 1:10 p.m. UTC
* gnu/package/python.scm (python-zope-testing): Add snippet to strip
  byte-code and garbage from source.
---
 gnu/packages/python.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Leo Famulari Oct. 12, 2016, 3:59 p.m. UTC | #1
On Mon, Oct 10, 2016 at 03:10:01PM +0200, Hartmut Goebel wrote:
> * gnu/package/python.scm (python-zope-testing): Add snippet to strip
>   byte-code and garbage from source.

Again, mention both python-zope-testing and python2-zope-testing, and
indicate that the changes are in [source].

Also, I think we should be more descriptive than "garbage".

> ---
>  gnu/packages/python.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 345c6a7..a289093 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6647,7 +6647,13 @@ that have uses outside of the Zope framework.")
>                             "/zope.testing/zope.testing-" version ".tar.gz"))
>         (sha256
>          (base32
> -         "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))))
> +         "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        '(begin
> +           ;; Source contains .pyc files and some garbage

Please use a complete sentence here.

> +           (for-each delete-file (find-files "." "(\\.pyc|~)$"))
> +           #t))))
>      (build-system python-build-system)
>      (native-inputs
>       `(("python-zope-exceptions" ,python-zope-exceptions)))

LGTM with the requested changes.
diff mbox

Patch

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 345c6a7..a289093 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6647,7 +6647,13 @@  that have uses outside of the Zope framework.")
                            "/zope.testing/zope.testing-" version ".tar.gz"))
        (sha256
         (base32
-         "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))))
+         "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))
+       (modules '((guix build utils)))
+       (snippet
+        '(begin
+           ;; Source contains .pyc files and some garbage
+           (for-each delete-file (find-files "." "(\\.pyc|~)$"))
+           #t))))
     (build-system python-build-system)
     (native-inputs
      `(("python-zope-exceptions" ,python-zope-exceptions)))