diff mbox

gnu: Add chromaprint.

Message ID 1474913985-26107-1-git-send-email-h.goebel@crazy-compilers.com
State New
Headers show

Commit Message

Hartmut Goebel Sept. 26, 2016, 6:19 p.m. UTC
* gnu/packages/mp3.scm (chromaprint): New variable.
---
 gnu/packages/mp3.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Ludovic Courtès Oct. 19, 2016, 8:25 p.m. UTC | #1
Hi!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/mp3.scm (chromaprint): New variable.

[...]

> +(define-public chromaprint
> +  (package
> +    (name "chromaprint")
> +    (version "1.3.2")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (string-append
> +            "https://bitbucket.org/acoustid/chromaprint/downloads/"
> +            "chromaprint-" version ".tar.gz"))
> +      (sha256
> +       (base32 "0lln8dh33gslb9cbmd1hcv33pr6jxdwipd8m8gbsyhksiq6r1by3"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; tests require googletest *sources*

Weird.

> +    (synopsis "Audio fingerprinting library")
> +    (description "Chromaprint is a library for calculating audio
> +fingerprints which are used by the Acoustid service.  Its main purpose
> +is to provide an accurate identifier for record tracks")
                                                         ^
Missing period.

OK with this change, thank you!

Ludo’.
Hartmut Goebel Oct. 20, 2016, 7:08 a.m. UTC | #2
Am 19.10.2016 um 22:25 schrieb Ludovic Courtès:
>> > +    (arguments
>> > +     `(#:tests? #f ; tests require googletest *sources*
> Weird.
>

Yes. From the issue I opened on this:[1]

    That's the recommended way to use gtest. It's a C++ library and the
    ABI depends on many compiler options. Debian based distributions
    don't even ship a compiled package of gtest anymore.


IMHO gtest should get onto the list of "software to note use".

[1]https://bitbucket.org/acoustid/chromaprint/issues/19/build-failure-googletest-sources-are
Ludovic Courtès Oct. 20, 2016, 12:57 p.m. UTC | #3
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 19.10.2016 um 22:25 schrieb Ludovic Courtès:
>>> > +    (arguments
>>> > +     `(#:tests? #f ; tests require googletest *sources*
>> Weird.
>>
>
> Yes. From the issue I opened on this:[1]
>
>     That's the recommended way to use gtest. It's a C++ library and the
>     ABI depends on many compiler options. Debian based distributions
>     don't even ship a compiled package of gtest anymore.

Uh, interesting.  :-)

Maybe in a future patch we can unpack it there so we can run the tests
the way they recommend.

Thanks for the info,
Ludo’.
diff mbox

Patch

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 37407cd..3cb653a 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -25,6 +25,7 @@ 
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages gcc)
+  #:use-module (gnu packages boost)
   #:use-module (gnu packages cdrom)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gettext)
@@ -38,6 +39,7 @@ 
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages linux)               ;alsa-lib
+  #:use-module (gnu packages video)               ;ffmpeg
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
@@ -482,3 +484,31 @@  to write your own applications or plugins that are callable from the
 command-line tool.")
     (home-page "http://eyed3.nicfit.net/")
     (license license:gpl2+)))
+
+(define-public chromaprint
+  (package
+    (name "chromaprint")
+    (version "1.3.2")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append
+            "https://bitbucket.org/acoustid/chromaprint/downloads/"
+            "chromaprint-" version ".tar.gz"))
+      (sha256
+       (base32 "0lln8dh33gslb9cbmd1hcv33pr6jxdwipd8m8gbsyhksiq6r1by3"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f ; tests require googletest *sources*
+       ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
+       #:test-target "check"))
+    (inputs
+     ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
+     ;; use the same ffmpeg version as for acoustid-fingerprinter
+     `(("ffmpeg" ,ffmpeg)
+       ("boots" ,boost)))
+    (home-page "http://wiki.acoustid.org/wiki/Chromaprint")
+    (synopsis "Audio fingerprinting library")
+    (description "Chromaprint is a library for calculating audio
+fingerprints which are used by the Acoustid service.  Its main purpose
+is to provide an accurate identifier for record tracks")
+    (license license:lgpl2.1+)))