diff mbox

[4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag.

Message ID 1472321979-10150-4-git-send-email-john@darrington.wattle.id.au
State New
Headers show

Commit Message

John Darrington Aug. 27, 2016, 6:19 p.m. UTC
From: John Darrington <jmd@gnu.org>

* gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
configure flag.
[inputs]: Add mit-krb5
---
 gnu/packages/onc-rpc.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Efraim Flashner Aug. 28, 2016, 9:43 a.m. UTC | #1
On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
> From: John Darrington <jmd@gnu.org>
> 
> * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
> configure flag.
> [inputs]: Add mit-krb5
> ---
>  gnu/packages/onc-rpc.scm | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
> index d9b2f9d..d5858e8 100644
> --- a/gnu/packages/onc-rpc.scm
> +++ b/gnu/packages/onc-rpc.scm
> @@ -20,6 +20,7 @@
>    #:use-module (guix licenses)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> +  #:use-module (gnu packages mit-krb5)
>    #:use-module (guix build-system gnu))
>  
>  (define-public libtirpc
> @@ -36,16 +37,14 @@
>                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(;; Doesn't work with GNU GSS.
> -       #:configure-flags '("--disable-gssapi")
> -
> -       #:phases (alist-cons-after
> +     '(#:phases (alist-cons-after
>                   'unpack 'remote-dangling-symlink
>                   (lambda _
>                     ;; Remote the dangling symlinks since it breaks the
>                     ;; 'patch-source-shebangs' file tree traversal.
>                     (delete-file "INSTALL"))
>                   %standard-phases)))
> +    (inputs `(("mit-krb5" ,mit-krb5)))
>      (home-page "http://sourceforge.net/projects/libtirpc/")
>      (synopsis "Transport-independent Sun/ONC RPC implementation")
>      (description
> -- 
> 2.1.4
> 

Has the issue with GNU GSS been fixed? Also, this would be a good time
to switch to modify-phases while you're already touching the package.
John Darrington Aug. 28, 2016, 9:45 a.m. UTC | #2
On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote:
     On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
     > From: John Darrington <jmd@gnu.org>
     > 
     > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
     > configure flag.
     > [inputs]: Add mit-krb5
     > ---
     >  gnu/packages/onc-rpc.scm | 7 +++----
     >  1 file changed, 3 insertions(+), 4 deletions(-)
     > 
     > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
     > index d9b2f9d..d5858e8 100644
     > --- a/gnu/packages/onc-rpc.scm
     > +++ b/gnu/packages/onc-rpc.scm
     > @@ -20,6 +20,7 @@
     >    #:use-module (guix licenses)
     >    #:use-module (guix packages)
     >    #:use-module (guix download)
     > +  #:use-module (gnu packages mit-krb5)
     >    #:use-module (guix build-system gnu))
     >  
     >  (define-public libtirpc
     > @@ -36,16 +37,14 @@
     >                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
     >      (build-system gnu-build-system)
     >      (arguments
     > -     '(;; Doesn't work with GNU GSS.
     > -       #:configure-flags '("--disable-gssapi")
     > -
     > -       #:phases (alist-cons-after
     > +     '(#:phases (alist-cons-after
     >                   'unpack 'remote-dangling-symlink
     >                   (lambda _
     >                     ;; Remote the dangling symlinks since it breaks the
     >                     ;; 'patch-source-shebangs' file tree traversal.
     >                     (delete-file "INSTALL"))
     >                   %standard-phases)))
     > +    (inputs `(("mit-krb5" ,mit-krb5)))
     >      (home-page "http://sourceforge.net/projects/libtirpc/")
     >      (synopsis "Transport-independent Sun/ONC RPC implementation")
     >      (description
     > -- 
     > 2.1.4
     > 
     
     Has the issue with GNU GSS been fixed? Also, this would be a good time
     to switch to modify-phases while you're already touching the package.

I'm not aware of any issue with GNU GSS which needs to be fixed.  It is not
an input to this package.  I don't think there is any connection.

I'll have a look to see if modify-phases makes things simpler.

J'
Ludovic Courtès Aug. 29, 2016, 4:52 p.m. UTC | #3
John Darrington <john@darrington.wattle.id.au> skribis:

> On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote:
>      On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
>      > From: John Darrington <jmd@gnu.org>
>      > 
>      > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
>      > configure flag.
>      > [inputs]: Add mit-krb5
>      > ---
>      >  gnu/packages/onc-rpc.scm | 7 +++----
>      >  1 file changed, 3 insertions(+), 4 deletions(-)
>      > 
>      > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
>      > index d9b2f9d..d5858e8 100644
>      > --- a/gnu/packages/onc-rpc.scm
>      > +++ b/gnu/packages/onc-rpc.scm
>      > @@ -20,6 +20,7 @@
>      >    #:use-module (guix licenses)
>      >    #:use-module (guix packages)
>      >    #:use-module (guix download)
>      > +  #:use-module (gnu packages mit-krb5)
>      >    #:use-module (guix build-system gnu))
>      >  
>      >  (define-public libtirpc
>      > @@ -36,16 +37,14 @@
>      >                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
>      >      (build-system gnu-build-system)
>      >      (arguments
>      > -     '(;; Doesn't work with GNU GSS.
>      > -       #:configure-flags '("--disable-gssapi")
>      > -
>      > -       #:phases (alist-cons-after
>      > +     '(#:phases (alist-cons-after
>      >                   'unpack 'remote-dangling-symlink
>      >                   (lambda _
>      >                     ;; Remote the dangling symlinks since it breaks the
>      >                     ;; 'patch-source-shebangs' file tree traversal.
>      >                     (delete-file "INSTALL"))
>      >                   %standard-phases)))
>      > +    (inputs `(("mit-krb5" ,mit-krb5)))
>      >      (home-page "http://sourceforge.net/projects/libtirpc/")
>      >      (synopsis "Transport-independent Sun/ONC RPC implementation")
>      >      (description
>      > -- 
>      > 2.1.4
>      > 
>      
>      Has the issue with GNU GSS been fixed? Also, this would be a good time
>      to switch to modify-phases while you're already touching the package.
>
> I'm not aware of any issue with GNU GSS which needs to be fixed.  It is not
> an input to this package.  I don't think there is any connection.

It’s preferable to use GNU GSS rather than mit-krb5 if that’s possible,
which maybe it isn’t.

> I'll have a look to see if modify-phases makes things simpler.

Regardless, the patch LGTM.

Thanks,
Ludo’.
John Darrington Aug. 29, 2016, 7:51 p.m. UTC | #4
On Mon, Aug 29, 2016 at 06:52:41PM +0200, Ludovic Court??s wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote:
     >      On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote:
     >      > From: John Darrington <jmd@gnu.org>
     >      > 
     >      > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --disable-gssapi
     >      > configure flag.
     >      > [inputs]: Add mit-krb5
     >      > ---
     >      >  gnu/packages/onc-rpc.scm | 7 +++----
     >      >  1 file changed, 3 insertions(+), 4 deletions(-)
     >      > 
     >      > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
     >      > index d9b2f9d..d5858e8 100644
     >      > --- a/gnu/packages/onc-rpc.scm
     >      > +++ b/gnu/packages/onc-rpc.scm
     >      > @@ -20,6 +20,7 @@
     >      >    #:use-module (guix licenses)
     >      >    #:use-module (guix packages)
     >      >    #:use-module (guix download)
     >      > +  #:use-module (gnu packages mit-krb5)
     >      >    #:use-module (guix build-system gnu))
     >      >  
     >      >  (define-public libtirpc
     >      > @@ -36,16 +37,14 @@
     >      >                  "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
     >      >      (build-system gnu-build-system)
     >      >      (arguments
     >      > -     '(;; Doesn't work with GNU GSS.
     >      > -       #:configure-flags '("--disable-gssapi")
     >      > -
     >      > -       #:phases (alist-cons-after
     >      > +     '(#:phases (alist-cons-after
     >      >                   'unpack 'remote-dangling-symlink
     >      >                   (lambda _
     >      >                     ;; Remote the dangling symlinks since it breaks the
     >      >                     ;; 'patch-source-shebangs' file tree traversal.
     >      >                     (delete-file "INSTALL"))
     >      >                   %standard-phases)))
     >      > +    (inputs `(("mit-krb5" ,mit-krb5)))
     >      >      (home-page "http://sourceforge.net/projects/libtirpc/")
     >      >      (synopsis "Transport-independent Sun/ONC RPC implementation")
     >      >      (description
     >      > -- 
     >      > 2.1.4
     >      > 
     >      
     >      Has the issue with GNU GSS been fixed? Also, this would be a good time
     >      to switch to modify-phases while you're already touching the package.
     >
     > I'm not aware of any issue with GNU GSS which needs to be fixed.  It is not
     > an input to this package.  I don't think there is any connection.
     
     It???s preferable to use GNU GSS rather than mit-krb5 if that???s possible,
     which maybe it isn???t.

I don't think it is possible, for the simple reason that this is not what 
GSS is intended to do.  If however it transpires that GNU GSS does somehow
eventually do it, the  we can change it then.
diff mbox

Patch

diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm
index d9b2f9d..d5858e8 100644
--- a/gnu/packages/onc-rpc.scm
+++ b/gnu/packages/onc-rpc.scm
@@ -20,6 +20,7 @@ 
   #:use-module (guix licenses)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (gnu packages mit-krb5)
   #:use-module (guix build-system gnu))
 
 (define-public libtirpc
@@ -36,16 +37,14 @@ 
                 "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy5hs5"))))
     (build-system gnu-build-system)
     (arguments
-     '(;; Doesn't work with GNU GSS.
-       #:configure-flags '("--disable-gssapi")
-
-       #:phases (alist-cons-after
+     '(#:phases (alist-cons-after
                  'unpack 'remote-dangling-symlink
                  (lambda _
                    ;; Remote the dangling symlinks since it breaks the
                    ;; 'patch-source-shebangs' file tree traversal.
                    (delete-file "INSTALL"))
                  %standard-phases)))
+    (inputs `(("mit-krb5" ,mit-krb5)))
     (home-page "http://sourceforge.net/projects/libtirpc/")
     (synopsis "Transport-independent Sun/ONC RPC implementation")
     (description