diff mbox

[2/2] gnu: Add emacs-better-defaults.

Message ID 1464358215-4416-2-git-send-email-dthompson2@worcester.edu
State New
Headers show

Commit Message

David Thompson May 27, 2016, 2:10 p.m. UTC
* gnu/packages/emacs.scm (emacs-better-defaults): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Alex Kost May 28, 2016, 2:05 p.m. UTC | #1
David Thompson (2016-05-27 17:10 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-better-defaults): New variable.
> ---
>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 5d6db5a..105c25d 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1706,3 +1706,24 @@ It is recommended to use @code{clojure-mode} with paredit or smartparens.")
>  The purpose of this library is to wrap all the quirks and hassle of
>  @code{package.el} into a sane API.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-better-defaults
> +  (package
> +    (name "emacs-better-defaults")
> +    (version "0.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://stable.melpa.org/packages/better-defaults-"
> +                           version ".el"))

My understanding is that we prefer to retrieve a source directly from
the upstream, so it is better to use:

  https://github.com/technomancy/better-defaults/archive/0.1.3.tar.gz

Otherwise, LGTM.

> +       (sha256
> +        (base32
> +         "0lvpmja8i8v10lbcvzj6pd7vn9c7gnlbcddd416g2pjq0yydydgf"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/technomancy/better-defaults")
> +    (synopsis "Better defaults for Emacs")
> +    (description
> +     "Better defaults attempts to address the most obvious deficiencies of the
> +Emacs default configuration in uncontroversial ways that nearly everyone can
> +agree upon.")
> +    (license license:gpl3+)))
Ludovic Courtès May 28, 2016, 3:37 p.m. UTC | #2
David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/emacs.scm (emacs-better-defaults): New variable.

[...]

> +       (uri (string-append "http://stable.melpa.org/packages/better-defaults-"
> +                           version ".el"))

IIRC, MELPA URLs are not stable over time (modified in place) and for
this reason we usually fetch things from Git instead.

Could you do that here?

Otherwise LGTM, thanks!

Ludo’.
David Thompson May 30, 2016, 3:11 p.m. UTC | #3
On Sat, May 28, 2016 at 11:37 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Thompson <dthompson2@worcester.edu> skribis:
>
>> * gnu/packages/emacs.scm (emacs-better-defaults): New variable.
>
> [...]
>
>> +       (uri (string-append "http://stable.melpa.org/packages/better-defaults-"
>> +                           version ".el"))
>
> IIRC, MELPA URLs are not stable over time (modified in place) and for
> this reason we usually fetch things from Git instead.
>
> Could you do that here?

Fixed and pushed.  Thanks Ludo and Alex!

- Dave
Mark H Weaver May 31, 2016, 4:59 p.m. UTC | #4
"Thompson, David" <dthompson2@worcester.edu> writes:
> Fixed and pushed.  Thanks Ludo and Alex!

It fails to build on Hydra:

  http://hydra.gnu.org/build/1208688 (x86_64)
  http://hydra.gnu.org/build/1208304 (i686)
  http://hydra.gnu.org/build/1208517 (armhf)

Can you take a look?

      Mark
David Thompson May 31, 2016, 5:16 p.m. UTC | #5
On Tue, May 31, 2016 at 12:59 PM, Mark H Weaver <mhw@netris.org> wrote:
> "Thompson, David" <dthompson2@worcester.edu> writes:
>> Fixed and pushed.  Thanks Ludo and Alex!
>
> It fails to build on Hydra:
>
>   http://hydra.gnu.org/build/1208688 (x86_64)
>   http://hydra.gnu.org/build/1208304 (i686)
>   http://hydra.gnu.org/build/1208517 (armhf)

These jobs are for building emacs-constants, contributed by Federico
Beffa in February.  I took a look at the build log and the failure is
in the make-autoloads build phase which this patch set shouldn't have
affected.

- Dave
Alex Kost May 31, 2016, 8:53 p.m. UTC | #6
Mark H Weaver (2016-05-31 19:59 +0300) wrote:

> "Thompson, David" <dthompson2@worcester.edu> writes:
>> Fixed and pushed.  Thanks Ludo and Alex!
>
> It fails to build on Hydra:
>
>   http://hydra.gnu.org/build/1208688 (x86_64)
>   http://hydra.gnu.org/build/1208304 (i686)
>   http://hydra.gnu.org/build/1208517 (armhf)

This happened because the source was wrongfully renamed to ".el" while
it should be ".tar.gz".  Fixed by commit
37dbfc50841a8e91f9fb0dc80ff9b5f23de38689.
David Thompson May 31, 2016, 8:55 p.m. UTC | #7
On Tue, May 31, 2016 at 4:53 PM, Alex Kost <alezost@gmail.com> wrote:
> Mark H Weaver (2016-05-31 19:59 +0300) wrote:
>
>> "Thompson, David" <dthompson2@worcester.edu> writes:
>>> Fixed and pushed.  Thanks Ludo and Alex!
>>
>> It fails to build on Hydra:
>>
>>   http://hydra.gnu.org/build/1208688 (x86_64)
>>   http://hydra.gnu.org/build/1208304 (i686)
>>   http://hydra.gnu.org/build/1208517 (armhf)
>
> This happened because the source was wrongfully renamed to ".el" while
> it should be ".tar.gz".  Fixed by commit
> 37dbfc50841a8e91f9fb0dc80ff9b5f23de38689.

Ugh, sorry for that blunder.

- Dave
Mark H Weaver June 1, 2016, 2:07 a.m. UTC | #8
"Thompson, David" <dthompson2@worcester.edu> writes:

> On Tue, May 31, 2016 at 12:59 PM, Mark H Weaver <mhw@netris.org> wrote:
>> "Thompson, David" <dthompson2@worcester.edu> writes:
>>> Fixed and pushed.  Thanks Ludo and Alex!
>>
>> It fails to build on Hydra:
>>
>>   http://hydra.gnu.org/build/1208688 (x86_64)
>>   http://hydra.gnu.org/build/1208304 (i686)
>>   http://hydra.gnu.org/build/1208517 (armhf)
>
> These jobs are for building emacs-constants, contributed by Federico
> Beffa in February.  I took a look at the build log and the failure is
> in the make-autoloads build phase which this patch set shouldn't have
> affected.

Ah, indeed, I stand corrected.  Sorry for the noise.

      Mark
diff mbox

Patch

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 5d6db5a..105c25d 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1706,3 +1706,24 @@  It is recommended to use @code{clojure-mode} with paredit or smartparens.")
 The purpose of this library is to wrap all the quirks and hassle of
 @code{package.el} into a sane API.")
     (license license:gpl3+)))
+
+(define-public emacs-better-defaults
+  (package
+    (name "emacs-better-defaults")
+    (version "0.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://stable.melpa.org/packages/better-defaults-"
+                           version ".el"))
+       (sha256
+        (base32
+         "0lvpmja8i8v10lbcvzj6pd7vn9c7gnlbcddd416g2pjq0yydydgf"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/technomancy/better-defaults")
+    (synopsis "Better defaults for Emacs")
+    (description
+     "Better defaults attempts to address the most obvious deficiencies of the
+Emacs default configuration in uncontroversial ways that nearly everyone can
+agree upon.")
+    (license license:gpl3+)))