diff mbox

system: Do not export PS1 in /etc/skel/.bashrc.

Message ID 1462490303.3306950.599555329.53D21742@webmail.messagingengine.com
State New
Headers show

Commit Message

Alex Griffin May 5, 2016, 11:18 p.m. UTC
On Thu, May 5, 2016, at 05:34 PM, Efraim Flashner wrote:
> I'm totally not a lawyer, but I believe officially and legally any
> change you make is yours and needs/should have a copyright line.
> On the other side, I believe that if you make a change and don't
> attach your name to it then it's as if you've tossed it into the file
> with all the other commits there and it can be assumed to follow the
> rest of the file/project in terms of copyright.

Okay, well I'll just go by that policy then unless someone else
disagrees. Here's an updated patch with a copyright line.

Comments

Ludovic Courtès May 6, 2016, 10:18 a.m. UTC | #1
Alex Griffin <a@ajgrf.com> skribis:

> On Thu, May 5, 2016, at 05:34 PM, Efraim Flashner wrote:
>> I'm totally not a lawyer, but I believe officially and legally any
>> change you make is yours and needs/should have a copyright line.
>> On the other side, I believe that if you make a change and don't
>> attach your name to it then it's as if you've tossed it into the file
>> with all the other commits there and it can be assumed to follow the
>> rest of the file/project in terms of copyright.
>
> Okay, well I'll just go by that policy then unless someone else
> disagrees. Here's an updated patch with a copyright line.

Yeah I think it’s reasonable.

> From d635ffb29d3755acaa646c293543d4a6a27cc9b4 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a@ajgrf.com>
> Date: Thu, 5 May 2016 09:59:03 -0500
> Subject: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

Indeed, good catch.

Committed with a ChangeLog-style commit log, thank you!

Ludo’.
diff mbox

Patch

From d635ffb29d3755acaa646c293543d4a6a27cc9b4 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Thu, 5 May 2016 09:59:03 -0500
Subject: [PATCH] system: Do not export PS1 in /etc/skel/.bashrc.

---
 gnu/system/shadow.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/system/shadow.scm b/gnu/system/shadow.scm
index a13ef11..b8837c6 100644
--- a/gnu/system/shadow.scm
+++ b/gnu/system/shadow.scm
@@ -1,5 +1,6 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -166,9 +167,9 @@  fi
 # Adjust the prompt depending on whether we're in 'guix environment'.
 if [ -n \"$GUIX_ENVIRONMENT\" ]
 then
-    export PS1='\\u@\\h \\w [env]\\$ '
+    PS1='\\u@\\h \\w [env]\\$ '
 else
-    export PS1='\\u@\\h \\w\\$ '
+    PS1='\\u@\\h \\w\\$ '
 fi
 alias ls='ls -p --color'
 alias ll='ls -l'\n"))
-- 
2.7.4