From patchwork Fri Jul 21 23:23:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 21727 Received: (qmail 122263 invoked by alias); 21 Jul 2017 23:23:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 122221 invoked by uid 89); 21 Jul 2017 23:23:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A9C085545 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9A9C085545 From: DJ Delorie To: "H.J. Lu" Cc: sellcey@cavium.com, libc-alpha@sourceware.org Subject: Re: [Patch] Fix nss/nss_test1.c compile with latest GCC In-Reply-To: <20170721231747.GA19787@gmail.com> (hjl.tools@gmail.com) Date: Fri, 21 Jul 2017 19:23:30 -0400 Message-ID: MIME-Version: 1.0 I think the right solution is to fix test5. I suspect that leaving in "bad" default data is a good test for a properly configured test,a and we might want to add some "bad" default group data as well. diff --git a/nss/tst-nss-test5.c b/nss/tst-nss-test5.c index b70f21e..fef41f0 100644 --- a/nss/tst-nss-test5.c +++ b/nss/tst-nss-test5.c @@ -65,7 +65,7 @@ do_test (void) int i; struct passwd *p; - __nss_configure_lookup ("passwd", "test1 test2"); + __nss_configure_lookup ("passwd", "test1"); setpwent ();