From patchwork Tue Jul 11 08:10:20 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Mike FABIAN <mfabian@redhat.com>
X-Patchwork-Id: 21539
Received: (qmail 80251 invoked by alias); 11 Jul 2017 08:10:26 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 80189 invoked by uid 89); 11 Jul 2017 08:10:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: =?ISO-8859-1?Q?No,
	score=-22.9 required=5.0 tests=BAYES_00, BODY_8BITS,
	GARBLED_BODY, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,
	GIT_PATCH_3, RP_MATCHES_RCVD,
	SPF_HELO_PASS autolearn=ham version=3.3.2 spammy==d8=a7=d9,
	=d8=b9=d9, =d8=ac=d9, =d8=ae=d9?=
X-HELO: mx1.redhat.com
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5CBC5C0587D1
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com;
	dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com;
	spf=pass smtp.mailfrom=mfabian@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5CBC5C0587D1
From: Mike FABIAN <mfabian@redhat.com>
To: Akhilesh Kumar <akhilesh.k@samsung.com>
Cc: libc-alpha@sourceware.org,  pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] Fixed abday for ar_SA
References: 
 <CGME20170711042027epcas5p2868a2ade6b46613f5d06c0d15ddd50f1@epcas5p2.samsung.com>
	<1499746618-7623-1-git-send-email-akhilesh.k@samsung.com>
Date: Tue, 11 Jul 2017 10:10:20 +0200
In-Reply-To: <1499746618-7623-1-git-send-email-akhilesh.k@samsung.com>
	(Akhilesh Kumar's message of "Tue, 11 Jul 2017 09:46:58 +0530")
Message-ID: <s9dvamzfl77.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0

Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21748]
> 	Fixed abday for ar_SA
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>  localedata/locales/ar_SA | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/localedata/locales/ar_SA b/localedata/locales/ar_SA
> index 1987085..a39eb5f 100644
> --- a/localedata/locales/ar_SA
> +++ b/localedata/locales/ar_SA
> @@ -316,13 +316,13 @@ day     "<U0627><U0644><U0623><U062D><U062F>"; /
>          "<U0627><U0644><U062E><U0645><U064A><U0633>"; /
>          "<U0627><U0644><U062C><U0645><U0639><U0640><U0629>"; /
>          "<U0627><U0644><U0633><U0628><U062A>"
> -abday   "<U0053><U0075><U006E>"; /
> -        "<U004D><U006F><U006E>"; /
> -        "<U0054><U0075><U0065>"; /
> -        "<U0057><U0065><U0064>"; /
> -        "<U0054><U0068><U0075>"; /
> -        "<U0046><U0072><U0069>"; /
> -        "<U0053><U0061><U0074>"
> +abday   "<U062F>"; /
> +        "<U0646>"; /
> +        "<U062B>"; /
> +        "<U0639>"; /
> +        "<U062E>"; /
> +        "<U062C>"; /
> +        "<U0633>"
>  mon     "<U064A><U0646><U0627><U064A><U0631>";/
>          "<U0641><U0628><U0631><U0627><U064A><U0631>";/
>          "<U0645><U0627><U0631><U0633>";/


That might be OK.

Using 3 letter abbreviations for Arabic doesn’t seem to make any sense,
CLDR uses the full versions in "abbreviated", but CLDR uses one letter
abbreviations in “narrow”.

But the above does not agree with CLDR, see:

http://unicode.org/cldr/trac/browser/trunk/common/main/ar.xml#L1542

which has:

	<dayWidth type="narrow">
		<day type="sun">ح</day>
		<day type="mon">ن</day>
		<day type="tue">ث</day>
		<day type="wed">ر</day>
		<day type="thu">خ</day>
		<day type="fri">ج</day>
		<day type="sat">س</day>
	</dayWidth>
	
Your abbreviations for Sunday and Wednesday are different from
what CLDR has.

diff --git a/localedata/locales/ar_SA b/localedata/locales/ar_SA
index 1987085..a39eb5f 100644
--- a/localedata/locales/ar_SA
+++ b/localedata/locales/ar_SA
@@ -316,13 +316,13 @@ day     "الأحد"; /
         "الخميس"; /
         "الجمعـة"; /
         "السبت"
-abday   "Sun"; /
-        "Mon"; /
-        "Tue"; /
-        "Wed"; /
-        "Thu"; /
-        "Fri"; /
-        "Sat"
+abday   "د"; /
+        "Ù†"; /
+        "Ø«"; /
+        "ع"; /
+        "Ø®"; /
+        "ج"; /
+        "س"
 mon     "يناير";/
         "فبراير";/
         "مارس";/