Message ID | mhng-ea008aed-2764-44a7-8bcb-f0512da9cdff@palmer-si-x1c4 |
---|---|
State | Dropped |
Headers | show |
On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote: > I'm checking via build-many-glibc.py to make sure this builds, but as > that never sets CPPFLAGS I don't think it'll find any potential issues. Since CPPFLAGS is always set by our makefiles I don't understand this comment. Andreas.
On Mon, 18 Mar 2019 04:47:47 PDT (-0700), schwab@suse.de wrote: > On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote: > >> I'm checking via build-many-glibc.py to make sure this builds, but as >> that never sets CPPFLAGS I don't think it'll find any potential issues. > > Since CPPFLAGS is always set by our makefiles I don't understand this > comment. My point is that bulid-many-glibcs.py isn't adding any additional CPPFLAGS, so we wouldn't notice anything that might crop up because of how users (who may have set some odd CPPFLAGS) build their glibc. Maybe that's being too paranoid, though?
On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote: > My point is that bulid-many-glibcs.py isn't adding any additional > CPPFLAGS, so we wouldn't notice anything that might crop up because of how > users (who may have set some odd CPPFLAGS) build their glibc. > > Maybe that's being too paranoid, though? Users setting CPPFLAGS need to be careful anyway. Andreas.
On Mon, 18 Mar 2019 05:11:26 PDT (-0700), schwab@suse.de wrote: > On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote: > >> My point is that bulid-many-glibcs.py isn't adding any additional >> CPPFLAGS, so we wouldn't notice anything that might crop up because of how >> users (who may have set some odd CPPFLAGS) build their glibc. >> >> Maybe that's being too paranoid, though? > > Users setting CPPFLAGS need to be careful anyway. OK, makes sense. I'll figure out what's going on with build-many-glibcs.py. Thanks!
diff --git a/Makerules b/Makerules index 83bdd3a44d0d..6d138eed613a 100644 --- a/Makerules +++ b/Makerules @@ -1423,7 +1423,7 @@ $(stdio_lim:h=st): $(..)stdio-common/stdio_lim.h.in $(..)Rules \ { echo '#include "$(..)posix/bits/posix1_lim.h"'; \ } | \ $(CC) -E -dM -MD -MP -MF $(@:st=dT) -MT '$(@:st=h) $(@:st=d)' \ - $(CPPUNDEFS) $(+includes) -xc - -o $(@:st=hT) + $(CPPFLAGS) $(+includes) -xc - -o $(@:st=hT) sed $(sed-remove-objpfx) $(sed-remove-dotdot) \ $(@:st=dT) > $(@:st=dt) mv -f $(@:st=dt) $(@:st=d)