From patchwork Wed Apr 16 09:24:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 575 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 5B8AF360068 for ; Wed, 16 Apr 2014 02:24:33 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14307373) id 200624993C49; Wed, 16 Apr 2014 02:24:33 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id E70CE4993C49 for ; Wed, 16 Apr 2014 02:24:32 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=jec+ QIC3Y7uiz5G2dJHUWQTwYd4ZUa9E+rA67XU3AICEOHngOkl205R7Hp8dteCVNCM9 9RE3/t1NVbHjiK7xnhpamjtT0WopGbeTuT9srRlyBi+AuqjyD7wW328KWKC/lJB2 XvU1c/mT+TLROFY0EXsEct82tW+uWnxXGSuU4ys= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=qLHQHIQG8b PNNcSoBDjV0YIhxWY=; b=JSEx7Az3PGrp7kX9PywFhD/9APAEKA6ELhVRoJ7j04 sbVABgVG1oNMRqMbFJVWlC6ii0r8P2gfllVobKoyZD/Y3P5okgOqiVSMBvZa28KH o060IHHDg/1L6m09rSfj9wWpmgKaAN06iJf9RIX6WbQN+bkrPU1QwysQvkT8U56D 8= Received: (qmail 17046 invoked by alias); 16 Apr 2014 09:24:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 17034 invoked by uid 89); 16 Apr 2014 09:24:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler Subject: Re: [PATCH] Do not run timezone tests in parallel. Date: Wed, 16 Apr 2014 11:24:08 +0200 Lines: 55 Message-ID: References: Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: X-DH-Original-To: glibc@patchwork.siddhesh.in Thanks. You´re right. I missed the fact that it´s a pattern rule and thought it is a normal multiple target. The comment is relevant. ok? Bye. On 04/15/2014 05:14 PM, Andreas Schwab wrote: > Stefan Liebler writes: > >> @@ -102,7 +105,6 @@ $(testdata)/America/New_York: northamerica $(zic-deps) >> $(build-testdata) >> $(testdata)/Etc/UTC: etcetera $(zic-deps) >> $(build-testdata) >> -# Use a pattern rule to indicate the command produces both targets at once. >> # Two separate targets built separately can collide if in parallel. >> %/UTC %/Universal: simplebackw $(zic-deps) %/Etc/UTC >> $(build-testdata) > > Why is that comment no longer relevant? > > Andreas. > diff --git a/timezone/Makefile b/timezone/Makefile index 998cd14..decc28e 100644 --- a/timezone/Makefile +++ b/timezone/Makefile @@ -85,6 +85,9 @@ GCONV_PATH=${common-objpfx}iconvdata LANGUAGE=C LC_ALL=C \ $(evaluate-test) endef + +.NOTPARALLEL: + $(objpfx)test-tz.out: $(addprefix $(testdata)/, America/New_York Etc/UTC UTC) $(objpfx)tst-timezone.out: $(addprefix $(testdata)/, \ Europe/Berlin Universal \